address comments

This commit is contained in:
Jeff Zhang 2017-08-26 11:59:43 +08:00
parent b0b5c95a68
commit e869f31d07
3 changed files with 5 additions and 5 deletions

View file

@ -234,7 +234,7 @@ Otherwise it can be referred to as `%python.sql`
## IPython Support
IPython is more powerful than the default python interpreter with extra functionality. You can use IPython2 or IPython3 which depends on which python you set `zeppelin.python`.
IPython is more powerful than the default python interpreter with extra functionality. You can use IPython with Python2 or Python3 which depends on which python you set `zeppelin.python`.
**Pre-requests**
@ -243,7 +243,7 @@ IPython is more powerful than the default python interpreter with extra function
If you already install anaconda, then you just need to install `grpcio` as Jupyter is already included in anaconda.
Besides the basic function of python interpreter. You can use all the IPython advanced features as you use it in Jupyter Notebook.
In addition to all basic functions of the python interpreter, you can use all the IPython advanced features as you use it in Jupyter Notebook.
e.g.

View file

@ -119,7 +119,7 @@ public class PySparkInterpreter extends Interpreter implements ExecuteResultHand
iPySparkInterpreter.checkIPythonPrerequisite()) {
try {
iPySparkInterpreter.open();
if (property.getProperty("zeppelin.spark.useIPython", "true").equals("true")) {
if (InterpreterContext.get() != null) {
// don't print it when it is in testing, just for easy output check in test.
InterpreterContext.get().out.write(("IPython is available, " +
"use IPython for PySparkInterpreter\n")
@ -140,7 +140,7 @@ public class PySparkInterpreter extends Interpreter implements ExecuteResultHand
"use the native PySparkInterpreter\n")
.getBytes());
} catch (IOException e) {
LOGGER.warn("Fail to write InterpreterOutput", e.getMessage());
LOGGER.warn("Fail to write InterpreterOutput", e);
}
}

View file

@ -78,7 +78,7 @@ public class InterpreterOutputStream extends LogOutputStream {
@Override
protected void processLine(String s, int i) {
// logger.debug("Interpreter output:" + s);
logger.debug("Interpreter output:" + s);
}
@Override