Elgato_dark/zeppelin
1
0
Fork 0
mirror of https://github.com/apache/zeppelin synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: object-property-newline

Browse source 
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (7/0)
  ✖   45:26  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖   46:24  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖   46:40  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖   71:38  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖   76:36  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖   89:36  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖  102:36  Object properties must go on a new line if they aren't all on the same line  object-property-newline

/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (0/2)
  ⚠  132:37  Unexpected mix of '&&' and '||'  no-mixed-operators
  ⚠  132:54  Unexpected mix of '&&' and '||'  no-mixed-operators

/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium-conf.js (3/0)
  ✖  34:19  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖  34:41  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  ✖  35:21  Object properties must go on a new line if they aren't all on the same line  object-property-newline
```
This commit is contained in:
1ambda 2017-04-15 00:35:15 +09:00
parent 70cb63b742
commit d62af8d31b
6 changed files with 34 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
zeppelin-web/.eslintrc
View file

@ -31,7 +31,6 @@
"process": false
},
"rules": {
"object-property-newline": 0,
"dot-location": 0,
"brace-style": 0,
"one-var": 0,

7
zeppelin-web/src/app/helium/helium.config.js
View file

@ -31,8 +31,11 @@ export function mergePersistedConfWithSpec(persisted, spec) {
const value = (persistedValue) ? persistedValue : specField.defaultValue;
const merged = {
name: name, type: specField.type, description: specField.description,
value: value, defaultValue: specField.defaultValue,
name: name,
type: specField.type,
description: specField.description,
value: value,
defaultValue: specField.defaultValue,
};
confs.push(merged);

4
zeppelin-web/src/app/interpreter/interpreter.controller.js
View file

@ -119,7 +119,9 @@ function InterpreterCtrl($rootScope, $scope, $http, baseUrlSrv, ngToast, $timeou
if (setting.status === ParagraphStatus.ERROR || setting.errorReason) {
ngToast.danger({content: 'Error setting properties for interpreter \'' +
setting.group + '.' + setting.name + '\': ' + setting.errorReason,
verticalPosition: 'top', dismissOnTimeout: false});
verticalPosition: 'top',
dismissOnTimeout: false
});
}
}

4
zeppelin-web/src/app/notebook/notebook.controller.js
View file

@ -263,7 +263,9 @@ function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope,
}
} else {
ngToast.danger({content: 'There is a problem with this Revision',
verticalPosition: 'top', dismissOnTimeout: false});
verticalPosition: 'top',
dismissOnTimeout: false
});
}
};

25
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
View file

@ -42,8 +42,11 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
// transactional info for spell execution
$scope.spellTransaction = {
totalResultCount: 0, renderedResultCount: 0,
propagated: false, resultsMsg: [], paragraphText: '',
totalResultCount: 0,
renderedResultCount: 0,
propagated: false,
resultsMsg: [],
paragraphText: '',
};
var editorSetting = {};
@ -67,13 +70,18 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
websocketMsgSrv.runParagraph(paragraph.id, paragraph.title, paragraph.text,
paragraph.config, paragraph.settings.params);
} else {
ngToast.danger({content: 'Cannot find a paragraph with id \'' + paragraphId + '\'',
verticalPosition: 'top', dismissOnTimeout: false});
ngToast.danger({
content: 'Cannot find a paragraph with id \'' + paragraphId + '\'',
verticalPosition: 'top',
dismissOnTimeout: false
});
}
} else {
ngToast.danger({
content: 'Please provide a \'paragraphId\' when calling z.runParagraph(paragraphId)',
verticalPosition: 'top', dismissOnTimeout: false});
verticalPosition: 'top',
dismissOnTimeout: false
});
}
},
@ -86,7 +94,9 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
ngToast.danger({
content: 'Please provide a \'paragraphId\' when calling ' +
'z.angularBind(varName, value, \'PUT_HERE_PARAGRAPH_ID\')',
verticalPosition: 'top', dismissOnTimeout: false});
verticalPosition: 'top',
dismissOnTimeout: false
});
}
},
@ -99,7 +109,8 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
ngToast.danger({
content: 'Please provide a \'paragraphId\' when calling ' +
'z.angularUnbind(varName, \'PUT_HERE_PARAGRAPH_ID\')',
verticalPosition: 'top', dismissOnTimeout: false});
verticalPosition: 'top',
dismissOnTimeout: false});
}
}
};

7
zeppelin-web/src/components/helium/helium-conf.js
View file

@ -31,8 +31,11 @@ export function mergePersistedConfWithSpec(persisted, spec) {
const value = (persistedValue) ? persistedValue : specField.defaultValue;
const merged = {
name: name, type: specField.type, description: specField.description,
value: value, defaultValue: specField.defaultValue,
name: name,
type: specField.type,
description: specField.description,
value: value,
defaultValue: specField.defaultValue,
};
confs.push(merged);