ZEPPELIN-215: clean logging messages

This commit is contained in:
tzolov 2015-08-11 14:11:28 +02:00
parent 4dd2a36eec
commit d2393d6ec8
2 changed files with 7 additions and 5 deletions

View file

@ -14,6 +14,8 @@
*/
package org.apache.zeppelin.postgresql;
import static org.apache.commons.lang.StringUtils.containsIgnoreCase;
import java.io.IOException;
import java.sql.Connection;
import java.sql.DriverManager;
@ -25,7 +27,6 @@ import java.util.ArrayList;
import java.util.List;
import java.util.Properties;
import org.apache.commons.lang.StringUtils;
import org.apache.zeppelin.interpreter.Interpreter;
import org.apache.zeppelin.interpreter.InterpreterContext;
import org.apache.zeppelin.interpreter.InterpreterPropertyBuilder;
@ -182,7 +183,7 @@ public class PostgreSqlInterpreter extends Interpreter {
StringBuilder msg = null;
boolean isTableType = false;
if (StringUtils.containsIgnoreCase(sql, EXPLAIN_PREDICATE)) {
if (containsIgnoreCase(sql, EXPLAIN_PREDICATE)) {
msg = new StringBuilder();
} else {
msg = new StringBuilder(TABLE_MAGIC_TAG);
@ -262,6 +263,9 @@ public class PostgreSqlInterpreter extends Interpreter {
@Override
public void cancel(InterpreterContext context) {
logger.info("Cancel current query statement.");
if (currentStatement != null) {
try {
currentStatement.cancel();

View file

@ -102,7 +102,6 @@ public class SqlCompleter extends StringsCompleter {
try {
completions.addAll(getColumnNames(connection.getMetaData()));
completions.addAll(getSchemaNames(connection.getMetaData()));
logger.info("Udateds metadata with:" + Joiner.on(',').join(completions));
this.getStrings().addAll(completions);
} catch (SQLException e) {
@ -127,7 +126,6 @@ public class SqlCompleter extends StringsCompleter {
logger.info("JDBC DriverName:" + driverSpecificKeywords);
if (SqlCompleter.class.getResource(driverSpecificKeywords) != null) {
logger.info("JDBC DriverName: 2" + driverSpecificKeywords);
String driverKeywords =
new BufferedReader(new InputStreamReader(
SqlCompleter.class.getResourceAsStream(driverSpecificKeywords))).readLine();
@ -200,7 +198,7 @@ public class SqlCompleter extends StringsCompleter {
columns.close();
}
logger.info(Joiner.on(',').join(names));
logger.debug(Joiner.on(',').join(names));
return names;
} catch (Throwable t) {