test: Add tests for widget, params

zeppelin-web/src/app/tabledata/advanced-transformation-util.js

@@ -106,7 +106,7 @@ export function parseParameter(paramSpecs, param) {
       if (parsed[name] === 'false') {
         parsed[name] = false;
       } else if (parsed[name] === 'true') {
-        parsed[name] = false;
+        parsed[name] = true;
       } else if (typeof parsed[name] !== 'boolean') {
         parsed[name] = paramSpec.defaultValue;
       }

zeppelin-web/src/app/tabledata/advanced-transformation-util.test.js

@@ -0,0 +1,176 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as Util from './advanced-transformation-util.js'
+
+const MockParameter = {
+  'floatParam': { valueType: 'float', defaultValue: 10, description: '', },
+  'intParam': { valueType: 'int', defaultValue: 50, description: '', },
+  'jsonParam': { valueType: 'JSON', defaultValue: '', description: '', widget: 'textarea', },
+  'stringParam1': { valueType: 'string', defaultValue: '', description: '', },
+  'stringParam2': { valueType: 'string', defaultValue: '', description: '', widget: 'input', },
+  'boolParam': { valueType: 'boolean', defaultValue: false, description: '', widget: 'checkbox', },
+  'optionParam': { valueType: 'string', defaultValue: 'line', description: '', widget: 'option', optionValues: [ 'line', 'smoothedLine', ], },
+}
+
+const MockAxis1 = {
+  'keyAxis': { dimension: 'multiple', axisType: 'key', },
+  'aggrAxis': { dimension: 'multiple', axisType: 'aggregator', },
+  'groupAxis': { dimension: 'multiple', axisType: 'group', },
+}
+
+const MockAxis2 = {
+  'singleKeyAxis': { dimension: 'single', axisType: 'key', },
+  'limitedAggrAxis': { dimension: 'multiple', axisType: 'aggregator', maxAxisCount: 2, },
+  'singleGroupAxis': { dimension: 'single', axisType: 'group', },
+}
+
+const MockAxis3 = {
+  'customAxis1': { dimension: 'single', axisType: 'unique', },
+  'customAxis2': { dimension: 'multiple', axisType: 'value', },
+}
+
+const MockSpec = {
+  charts: {
+    'object-chart': {
+      transform: { method: 'object', },
+      sharedAxis: true,
+      axis: MockAxis1,
+      parameter: MockParameter,
+    },
+
+    'array-chart': {
+      transform: { method: 'array', },
+      sharedAxis: true,
+      axis: MockAxis1,
+      parameter: {
+        'arrayChartParam0': { valueType: 'string', defaultValue: '', description: 'param0', },
+      },
+    },
+
+    'drillDown-chart': {
+      transform: { method: 'drill-down', },
+      axis: MockAxis2,
+      parameter: {
+        'drillDownChartParam0': { valueType: 'string', defaultValue: '', description: 'param0', },
+      },
+    },
+
+    'raw-chart': {
+      transform: { method: 'raw', },
+      axis: MockAxis3,
+      parameter: {
+        'rawChartParam0': { valueType: 'string', defaultValue: '', description: 'param0', },
+      },
+    },
+  },
+}
+
+const mockConfig = {
+  chart: {
+
+  },
+
+  spec: MockSpec,
+}
+
+
+describe('advanced-transformation-util', () => {
+  describe('axis', () => {
+
+  })
+
+  describe('parameter:widget', () => {
+    it('isInputWidget', () => {
+      expect(Util.isInputWidget(MockParameter.stringParam1)).toBe(true)
+      expect(Util.isInputWidget(MockParameter.stringParam2)).toBe(true)
+
+      expect(Util.isInputWidget(MockParameter.boolParam)).toBe(false)
+      expect(Util.isInputWidget(MockParameter.jsonParam)).toBe(false)
+      expect(Util.isInputWidget(MockParameter.optionParam)).toBe(false)
+    })
+
+    it('isOptionWidget', () => {
+      expect(Util.isOptionWidget(MockParameter.optionParam)).toBe(true)
+
+      expect(Util.isOptionWidget(MockParameter.stringParam1)).toBe(false)
+      expect(Util.isOptionWidget(MockParameter.stringParam2)).toBe(false)
+      expect(Util.isOptionWidget(MockParameter.boolParam)).toBe(false)
+      expect(Util.isOptionWidget(MockParameter.jsonParam)).toBe(false)
+    })
+
+    it('isCheckboxWidget', () => {
+      expect(Util.isCheckboxWidget(MockParameter.boolParam)).toBe(true)
+
+      expect(Util.isCheckboxWidget(MockParameter.stringParam1)).toBe(false)
+      expect(Util.isCheckboxWidget(MockParameter.stringParam2)).toBe(false)
+      expect(Util.isCheckboxWidget(MockParameter.jsonParam)).toBe(false)
+      expect(Util.isCheckboxWidget(MockParameter.optionParam)).toBe(false)
+    })
+
+    it('isTextareaWidget', () => {
+      expect(Util.isTextareaWidget(MockParameter.jsonParam)).toBe(true)
+
+      expect(Util.isTextareaWidget(MockParameter.stringParam1)).toBe(false)
+      expect(Util.isTextareaWidget(MockParameter.stringParam2)).toBe(false)
+      expect(Util.isTextareaWidget(MockParameter.boolParam)).toBe(false)
+      expect(Util.isTextareaWidget(MockParameter.optionParam)).toBe(false)
+    })
+  })
+
+  describe('parameter:parseParameter', () => {
+    const paramSpec = Util.getSpecs(MockParameter)
+
+    it('should parse number', () => {
+      const params = { intParam: '3', }
+      const parsed = Util.parseParameter(paramSpec, params)
+      expect(parsed.intParam).toBe(3)
+    })
+
+    it('should parse float', () => {
+      const params = { floatParam: '0.10', }
+      const parsed = Util.parseParameter(paramSpec, params)
+      expect(parsed.floatParam).toBe(0.10)
+    })
+
+    it('should parse boolean', () => {
+      const params1 = { boolParam: 'true', }
+      const parsed1 = Util.parseParameter(paramSpec, params1)
+      expect(typeof parsed1.boolParam).toBe('boolean')
+      expect(parsed1.boolParam).toBe(true)
+
+      const params2 = { boolParam: 'false', }
+      const parsed2 = Util.parseParameter(paramSpec, params2)
+      expect(typeof parsed2.boolParam).toBe('boolean')
+      expect(parsed2.boolParam).toBe(false)
+    })
+
+    it('should parse JSON', () => {
+      const params = { jsonParam: '{ "a": 3 }', }
+      const parsed = Util.parseParameter(paramSpec, params)
+      expect(typeof parsed.jsonParam).toBe('object')
+      expect(JSON.stringify(parsed.jsonParam)).toBe('{"a":3}')
+    })
+
+    it('should not parse string', () => {
+      const params = { stringParam: 'example', }
+      const parsed = Util.parseParameter(paramSpec, params)
+      expect(typeof parsed.stringParam).toBe('string')
+      expect(parsed.stringParam).toBe('example')
+    })
+
+  })
+
+})
+