Elgato_dark/zeppelin
1
0
Fork 0
mirror of https://github.com/apache/zeppelin synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

remove usage of non-standard string method

Browse source 
use standard `indexOf` method instead of proprietary `contains` defined
on string by unknown library; it is a potential bug; also it doesn't add
much value at all, compare:
  stringValue.contains(delimiter)
  stringValue.indexOf(delimiter) > -1
This commit is contained in:
felizbear 2016-11-29 18:37:02 +09:00
parent cb5c8a414a
commit ae9820e1f3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
View file

@ -1338,7 +1338,7 @@
var dsvRow = '';
for (var index in row) {
var stringValue = (row[index]).toString();
if (stringValue.contains(delimiter)) {
if (stringValue.indexOf(delimiter) > -1) {
dsvRow += '"' + stringValue + '"' + delimiter;
} else {
dsvRow += row[index] + delimiter;