mirror of
https://github.com/apache/zeppelin
synced 2026-05-24 09:38:26 +00:00
fix: padded-blocks
``` /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteListDataFactory/noteList.datafactory.test.js (2/0) ✖ 1:43 Block must not be padded by blank lines padded-blocks ✖ 77:1 Block must not be padded by blank lines padded-blocks /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.js (1/0) ✖ 105:1 Block must not be padded by blank lines padded-blocks /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.test.js (1/0) ✖ 40:1 Block must not be padded by blank lines padded-blocks /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-import/notenameImport.controller.js (1/0) ✖ 114:5 Block must not be padded by blank lines padded-blocks /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js (1/0) ✖ 110:5 Block must not be padded by blank lines padded-blocks ```
This commit is contained in:
parent
5d19c6f5f2
commit
a3f1264676
18 changed files with 0 additions and 29 deletions
|
|
@ -39,7 +39,6 @@
|
|||
"standard/object-curly-even-spacing": 0,
|
||||
"no-eval": 0,
|
||||
"no-unneeded-ternary": 0,
|
||||
"padded-blocks": 0,
|
||||
"no-var": 0,
|
||||
"comma-dangle": 0,
|
||||
"semi": 0,
|
||||
|
|
|
|||
|
|
@ -25,5 +25,4 @@ describe('Controller: MainCtrl', function () {
|
|||
rootScope.$broadcast('setIframe', true);
|
||||
expect(scope.asIframe).toEqual(true);
|
||||
});
|
||||
|
||||
});
|
||||
|
|
|
|||
|
|
@ -390,7 +390,6 @@ function InterpreterCtrl ($rootScope, $scope, $http, baseUrlSrv, ngToast, $timeo
|
|||
if (result) {
|
||||
$http.delete(baseUrlSrv.getRestApiBase() + '/interpreter/setting/' + settingId)
|
||||
.success(function (data, status, headers, config) {
|
||||
|
||||
var index = _.findIndex($scope.interpreterSettings, {'id': settingId});
|
||||
$scope.interpreterSettings.splice(index, 1);
|
||||
}).error(function (data, status, headers, config) {
|
||||
|
|
|
|||
|
|
@ -155,7 +155,6 @@ function JobmanagerCtrl ($scope, websocketMsgSrv, $interval, ngToast, $q, $timeo
|
|||
var changeOriginTarget = indexStore[changedItem.noteId];
|
||||
|
||||
if (changedItem.isRemoved !== undefined && changedItem.isRemoved === true) {
|
||||
|
||||
// remove Item.
|
||||
var removeIndex = _.findIndex(indexStore, changedItem.noteId);
|
||||
if (removeIndex > -1) {
|
||||
|
|
@ -166,7 +165,6 @@ function JobmanagerCtrl ($scope, websocketMsgSrv, $interval, ngToast, $q, $timeo
|
|||
if (removeIndex) {
|
||||
jobInfomations.splice(removeIndex, 1);
|
||||
}
|
||||
|
||||
} else {
|
||||
// change value for item.
|
||||
changeOriginTarget.isRunningJob = changedItem.isRunningJob;
|
||||
|
|
|
|||
|
|
@ -105,5 +105,4 @@ function JobCtrl ($scope, $http, baseUrlSrv) {
|
|||
$scope.lastExecuteTime = function (unixtime) {
|
||||
return moment.unix(unixtime / 1000).fromNow();
|
||||
};
|
||||
|
||||
}
|
||||
|
|
|
|||
|
|
@ -335,7 +335,6 @@ function ParagraphCtrl ($scope, $rootScope, $route, $window, $routeParams, $loca
|
|||
|
||||
$scope.paragraph.results.msg = resultsMsg;
|
||||
$scope.paragraph.config.tableHide = false;
|
||||
|
||||
})
|
||||
.catch(error => {
|
||||
$scope.handleSpellError(paragraphText, error,
|
||||
|
|
@ -1054,7 +1053,6 @@ function ParagraphCtrl ($scope, $rootScope, $route, $window, $routeParams, $loca
|
|||
return angular.element('#p' + id + '_text')[0].scrollTop !== 0;
|
||||
}
|
||||
return false;
|
||||
|
||||
};
|
||||
|
||||
$scope.scrollParagraphUp = function (id) {
|
||||
|
|
@ -1191,7 +1189,6 @@ function ParagraphCtrl ($scope, $rootScope, $route, $window, $routeParams, $loca
|
|||
$scope.paragraph.text = newPara.text;
|
||||
$scope.dirtyText = undefined;
|
||||
$scope.originalText = angular.copy(newPara.text);
|
||||
|
||||
} else { // if there're local update, keep it.
|
||||
$scope.paragraph.text = newPara.text;
|
||||
}
|
||||
|
|
@ -1320,7 +1317,6 @@ function ParagraphCtrl ($scope, $rootScope, $route, $window, $routeParams, $loca
|
|||
|
||||
$scope.$on('keyEvent', function (event, keyEvent) {
|
||||
if ($scope.paragraphFocused) {
|
||||
|
||||
var paragraphId = $scope.paragraph.id;
|
||||
var keyCode = keyEvent.keyCode;
|
||||
var noShortcutDefined = false;
|
||||
|
|
|
|||
|
|
@ -1,5 +1,4 @@
|
|||
describe('Controller: ParagraphCtrl', function () {
|
||||
|
||||
beforeEach(angular.mock.module('zeppelinWebApp'));
|
||||
|
||||
var scope;
|
||||
|
|
|
|||
|
|
@ -200,7 +200,6 @@ function ResultCtrl ($scope, $rootScope, $route, $window, $routeParams, $locatio
|
|||
if (paragraph.id === data.paragraphId &&
|
||||
resultIndex === data.index &&
|
||||
(paragraph.status === ParagraphStatus.PENDING || paragraph.status === ParagraphStatus.RUNNING)) {
|
||||
|
||||
if (DefaultDisplayType.TEXT !== $scope.type) {
|
||||
$scope.type = DefaultDisplayType.TEXT;
|
||||
}
|
||||
|
|
@ -539,7 +538,6 @@ function ResultCtrl ($scope, $rootScope, $route, $window, $routeParams, $locatio
|
|||
console.error('Graph drawing error %o', err);
|
||||
}
|
||||
};
|
||||
|
||||
} else if (refresh) {
|
||||
// when graph options or data are changed
|
||||
console.log('Refresh data %o', tableData);
|
||||
|
|
@ -557,7 +555,6 @@ function ResultCtrl ($scope, $rootScope, $route, $window, $routeParams, $locatio
|
|||
builtInViz.instance.render(transformed);
|
||||
builtInViz.instance.renderSetting(visualizationSettingTargetEl);
|
||||
};
|
||||
|
||||
} else {
|
||||
afterLoaded = function (loadedElem) {
|
||||
loadedElem.height(height);
|
||||
|
|
|
|||
|
|
@ -97,7 +97,6 @@ function SearchResultCtrl ($scope, $routeParams, searchService) {
|
|||
var lines = result
|
||||
.split('\n')
|
||||
.map(function (line, row) {
|
||||
|
||||
var match = line.match(/<B>(.+?)<\/B>/);
|
||||
|
||||
// return early if nothing to highlight
|
||||
|
|
@ -149,7 +148,6 @@ function SearchResultCtrl ($scope, $routeParams, searchService) {
|
|||
);
|
||||
|
||||
_editor.getSession().setValue(lines.join('\n'));
|
||||
|
||||
};
|
||||
};
|
||||
}
|
||||
|
|
|
|||
|
|
@ -154,7 +154,6 @@ export class DataWithType {
|
|||
DataWithType.parseStringData(generated, customDisplayType);
|
||||
return result;
|
||||
})
|
||||
|
||||
} else {
|
||||
// if data is a object, parse it to multiples
|
||||
wrapped = new Promise((resolve) => {
|
||||
|
|
|
|||
|
|
@ -266,7 +266,6 @@ export default function heliumService ($http, $sce, baseUrlSrv) {
|
|||
|
||||
// load should be promise
|
||||
this.load = p.then(availableBundles => {
|
||||
|
||||
// evaluate bundles
|
||||
availableBundles.map(b => {
|
||||
eval(b)
|
||||
|
|
@ -284,5 +283,4 @@ export default function heliumService ($http, $sce, baseUrlSrv) {
|
|||
}
|
||||
})
|
||||
})
|
||||
|
||||
}
|
||||
|
|
|
|||
|
|
@ -20,7 +20,6 @@ function LoginCtrl ($scope, $rootScope, $http, $httpParamSerializer, baseUrlSrv,
|
|||
$scope.SigningIn = false;
|
||||
$scope.loginParams = {};
|
||||
$scope.login = function () {
|
||||
|
||||
$scope.SigningIn = true;
|
||||
$http({
|
||||
method: 'POST',
|
||||
|
|
@ -46,13 +45,11 @@ function LoginCtrl ($scope, $rootScope, $http, $httpParamSerializer, baseUrlSrv,
|
|||
$location.$$search = {};
|
||||
$location.path(redirectLocation);
|
||||
}, 100);
|
||||
|
||||
}
|
||||
}, function errorCallback (errorResponse) {
|
||||
$scope.loginParams.errorText = 'The username and password that you entered don\'t match.';
|
||||
$scope.SigningIn = false;
|
||||
});
|
||||
|
||||
};
|
||||
|
||||
var initValues = function () {
|
||||
|
|
|
|||
|
|
@ -1,5 +1,4 @@
|
|||
describe('Directive: ngEnter', function () {
|
||||
|
||||
// load the directive's module
|
||||
beforeEach(angular.mock.module('zeppelinWebApp'));
|
||||
|
||||
|
|
|
|||
|
|
@ -1,5 +1,4 @@
|
|||
describe('Factory: NoteList', function () {
|
||||
|
||||
var noteList;
|
||||
|
||||
beforeEach(function () {
|
||||
|
|
@ -73,5 +72,4 @@ describe('Factory: NoteList', function () {
|
|||
expect(folderList[4].children[0].children[0].id).toBe('000009');
|
||||
expect(folderList[4].children[0].children[0].children).toBeUndefined();
|
||||
});
|
||||
|
||||
});
|
||||
|
|
|
|||
|
|
@ -101,5 +101,4 @@ function NotenameCtrl ($scope, noteListDataFactory, $routeParams, websocketMsgSr
|
|||
// initialize default interpreter with Spark interpreter
|
||||
$scope.note.defaultInterpreter = data.interpreterSettings[0];
|
||||
});
|
||||
|
||||
}
|
||||
|
|
|
|||
|
|
@ -36,5 +36,4 @@ describe('Controller: NotenameCtrl', function () {
|
|||
ctrl.sourceNoteName = 'dsds 2';
|
||||
expect(ctrl.cloneNoteName()).toEqual('dsds 3');
|
||||
});
|
||||
|
||||
});
|
||||
|
|
|
|||
|
|
@ -110,7 +110,6 @@ function NoteImportCtrl ($scope, $timeout, websocketMsgSrv) {
|
|||
$scope.$apply();
|
||||
return;
|
||||
}
|
||||
|
||||
}
|
||||
if (result.paragraphs && result.paragraphs.length > 0) {
|
||||
if (!$scope.note.noteImportName) {
|
||||
|
|
|
|||
|
|
@ -107,7 +107,6 @@ function websocketEvents ($rootScope, $websocket, $location, baseUrlSrv) {
|
|||
message: data.info.toString(),
|
||||
buttons: btn
|
||||
});
|
||||
|
||||
} else if (op === 'PARAGRAPH') {
|
||||
$rootScope.$broadcast('updateParagraph', data);
|
||||
} else if (op === 'RUN_PARAGRAPH_USING_SPELL') {
|
||||
|
|
|
|||
Loading…
Reference in a new issue