From 950ebda207c64936ea91db30f48bf8085b85e668 Mon Sep 17 00:00:00 2001 From: Kavin Date: Mon, 12 Sep 2016 20:25:49 +0530 Subject: [PATCH] Handle FileSystemException on running paragraph and show the relevant error message to the user. --- .../apache/zeppelin/socket/NotebookServer.java | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java index 41de89a984..30b8af0057 100644 --- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java +++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java @@ -22,6 +22,7 @@ import com.google.gson.GsonBuilder; import com.google.gson.reflect.TypeToken; import org.apache.commons.lang.StringUtils; +import org.apache.commons.vfs2.FileSystemException; import org.apache.zeppelin.conf.ZeppelinConfiguration; import org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars; import org.apache.zeppelin.display.AngularObject; @@ -258,12 +259,6 @@ public class NotebookServer extends WebSocketServlet implements } } catch (Exception e) { LOG.error("Can't handle message", e); - try { - conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info", - "Oops! Something went wrong. Please check with your administrator."))); - } catch (IOException e1) { - LOG.error("Can't handle message", e); - } } } @@ -1153,7 +1148,16 @@ public class NotebookServer extends WebSocketServlet implements } AuthenticationInfo subject = new AuthenticationInfo(fromMessage.principal); - note.persist(subject); + + try { + note.persist(subject); + } catch (FileSystemException ex) { + LOG.error("Exception from run", ex); + conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info", + "Oops! There is something wrong with the notebook file system. " + + "Please check the logs for more details."))); + } + try { note.run(paragraphId); } catch (Exception ex) {