From 941794fb7adc11c33b17243dbcb9727e977809db Mon Sep 17 00:00:00 2001 From: Khalid Huseynov Date: Tue, 21 Mar 2017 01:00:19 +0900 Subject: [PATCH] realm token precedence over conf token --- .../repo/zeppelinhub/model/UserTokenContainer.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/model/UserTokenContainer.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/model/UserTokenContainer.java index 3c24decdf3..1bf6edc5f3 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/model/UserTokenContainer.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/model/UserTokenContainer.java @@ -65,17 +65,16 @@ public class UserTokenContainer { } public String getUserToken(String principal) { - // Case of user use token instead of authentication. - //TODO(khalid): in case of hub realm, remote token should take precedence over default - if (!StringUtils.isBlank(defaultToken)) { - return defaultToken; - } String token = userTokens.get(principal); if (StringUtils.isBlank(token)) { String ticket = UserSessionContainer.instance.getSession(principal); try { token = getDefaultZeppelinInstanceToken(ticket); - if (!StringUtils.isBlank(token)) { + if (StringUtils.isBlank(token)) { + if (!StringUtils.isBlank(defaultToken)) { + token = defaultToken; + } + } else { userTokens.putIfAbsent(principal, token); } } catch (IOException e) {