Elgato_dark/zeppelin
1
0
Fork 0
mirror of https://github.com/apache/zeppelin synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: Wrap exceptions in catch stmt

Browse source
This commit is contained in:
1ambda 2016-11-07 14:33:32 +09:00
parent 9268695ea0
commit 8831ca1fd3
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
markdown/src/main/java/org/apache/zeppelin/markdown/PegdownWebSequencelPlugin.java
View file

@ -42,6 +42,8 @@ import java.nio.charset.StandardCharsets;
*/
public class PegdownWebSequencelPlugin extends Parser implements BlockPluginParser {
private static final String WEBSEQ_URL = "http://www.websequencediagrams.com";
public PegdownWebSequencelPlugin() {
super(PegdownParser.OPTIONS,
PegdownParser.PARSING_TIMEOUT_AS_MILLIS,
@ -95,6 +97,8 @@ public class PegdownWebSequencelPlugin extends Parser implements BlockPluginPars
OutputStreamWriter writer = null;
BufferedReader reader = null;
String webSeqUrl = "";
try {
String query = new StringBuilder()
.append("style=")
@ -104,7 +108,7 @@ public class PegdownWebSequencelPlugin extends Parser implements BlockPluginPars
.append("&apiVersion=1")
.toString();
URL url = new URL("http://www.websequencediagrams.com");
URL url = new URL(WEBSEQ_URL);
URLConnection conn = url.openConnection();
conn.setDoOutput(true);
writer = new OutputStreamWriter(conn.getOutputStream(), StandardCharsets.UTF_8);
@ -127,16 +131,16 @@ public class PegdownWebSequencelPlugin extends Parser implements BlockPluginPars
int end = json.indexOf("\"", start);
if (start != -1 && end != -1) {
return "http://www.websequencediagrams.com/" + json.substring(start, end);
webSeqUrl = WEBSEQ_URL + "/" + json.substring(start, end);
}
} catch (IOException e) {
throw new RuntimeException("Failed to get proper response from websequencediagrams.com");
throw new RuntimeException("Failed to get proper response from websequencediagrams.com", e);
} finally {
IOUtils.closeQuietly(writer);
IOUtils.closeQuietly(reader);
}
return "";
return webSeqUrl;
}
@Override

2
markdown/src/main/java/org/apache/zeppelin/markdown/PegdownYumlPlugin.java
View file

@ -108,7 +108,7 @@ public class PegdownYumlPlugin extends Parser implements BlockPluginParser {
try {
encodedBody = URLEncoder.encode(inlined.toString(), "UTF-8");
} catch (UnsupportedEncodingException e) {
new RuntimeException("Failed to encode YUML markdown body");
new RuntimeException("Failed to encode YUML markdown body", e);
}
StringBuilder mergedStyle = new StringBuilder();