mirror of
https://github.com/apache/zeppelin
synced 2026-05-24 09:38:26 +00:00
replace printStackTrace() to LOGGER.error
This commit is contained in:
parent
e4f6f9cd37
commit
7f8b70c689
16 changed files with 54 additions and 30 deletions
|
|
@ -128,7 +128,7 @@ public class LensInterpreter extends Interpreter {
|
|||
s_logger.info("LensInterpreter created");
|
||||
}
|
||||
catch (Exception e) {
|
||||
e.printStackTrace();
|
||||
s_logger.error(e.toString(), e);
|
||||
s_logger.error("unable to create lens interpreter", e);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -17,6 +17,9 @@ package org.apache.zeppelin.lens;
|
|||
|
||||
import java.util.Map;
|
||||
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
import org.springframework.beans.BeansException;
|
||||
import org.springframework.beans.factory.BeanFactoryUtils;
|
||||
import org.springframework.beans.factory.InitializingBean;
|
||||
|
|
@ -56,6 +59,8 @@ public class LensJLineShellComponent extends JLineShell
|
|||
private ExecutionStrategy executionStrategy = new LensSimpleExecutionStrategy();
|
||||
private SimpleParser parser = new SimpleParser();
|
||||
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(LensJLineShellComponent.class);
|
||||
|
||||
public SimpleParser getSimpleParser() {
|
||||
return parser;
|
||||
}
|
||||
|
|
@ -123,7 +128,7 @@ public class LensJLineShellComponent extends JLineShell
|
|||
try {
|
||||
shellThread.join();
|
||||
} catch (InterruptedException e) {
|
||||
e.printStackTrace();
|
||||
LOGGER.error(e.toString(), e);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -35,6 +35,7 @@
|
|||
{
|
||||
"title": "Load data into table",
|
||||
"text": "import org.apache.commons.io.IOUtils\nimport java.net.URL\nimport java.nio.charset.Charset\n\n// Zeppelin creates and injects sc (SparkContext) and sqlContext (HiveContext or SqlContext)\n// So you don\u0027t need create them manually\n\n// load bank data\nval bankText \u003d sc.parallelize(\n IOUtils.toString(\n new URL(\"https://s3.amazonaws.com/apache-zeppelin/tutorial/bank/bank.csv\"),\n Charset.forName(\"utf8\")).split(\"\\n\"))\n\ncase class Bank(age: Integer, job: String, marital: String, education: String, balance: Integer)\n\nval bank \u003d bankText.map(s \u003d\u003e s.split(\";\")).filter(s \u003d\u003e s(0) !\u003d \"\\\"age\\\"\").map(\n s \u003d\u003e Bank(s(0).toInt, \n s(1).replaceAll(\"\\\"\", \"\"),\n s(2).replaceAll(\"\\\"\", \"\"),\n s(3).replaceAll(\"\\\"\", \"\"),\n s(5).replaceAll(\"\\\"\", \"\").toInt\n )\n).toDF()\nbank.registerTempTable(\"bank\")",
|
||||
"dateUpdated": "Jan 5, 2016 11:06:56 AM",
|
||||
"config": {
|
||||
"colWidth": 12.0,
|
||||
"graph": {
|
||||
|
|
@ -46,7 +47,9 @@
|
|||
"groups": [],
|
||||
"scatter": {}
|
||||
},
|
||||
"title": true
|
||||
"title": true,
|
||||
"enabled": true,
|
||||
"editorMode": "ace/mode/scala"
|
||||
},
|
||||
"settings": {
|
||||
"params": {},
|
||||
|
|
@ -57,11 +60,11 @@
|
|||
"result": {
|
||||
"code": "SUCCESS",
|
||||
"type": "TEXT",
|
||||
"msg": "import org.apache.commons.io.IOUtils\nimport java.net.URL\nimport java.nio.charset.Charset\nbankText: org.apache.spark.rdd.RDD[String] \u003d ParallelCollectionRDD[32] at parallelize at \u003cconsole\u003e:65\ndefined class Bank\nbank: org.apache.spark.sql.DataFrame \u003d [age: int, job: string, marital: string, education: string, balance: int]\n"
|
||||
"msg": "import org.apache.commons.io.IOUtils\nimport java.net.URL\nimport java.nio.charset.Charset\nbankText: org.apache.spark.rdd.RDD[String] \u003d ParallelCollectionRDD[0] at parallelize at \u003cconsole\u003e:31\ndefined class Bank\nbank: org.apache.spark.sql.DataFrame \u003d [age: int, job: string, marital: string, education: string, balance: int]\n"
|
||||
},
|
||||
"dateCreated": "Feb 10, 2015 1:52:59 AM",
|
||||
"dateStarted": "Jul 3, 2015 1:43:40 PM",
|
||||
"dateFinished": "Jul 3, 2015 1:43:45 PM",
|
||||
"dateStarted": "Jan 5, 2016 11:06:56 AM",
|
||||
"dateFinished": "Jan 5, 2016 11:07:18 AM",
|
||||
"status": "FINISHED",
|
||||
"progressUpdateIntervalMs": 500
|
||||
},
|
||||
|
|
@ -333,7 +336,21 @@
|
|||
],
|
||||
"name": "Zeppelin Tutorial",
|
||||
"id": "2A94M5J1Z",
|
||||
"angularObjects": {},
|
||||
"angularObjects": {
|
||||
"2B5JSF7WG": [],
|
||||
"2B55RMYMK": [],
|
||||
"2B6U8CT2P": [],
|
||||
"2B56U2328": [],
|
||||
"2B5MYQNTP": [],
|
||||
"2B6TV29RN": [],
|
||||
"2B5DCJ3RA": [],
|
||||
"2B4JMBUGM": [],
|
||||
"2B5TJF313": [],
|
||||
"2B6RZQGH9": [],
|
||||
"2B686MPNX": [],
|
||||
"2B5ANRH89": [],
|
||||
"2B633ZKUD": []
|
||||
},
|
||||
"config": {
|
||||
"looknfeel": "default"
|
||||
},
|
||||
|
|
|
|||
|
|
@ -82,7 +82,7 @@ import scala.tools.nsc.settings.MutableSettings.PathSetting;
|
|||
*
|
||||
*/
|
||||
public class SparkInterpreter extends Interpreter {
|
||||
Logger logger = LoggerFactory.getLogger(SparkInterpreter.class);
|
||||
public static Logger logger = LoggerFactory.getLogger(SparkInterpreter.class);
|
||||
|
||||
static {
|
||||
Interpreter.register(
|
||||
|
|
@ -186,7 +186,7 @@ public class SparkInterpreter extends Interpreter {
|
|||
}
|
||||
} catch (NoSuchMethodException | SecurityException | IllegalAccessException
|
||||
| IllegalArgumentException | InvocationTargetException e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
return null;
|
||||
}
|
||||
return pl;
|
||||
|
|
|
|||
|
|
@ -170,7 +170,7 @@ public class RemoteInterpreterServer
|
|||
} catch (ClassNotFoundException | NoSuchMethodException | SecurityException
|
||||
| InstantiationException | IllegalAccessException
|
||||
| IllegalArgumentException | InvocationTargetException e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
throw new TException(e);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -32,7 +32,7 @@ import org.slf4j.LoggerFactory;
|
|||
* TODO(moon) : add description.
|
||||
*/
|
||||
public class SchedulerFactory implements SchedulerListener {
|
||||
private final Logger logger = LoggerFactory.getLogger(SchedulerFactory.class);
|
||||
private static final Logger logger = LoggerFactory.getLogger(SchedulerFactory.class);
|
||||
ExecutorService executor;
|
||||
Map<String, Scheduler> schedulers = new LinkedHashMap<String, Scheduler>();
|
||||
|
||||
|
|
@ -46,7 +46,7 @@ public class SchedulerFactory implements SchedulerListener {
|
|||
try {
|
||||
singleton = new SchedulerFactory();
|
||||
} catch (Exception e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -19,12 +19,12 @@ package org.apache.zeppelin.server;
|
|||
|
||||
import org.apache.zeppelin.conf.ZeppelinConfiguration;
|
||||
import org.apache.zeppelin.utils.SecurityUtils;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
import java.io.IOException;
|
||||
import java.net.URI;
|
||||
import java.net.URISyntaxException;
|
||||
import java.text.DateFormat;
|
||||
import java.util.Arrays;
|
||||
import java.util.Date;
|
||||
import java.util.Locale;
|
||||
|
||||
|
|
@ -43,6 +43,8 @@ import javax.servlet.http.HttpServletResponse;
|
|||
*/
|
||||
public class CorsFilter implements Filter {
|
||||
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(CorsFilter.class);
|
||||
|
||||
@Override
|
||||
public void doFilter(ServletRequest request, ServletResponse response, FilterChain filterChain)
|
||||
throws IOException, ServletException {
|
||||
|
|
@ -54,7 +56,7 @@ public class CorsFilter implements Filter {
|
|||
origin = sourceHost;
|
||||
}
|
||||
} catch (URISyntaxException e) {
|
||||
e.printStackTrace();
|
||||
LOGGER.error("Exception in WebDriverManager while getWebDriver ", e);
|
||||
}
|
||||
|
||||
if (((HttpServletRequest) request).getMethod().equals("OPTIONS")) {
|
||||
|
|
|
|||
|
|
@ -71,9 +71,9 @@ public class NotebookServer extends WebSocketServlet implements
|
|||
try {
|
||||
return SecurityUtils.isValidOrigin(origin, ZeppelinConfiguration.create());
|
||||
} catch (UnknownHostException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error(e.toString(), e);
|
||||
} catch (URISyntaxException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error(e.toString(), e);
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
|
@ -771,7 +771,7 @@ public class NotebookServer extends WebSocketServlet implements
|
|||
try {
|
||||
note.persist();
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error(e.toString(), e);
|
||||
}
|
||||
}
|
||||
notebookServer.broadcastNote(note);
|
||||
|
|
|
|||
|
|
@ -178,7 +178,7 @@ public class WebDriverManager {
|
|||
String versionString = (String) CommandExecutor.executeCommandLocalHost(firefoxVersionCmd, false, ProcessData.Types_Of_Data.OUTPUT);
|
||||
return Integer.valueOf(versionString.replaceAll("Mozilla Firefox", "").trim().substring(0, 2));
|
||||
} catch (Exception e) {
|
||||
e.printStackTrace();
|
||||
LOG.error("Exception in WebDriverManager while getWebDriver ", e);
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -33,7 +33,7 @@ public class ZeppelinITUtils {
|
|||
try {
|
||||
Thread.sleep(millis);
|
||||
} catch (InterruptedException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error("Exception in WebDriverManager while getWebDriver ", e);
|
||||
}
|
||||
if (logOutput) {
|
||||
LOG.info("Finished.");
|
||||
|
|
|
|||
|
|
@ -86,7 +86,7 @@ public abstract class AbstractTestRestApi {
|
|||
try {
|
||||
ZeppelinServer.main(new String[] {""});
|
||||
} catch (Exception e) {
|
||||
e.printStackTrace();
|
||||
LOG.error("Exception in WebDriverManager while getWebDriver ", e);
|
||||
throw new RuntimeException(e);
|
||||
}
|
||||
}
|
||||
|
|
@ -156,7 +156,7 @@ public abstract class AbstractTestRestApi {
|
|||
try {
|
||||
return InetAddress.getLocalHost().getHostName();
|
||||
} catch (UnknownHostException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error("Exception in WebDriverManager while getWebDriver ", e);
|
||||
return "localhost";
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -60,7 +60,7 @@ public class ZeppelinSparkClusterTest extends AbstractTestRestApi {
|
|||
try {
|
||||
Thread.sleep(100);
|
||||
} catch (InterruptedException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error("Exception in WebDriverManager while getWebDriver ", e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -58,7 +58,7 @@ import org.slf4j.LoggerFactory;
|
|||
* Collection of Notes.
|
||||
*/
|
||||
public class Notebook {
|
||||
Logger logger = LoggerFactory.getLogger(Notebook.class);
|
||||
static Logger logger = LoggerFactory.getLogger(Notebook.class);
|
||||
|
||||
@SuppressWarnings("unused") @Deprecated //TODO(bzz): remove unused
|
||||
private SchedulerFactory schedulerFactory;
|
||||
|
|
@ -237,7 +237,7 @@ public class Notebook {
|
|||
try {
|
||||
note.unpersist();
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -420,7 +420,7 @@ public class Notebook {
|
|||
try {
|
||||
Thread.sleep(1000);
|
||||
} catch (InterruptedException e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -428,7 +428,7 @@ public class Notebook {
|
|||
try {
|
||||
releaseResource = (boolean) note.getConfig().get("releaseresource");
|
||||
} catch (java.lang.ClassCastException e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
}
|
||||
if (releaseResource) {
|
||||
for (InterpreterSetting setting : note.getNoteReplLoader().getInterpreterSettings()) {
|
||||
|
|
|
|||
|
|
@ -130,7 +130,7 @@ public class NotebookTest implements JobListenerFactory{
|
|||
try {
|
||||
FileUtils.copyDirectory(srcDir, destDir);
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace();
|
||||
logger.error(e.toString(), e);
|
||||
}
|
||||
|
||||
// doesn't have copied notebook in memory before reloading
|
||||
|
|
|
|||
|
|
@ -199,7 +199,7 @@ public class NotebookRepoSyncTest implements JobListenerFactory {
|
|||
try {
|
||||
FileUtils.copyDirectory(srcDir, destDir);
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error(e.toString(), e);
|
||||
}
|
||||
assertEquals(0, notebookRepoSync.list(0).size());
|
||||
assertEquals(1, notebookRepoSync.list(1).size());
|
||||
|
|
|
|||
|
|
@ -134,7 +134,7 @@ public class VFSNotebookRepoTest implements JobListenerFactory {
|
|||
try {
|
||||
notebookRepo.save(note);
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace();
|
||||
LOG.error(e.toString(), e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue