Elgato_dark/zeppelin
1
0
Fork 0
mirror of https://github.com/apache/zeppelin synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: DON'T serialize version field in HeliumPackage

Browse source
This commit is contained in:
1ambda 2017-02-21 16:29:01 +09:00
parent e599ab92da
commit 696f7f8ae4
3 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
zeppelin-interpreter/src/main/java/org/apache/zeppelin/helium/HeliumPackage.java
View file

@ -27,7 +27,6 @@ import java.util.Map;
public class HeliumPackage {
private HeliumType type;
private String name; // user friendly name of this application
private String version;
private String description; // description
private String artifact; // artifact name e.g) groupId:artifactId:versionId
private String className; // entry point
@ -85,10 +84,6 @@ public class HeliumPackage {
return name;
}
public String getVersion() {
return version;
}
public String getDescription() {
return description;
}

3
zeppelin-web/src/components/helium/helium-conf.js
View file

@ -50,9 +50,6 @@ export function createAllPackageConfigs(defaultPackages, persistedConfs) {
const spec = pkgSearchResult.pkg.config;
if (!spec) { continue; }
const version = pkgSearchResult.pkg.version;
if (!version) { continue; }
const artifact = pkgSearchResult.pkg.artifact;
if (!artifact) { continue; }

5
zeppelin-web/src/components/helium/helium.service.js
View file

@ -148,7 +148,7 @@ export default function heliumService($http, $sce, baseUrlSrv) {
};
/**
* @returns {Promise<Object>} which including {name, Array<package info for version>}
* @returns {Promise<Object>} which including {name, Array<package info for artifact>}
*/
this.getAllPackageInfo = function() {
return $http.get(`${baseUrlSrv.getRestApiBase()}/helium/package`)
@ -207,11 +207,10 @@ export default function heliumService($http, $sce, baseUrlSrv) {
*/
this.getSinglePackageConfigs = function(pkg) {
const pkgName = pkg.name;
const pkgVersion = pkg.version;
// in case of local package, it will include `/`
const pkgArtifact = encodeURIComponent(pkg.artifact);
if (!pkgName || !pkgVersion || !pkgArtifact) {
if (!pkgName || !pkgArtifact) {
console.error('Failed to fetch config for\n', pkg);
return Promise.resolve([]);
}