Elgato_dark/zeppelin
1
0
Fork 0
mirror of https://github.com/apache/zeppelin synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: space-infix-ops

Browse source 
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (5/0)
  ✖   70:54  Infix operators must be spaced  space-infix-ops
  ✖   74:54  Infix operators must be spaced  space-infix-ops
  ✖  229:52  Infix operators must be spaced  space-infix-ops
  ✖  230:53  Infix operators must be spaced  space-infix-ops
  ✖  231:27  Infix operators must be spaced  space-infix-ops

/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium.service.js (1/0)
  ✖  108:33  Infix operators must be spaced  space-infix-ops
```
This commit is contained in:
1ambda 2017-04-15 01:19:16 +09:00
parent eac6b438c2
commit 5d19c6f5f2
4 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
zeppelin-web/.eslintrc
View file

@ -34,7 +34,6 @@
"prefer-rest-params": 0,
"no-useless-constructor": 0,
"no-unused-expressions": 0,
"space-infix-ops": 0,
"prefer-spread": 0,
"no-redeclare": 0,
"standard/object-curly-even-spacing": 0,

4
zeppelin-web/src/app/helium/helium.controller.js
View file

@ -187,7 +187,7 @@ export default function HeliumCtrl ($scope, $rootScope, $sce,
$scope.enable = function (name, artifact, type, groupId, description) {
var license = getLicense(name, artifact);
var mavenArtifactInfoToHTML = groupId +':'+ artifact.split('@')[0] + ':' + artifact.split('@')[1];
var mavenArtifactInfoToHTML = groupId + ':' + artifact.split('@')[0] + ':' + artifact.split('@')[1];
var zeppelinVersion = $rootScope.zeppelinVersion;
var url = 'https://zeppelin.apache.org/docs/' + zeppelinVersion + '/manual/interpreterinstallation.html';
@ -201,7 +201,7 @@ export default function HeliumCtrl ($scope, $rootScope, $sce,
' and all of its transitive dependencies into interpreter/interpreter-name directory.<p>' +
'<div class="highlight"><pre><code class="text language-text" data-lang="text" style="font-size: 11.5px">' +
'./bin/install-interpreter.sh --name "interpreter-name" --artifact ' +
mavenArtifactInfoToHTML +' </code></pre>' +
mavenArtifactInfoToHTML + ' </code></pre>' +
'<p>After restart Zeppelin, create interpreter setting and bind it with your note. ' +
'For more detailed information, see <a target="_blank" href=' +
url + '>Interpreter Installation.</a></p>'

10
zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js
View file

@ -67,11 +67,11 @@ export default class ScatterchartVisualization extends Nvd3ChartVisualization {
var self = this;
chart.xAxis.tickFormat(function (d) { // TODO remove round after bump to nvd3 > 1.8.5
return self.xAxisTickFormat(Math.round(d * 1e3)/1e3, self.xLabels);
return self.xAxisTickFormat(Math.round(d * 1e3) / 1e3, self.xLabels);
});
chart.yAxis.tickFormat(function (d) { // TODO remove round after bump to nvd3 > 1.8.5
return self.yAxisTickFormat(Math.round(d * 1e3)/1e3, self.yLabels);
return self.yAxisTickFormat(Math.round(d * 1e3) / 1e3, self.yLabels);
});
chart.showDistX(true).showDistY(true);
@ -226,9 +226,9 @@ export default class ScatterchartVisualization extends Nvd3ChartVisualization {
});
for (var i = 0; i < d3gvalues.length - 1;) {
if ((Math.abs(d3gvalues[i]['x'] - d3gvalues[i+1]['x']) < epsilon) &&
(Math.abs(d3gvalues[i]['y'] - d3gvalues[i+1]['y']) < epsilon)) {
d3gvalues.splice(i+1, 1);
if ((Math.abs(d3gvalues[i]['x'] - d3gvalues[i + 1]['x']) < epsilon) &&
(Math.abs(d3gvalues[i]['y'] - d3gvalues[i + 1]['y']) < epsilon)) {
d3gvalues.splice(i + 1, 1);
} else {
i++;
}

2
zeppelin-web/src/components/helium/helium.service.js
View file

@ -105,7 +105,7 @@ export default function heliumService ($http, $sce, baseUrlSrv) {
const pkgName = pkg.name;
const filtered = createPersistableConfig(defaultPackageConfig);
if (!pkgName || !pkgArtifact|| !filtered) {
if (!pkgName || !pkgArtifact || !filtered) {
console.error(
`Can't save config for helium package '${pkgArtifact}'`, filtered);
return;