diff --git a/testing/startSparkCluster.sh b/testing/startSparkCluster.sh index e47edc1139..4b1f9d149b 100755 --- a/testing/startSparkCluster.sh +++ b/testing/startSparkCluster.sh @@ -17,7 +17,7 @@ # -if [ $# -ne 2 ]; then +if [[ "$#" -ne 2 ]]; then echo "usage) $0 [spark version] [hadoop version]" echo " eg) $0 1.3.1 2.6" exit 1 @@ -26,10 +26,10 @@ fi SPARK_VERSION="${1}" HADOOP_VERSION="${2}" -echo ${SPARK_VERSION} | grep "^1.[123].[0-9]" > /dev/null -if [ $? -eq 0 ]; then +echo "${SPARK_VERSION}" | grep "^1.[123].[0-9]" > /dev/null +if [[ "$?" -eq 0 ]]; then echo "${SPARK_VERSION}" | grep "^1.[12].[0-9]" > /dev/null - if [ $? -eq 0 ]; then + if [[ "$?" -eq 0 ]]; then SPARK_VER_RANGE="<=1.2" else SPARK_VER_RANGE="<=1.3" @@ -38,17 +38,19 @@ else SPARK_VER_RANGE=">1.3" fi - set -xe -FWDIR=$(dirname "${BASH_SOURCE-$0}") +FWDIR="$(dirname "${BASH_SOURCE-$0}")" ZEPPELIN_HOME="$(cd "${FWDIR}/.."; pwd)" -export SPARK_HOME=${ZEPPELIN_HOME}/spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION} + +SPARK_CACHE=".spark-dist" +SPARK_ARCHIVE="spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION}" +export SPARK_HOME="${ZEPPELIN_HOME}/${SPARK_CACHE}/${SPARK_ARCHIVE}" echo "SPARK_HOME is ${SPARK_HOME}" # create PID dir. test case detect pid file so they can select active spark home dir for test -mkdir -p ${SPARK_HOME}/run -export SPARK_PID_DIR=${SPARK_HOME}/run +export SPARK_PID_DIR="${SPARK_HOME}/run" +mkdir -p "${SPARK_PID_DIR}" # start export SPARK_MASTER_PORT=7071 diff --git a/testing/stopSparkCluster.sh b/testing/stopSparkCluster.sh index 1bf8eac32b..d563e705fc 100755 --- a/testing/stopSparkCluster.sh +++ b/testing/stopSparkCluster.sh @@ -16,7 +16,7 @@ # limitations under the License. # -if [ $# -ne 2 ]; then +if [[ "$#" -ne 2 ]]; then echo "usage) $0 [spark version] [hadoop version]" echo " eg) $0 1.3.1 2.6" exit 1 @@ -27,9 +27,13 @@ HADOOP_VERSION="${2}" set -xe -FWDIR=$(dirname "${BASH_SOURCE-$0}") +FWDIR="$(dirname "${BASH_SOURCE-$0}")" ZEPPELIN_HOME="$(cd "${FWDIR}/.."; pwd)" -export SPARK_HOME=${ZEPPELIN_HOME}/spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION} + +SPARK_CACHE=".spark-dist" +SPARK_ARCHIVE="spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION}" +export SPARK_HOME="${ZEPPELIN_HOME}/${SPARK_CACHE}/${SPARK_ARCHIVE}" +echo "SPARK_HOME is ${SPARK_HOME}" # set create PID dir export SPARK_PID_DIR=${SPARK_HOME}/run