diff --git a/scalding/pom.xml b/scalding/pom.xml index 6ba01b1611..3d76e0d604 100644 --- a/scalding/pom.xml +++ b/scalding/pom.xml @@ -60,16 +60,6 @@ commons-exec 1.3 - - - org.slf4j - slf4j-api - - - - org.slf4j - slf4j-log4j12 - junit diff --git a/scalding/src/main/java/org/apache/zeppelin/scalding/ScaldingInterpreter.java b/scalding/src/main/java/org/apache/zeppelin/scalding/ScaldingInterpreter.java index 2a4c744e10..40f7ffd727 100644 --- a/scalding/src/main/java/org/apache/zeppelin/scalding/ScaldingInterpreter.java +++ b/scalding/src/main/java/org/apache/zeppelin/scalding/ScaldingInterpreter.java @@ -17,16 +17,16 @@ package org.apache.zeppelin.scalding; -import java.io.File; -import java.util.Properties; -import java.util.List; -import java.util.Map; -import java.util.LinkedList; -import java.net.URL; -import java.net.URLClassLoader; import java.io.ByteArrayOutputStream; +import java.io.File; import java.io.PrintStream; import java.io.PrintWriter; +import java.util.Properties; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.net.URL; +import java.net.URLClassLoader; import org.apache.zeppelin.interpreter.Interpreter; import org.apache.zeppelin.interpreter.InterpreterContext; @@ -34,11 +34,10 @@ import org.apache.zeppelin.interpreter.InterpreterResult; import org.apache.zeppelin.interpreter.InterpreterResult.Code; import org.apache.zeppelin.scheduler.Scheduler; import org.apache.zeppelin.scheduler.SchedulerFactory; + import org.slf4j.Logger; import org.slf4j.LoggerFactory; -//import com.twitter.scalding.ScaldingILoop; - import scala.Console; import scala.Some; import scala.None; @@ -259,7 +258,9 @@ public class ScaldingInterpreter extends Interpreter { } @Override - public void cancel(InterpreterContext context) {} + public void cancel(InterpreterContext context) { + // not implemented + } @Override public FormType getFormType() { @@ -268,6 +269,7 @@ public class ScaldingInterpreter extends Interpreter { @Override public int getProgress(InterpreterContext context) { + // not implemented - return 0 return 0; } diff --git a/scalding/src/main/scala/org/apache/zeppelin/scalding/ScaldingILoop.scala b/scalding/src/main/scala/org/apache/zeppelin/scalding/ScaldingILoop.scala index 434e033ad7..bd23c4937f 100644 --- a/scalding/src/main/scala/org/apache/zeppelin/scalding/ScaldingILoop.scala +++ b/scalding/src/main/scala/org/apache/zeppelin/scalding/ScaldingILoop.scala @@ -14,16 +14,14 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - + package org.apache.zeppelin.scalding; -import java.io.File +import java.io.{BufferedReader, File, FileReader} -import scala.tools.nsc.interpreter.IR import scala.tools.nsc.GenericRunnerSettings -import scala.tools.nsc.interpreter.{JPrintWriter, ILoop} +import scala.tools.nsc.interpreter.{ILoop, IR, JPrintWriter} -import java.io.{BufferedReader, FileReader} /** * A class providing Scalding specific commands for inclusion in the Scalding REPL.