mirror of
https://github.com/apache/zeppelin
synced 2026-05-24 09:38:26 +00:00
Adopted new style
This commit is contained in:
parent
f95418f7c1
commit
26788c5f82
7 changed files with 246 additions and 246 deletions
|
|
@ -354,41 +354,41 @@ public class JDBCInterpreter extends Interpreter {
|
|||
|
||||
JDBCSecurityImpl.createSecureConfiguration(property, authType);
|
||||
switch (authType) {
|
||||
case KERBEROS:
|
||||
if (user == null || "false".equalsIgnoreCase(
|
||||
property.getProperty("zeppelin.jdbc.auth.kerberos.proxy.enable"))) {
|
||||
case KERBEROS:
|
||||
if (user == null || "false".equalsIgnoreCase(
|
||||
property.getProperty("zeppelin.jdbc.auth.kerberos.proxy.enable"))) {
|
||||
connection = getConnectionFromPool(connectionUrl, user, propertyKey, properties);
|
||||
} else {
|
||||
if (basePropretiesMap.get(propertyKey).containsKey("proxy.user.property")) {
|
||||
connection = getConnectionFromPool(connectionUrl, user, propertyKey, properties);
|
||||
} else {
|
||||
if (basePropretiesMap.get(propertyKey).containsKey("proxy.user.property")) {
|
||||
connection = getConnectionFromPool(connectionUrl, user, propertyKey, properties);
|
||||
} else {
|
||||
UserGroupInformation ugi = null;
|
||||
try {
|
||||
ugi = UserGroupInformation.createProxyUser(
|
||||
user, UserGroupInformation.getCurrentUser());
|
||||
} catch (Exception e) {
|
||||
logger.error("Error in getCurrentUser", e);
|
||||
throw new InterpreterException("Error in getCurrentUser", e);
|
||||
}
|
||||
UserGroupInformation ugi = null;
|
||||
try {
|
||||
ugi = UserGroupInformation.createProxyUser(
|
||||
user, UserGroupInformation.getCurrentUser());
|
||||
} catch (Exception e) {
|
||||
logger.error("Error in getCurrentUser", e);
|
||||
throw new InterpreterException("Error in getCurrentUser", e);
|
||||
}
|
||||
|
||||
final String poolKey = propertyKey;
|
||||
try {
|
||||
connection = ugi.doAs(new PrivilegedExceptionAction<Connection>() {
|
||||
@Override
|
||||
public Connection run() throws Exception {
|
||||
return getConnectionFromPool(connectionUrl, user, poolKey, properties);
|
||||
}
|
||||
});
|
||||
} catch (Exception e) {
|
||||
logger.error("Error in doAs", e);
|
||||
throw new InterpreterException("Error in doAs", e);
|
||||
}
|
||||
final String poolKey = propertyKey;
|
||||
try {
|
||||
connection = ugi.doAs(new PrivilegedExceptionAction<Connection>() {
|
||||
@Override
|
||||
public Connection run() throws Exception {
|
||||
return getConnectionFromPool(connectionUrl, user, poolKey, properties);
|
||||
}
|
||||
});
|
||||
} catch (Exception e) {
|
||||
logger.error("Error in doAs", e);
|
||||
throw new InterpreterException("Error in doAs", e);
|
||||
}
|
||||
}
|
||||
break;
|
||||
}
|
||||
break;
|
||||
|
||||
default:
|
||||
connection = getConnectionFromPool(connectionUrl, user, propertyKey, properties);
|
||||
default:
|
||||
connection = getConnectionFromPool(connectionUrl, user, propertyKey, properties);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -41,20 +41,20 @@ public class JDBCSecurityImpl {
|
|||
public static void createSecureConfiguration(Properties properties,
|
||||
AuthenticationMethod authType) {
|
||||
switch (authType) {
|
||||
case KERBEROS:
|
||||
Configuration conf = new
|
||||
org.apache.hadoop.conf.Configuration();
|
||||
conf.set("hadoop.security.authentication", KERBEROS.toString());
|
||||
UserGroupInformation.setConfiguration(conf);
|
||||
try {
|
||||
UserGroupInformation.loginUserFromKeytab(
|
||||
properties.getProperty("zeppelin.jdbc.principal"),
|
||||
properties.getProperty("zeppelin.jdbc.keytab.location")
|
||||
);
|
||||
} catch (IOException e) {
|
||||
LOGGER.error("Failed to get either keytab location or principal name in the " +
|
||||
"interpreter", e);
|
||||
}
|
||||
case KERBEROS:
|
||||
Configuration conf = new
|
||||
org.apache.hadoop.conf.Configuration();
|
||||
conf.set("hadoop.security.authentication", KERBEROS.toString());
|
||||
UserGroupInformation.setConfiguration(conf);
|
||||
try {
|
||||
UserGroupInformation.loginUserFromKeytab(
|
||||
properties.getProperty("zeppelin.jdbc.principal"),
|
||||
properties.getProperty("zeppelin.jdbc.keytab.location")
|
||||
);
|
||||
} catch (IOException e) {
|
||||
LOGGER.error("Failed to get either keytab location or principal name in the " +
|
||||
"interpreter", e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -39,21 +39,21 @@ public class ShellSecurityImpl {
|
|||
.trim().toUpperCase();
|
||||
|
||||
switch (authType) {
|
||||
case "KERBEROS":
|
||||
CommandLine cmdLine = CommandLine.parse(shell);
|
||||
cmdLine.addArgument("-c", false);
|
||||
String kinitCommand = String.format("kinit -k -t %s %s",
|
||||
case "KERBEROS":
|
||||
CommandLine cmdLine = CommandLine.parse(shell);
|
||||
cmdLine.addArgument("-c", false);
|
||||
String kinitCommand = String.format("kinit -k -t %s %s",
|
||||
properties.getProperty("zeppelin.shell.keytab.location"),
|
||||
properties.getProperty("zeppelin.shell.principal"));
|
||||
cmdLine.addArgument(kinitCommand, false);
|
||||
DefaultExecutor executor = new DefaultExecutor();
|
||||
cmdLine.addArgument(kinitCommand, false);
|
||||
DefaultExecutor executor = new DefaultExecutor();
|
||||
|
||||
try {
|
||||
int exitVal = executor.execute(cmdLine);
|
||||
} catch (Exception e) {
|
||||
LOGGER.error("Unable to run kinit for zeppelin user " + kinitCommand, e);
|
||||
throw new InterpreterException(e);
|
||||
}
|
||||
try {
|
||||
int exitVal = executor.execute(cmdLine);
|
||||
} catch (Exception e) {
|
||||
LOGGER.error("Unable to run kinit for zeppelin user " + kinitCommand, e);
|
||||
throw new InterpreterException(e);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -236,148 +236,148 @@ public class NotebookServer extends WebSocketServlet
|
|||
|
||||
/** Lets be elegant here */
|
||||
switch (messagereceived.op) {
|
||||
case LIST_NOTES:
|
||||
unicastNoteList(conn, subject, userAndRoles);
|
||||
break;
|
||||
case RELOAD_NOTES_FROM_REPO:
|
||||
broadcastReloadedNoteList(subject, userAndRoles);
|
||||
break;
|
||||
case GET_HOME_NOTE:
|
||||
sendHomeNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case GET_NOTE:
|
||||
sendNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NEW_NOTE:
|
||||
createNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case DEL_NOTE:
|
||||
removeNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case REMOVE_FOLDER:
|
||||
removeFolder(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case MOVE_NOTE_TO_TRASH:
|
||||
moveNoteToTrash(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case MOVE_FOLDER_TO_TRASH:
|
||||
moveFolderToTrash(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case EMPTY_TRASH:
|
||||
emptyTrash(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RESTORE_FOLDER:
|
||||
restoreFolder(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RESTORE_NOTE:
|
||||
restoreNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RESTORE_ALL:
|
||||
restoreAll(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case CLONE_NOTE:
|
||||
cloneNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case IMPORT_NOTE:
|
||||
importNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case COMMIT_PARAGRAPH:
|
||||
updateParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RUN_PARAGRAPH:
|
||||
runParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_EXECUTED_BY_SPELL:
|
||||
broadcastSpellExecution(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RUN_ALL_PARAGRAPHS:
|
||||
runAllParagraphs(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case CANCEL_PARAGRAPH:
|
||||
cancelParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case MOVE_PARAGRAPH:
|
||||
moveParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case INSERT_PARAGRAPH:
|
||||
insertParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case COPY_PARAGRAPH:
|
||||
copyParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_REMOVE:
|
||||
removeParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_CLEAR_OUTPUT:
|
||||
clearParagraphOutput(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_CLEAR_ALL_OUTPUT:
|
||||
clearAllParagraphOutput(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NOTE_UPDATE:
|
||||
updateNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NOTE_RENAME:
|
||||
renameNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case FOLDER_RENAME:
|
||||
renameFolder(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case UPDATE_PERSONALIZED_MODE:
|
||||
updatePersonalizedMode(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case COMPLETION:
|
||||
completion(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PING:
|
||||
break; //do nothing
|
||||
case ANGULAR_OBJECT_UPDATED:
|
||||
angularObjectUpdated(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case ANGULAR_OBJECT_CLIENT_BIND:
|
||||
angularObjectClientBind(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case ANGULAR_OBJECT_CLIENT_UNBIND:
|
||||
angularObjectClientUnbind(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case LIST_CONFIGURATIONS:
|
||||
sendAllConfigurations(conn, userAndRoles, notebook);
|
||||
break;
|
||||
case CHECKPOINT_NOTE:
|
||||
checkpointNote(conn, notebook, messagereceived);
|
||||
break;
|
||||
case LIST_REVISION_HISTORY:
|
||||
listRevisionHistory(conn, notebook, messagereceived);
|
||||
break;
|
||||
case SET_NOTE_REVISION:
|
||||
setNoteRevision(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NOTE_REVISION:
|
||||
getNoteByRevision(conn, notebook, messagereceived);
|
||||
break;
|
||||
case LIST_NOTE_JOBS:
|
||||
unicastNoteJobInfo(conn, messagereceived);
|
||||
break;
|
||||
case UNSUBSCRIBE_UPDATE_NOTE_JOBS:
|
||||
unsubscribeNoteJobInfo(conn);
|
||||
break;
|
||||
case GET_INTERPRETER_BINDINGS:
|
||||
getInterpreterBindings(conn, messagereceived);
|
||||
break;
|
||||
case SAVE_INTERPRETER_BINDINGS:
|
||||
saveInterpreterBindings(conn, messagereceived);
|
||||
break;
|
||||
case EDITOR_SETTING:
|
||||
getEditorSetting(conn, messagereceived);
|
||||
break;
|
||||
case GET_INTERPRETER_SETTINGS:
|
||||
getInterpreterSettings(conn, subject);
|
||||
break;
|
||||
case WATCHER:
|
||||
switchConnectionToWatcher(conn, messagereceived);
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
case LIST_NOTES:
|
||||
unicastNoteList(conn, subject, userAndRoles);
|
||||
break;
|
||||
case RELOAD_NOTES_FROM_REPO:
|
||||
broadcastReloadedNoteList(subject, userAndRoles);
|
||||
break;
|
||||
case GET_HOME_NOTE:
|
||||
sendHomeNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case GET_NOTE:
|
||||
sendNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NEW_NOTE:
|
||||
createNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case DEL_NOTE:
|
||||
removeNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case REMOVE_FOLDER:
|
||||
removeFolder(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case MOVE_NOTE_TO_TRASH:
|
||||
moveNoteToTrash(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case MOVE_FOLDER_TO_TRASH:
|
||||
moveFolderToTrash(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case EMPTY_TRASH:
|
||||
emptyTrash(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RESTORE_FOLDER:
|
||||
restoreFolder(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RESTORE_NOTE:
|
||||
restoreNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RESTORE_ALL:
|
||||
restoreAll(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case CLONE_NOTE:
|
||||
cloneNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case IMPORT_NOTE:
|
||||
importNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case COMMIT_PARAGRAPH:
|
||||
updateParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RUN_PARAGRAPH:
|
||||
runParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_EXECUTED_BY_SPELL:
|
||||
broadcastSpellExecution(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case RUN_ALL_PARAGRAPHS:
|
||||
runAllParagraphs(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case CANCEL_PARAGRAPH:
|
||||
cancelParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case MOVE_PARAGRAPH:
|
||||
moveParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case INSERT_PARAGRAPH:
|
||||
insertParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case COPY_PARAGRAPH:
|
||||
copyParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_REMOVE:
|
||||
removeParagraph(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_CLEAR_OUTPUT:
|
||||
clearParagraphOutput(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PARAGRAPH_CLEAR_ALL_OUTPUT:
|
||||
clearAllParagraphOutput(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NOTE_UPDATE:
|
||||
updateNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NOTE_RENAME:
|
||||
renameNote(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case FOLDER_RENAME:
|
||||
renameFolder(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case UPDATE_PERSONALIZED_MODE:
|
||||
updatePersonalizedMode(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case COMPLETION:
|
||||
completion(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case PING:
|
||||
break; //do nothing
|
||||
case ANGULAR_OBJECT_UPDATED:
|
||||
angularObjectUpdated(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case ANGULAR_OBJECT_CLIENT_BIND:
|
||||
angularObjectClientBind(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case ANGULAR_OBJECT_CLIENT_UNBIND:
|
||||
angularObjectClientUnbind(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case LIST_CONFIGURATIONS:
|
||||
sendAllConfigurations(conn, userAndRoles, notebook);
|
||||
break;
|
||||
case CHECKPOINT_NOTE:
|
||||
checkpointNote(conn, notebook, messagereceived);
|
||||
break;
|
||||
case LIST_REVISION_HISTORY:
|
||||
listRevisionHistory(conn, notebook, messagereceived);
|
||||
break;
|
||||
case SET_NOTE_REVISION:
|
||||
setNoteRevision(conn, userAndRoles, notebook, messagereceived);
|
||||
break;
|
||||
case NOTE_REVISION:
|
||||
getNoteByRevision(conn, notebook, messagereceived);
|
||||
break;
|
||||
case LIST_NOTE_JOBS:
|
||||
unicastNoteJobInfo(conn, messagereceived);
|
||||
break;
|
||||
case UNSUBSCRIBE_UPDATE_NOTE_JOBS:
|
||||
unsubscribeNoteJobInfo(conn);
|
||||
break;
|
||||
case GET_INTERPRETER_BINDINGS:
|
||||
getInterpreterBindings(conn, messagereceived);
|
||||
break;
|
||||
case SAVE_INTERPRETER_BINDINGS:
|
||||
saveInterpreterBindings(conn, messagereceived);
|
||||
break;
|
||||
case EDITOR_SETTING:
|
||||
getEditorSetting(conn, messagereceived);
|
||||
break;
|
||||
case GET_INTERPRETER_SETTINGS:
|
||||
getInterpreterSettings(conn, subject);
|
||||
break;
|
||||
case WATCHER:
|
||||
switchConnectionToWatcher(conn, messagereceived);
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
} catch (Exception e) {
|
||||
LOG.error("Can't handle message", e);
|
||||
|
|
|
|||
|
|
@ -30,12 +30,12 @@ public class CommandLineUtils {
|
|||
}
|
||||
|
||||
String usage = args[0].toLowerCase(Locale.US);
|
||||
switch (usage){
|
||||
case "--version":
|
||||
case "-v":
|
||||
System.out.println(Util.getVersion());
|
||||
break;
|
||||
default:
|
||||
switch (usage) {
|
||||
case "--version":
|
||||
case "-v":
|
||||
System.out.println(Util.getVersion());
|
||||
break;
|
||||
default:
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -224,43 +224,43 @@ public class InstallInterpreter {
|
|||
for (int i = 0; i < args.length; i++) {
|
||||
String arg = args[i].toLowerCase(Locale.US);
|
||||
switch (arg) {
|
||||
case "--list":
|
||||
case "-l":
|
||||
installer.list();
|
||||
System.exit(0);
|
||||
break;
|
||||
case "--all":
|
||||
case "-a":
|
||||
all = true;
|
||||
break;
|
||||
case "--name":
|
||||
case "-n":
|
||||
names = args[++i];
|
||||
break;
|
||||
case "--artifact":
|
||||
case "-t":
|
||||
artifacts = args[++i];
|
||||
break;
|
||||
case "--version":
|
||||
case "-v":
|
||||
Util.getVersion();
|
||||
break;
|
||||
case "--proxy-url":
|
||||
proxyUrl = new URL(args[++i]);
|
||||
break;
|
||||
case "--proxy-user":
|
||||
proxyUser = args[++i];
|
||||
break;
|
||||
case "--proxy-password":
|
||||
proxyPassword = args[++i];
|
||||
break;
|
||||
case "--help":
|
||||
case "-h":
|
||||
usage();
|
||||
System.exit(0);
|
||||
break;
|
||||
default:
|
||||
System.out.println("Unknown option " + arg);
|
||||
case "--list":
|
||||
case "-l":
|
||||
installer.list();
|
||||
System.exit(0);
|
||||
break;
|
||||
case "--all":
|
||||
case "-a":
|
||||
all = true;
|
||||
break;
|
||||
case "--name":
|
||||
case "-n":
|
||||
names = args[++i];
|
||||
break;
|
||||
case "--artifact":
|
||||
case "-t":
|
||||
artifacts = args[++i];
|
||||
break;
|
||||
case "--version":
|
||||
case "-v":
|
||||
Util.getVersion();
|
||||
break;
|
||||
case "--proxy-url":
|
||||
proxyUrl = new URL(args[++i]);
|
||||
break;
|
||||
case "--proxy-user":
|
||||
proxyUser = args[++i];
|
||||
break;
|
||||
case "--proxy-password":
|
||||
proxyPassword = args[++i];
|
||||
break;
|
||||
case "--help":
|
||||
case "-h":
|
||||
usage();
|
||||
System.exit(0);
|
||||
break;
|
||||
default:
|
||||
System.out.println("Unknown option " + arg);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -220,12 +220,12 @@ public class ZeppelinhubClient {
|
|||
return;
|
||||
}
|
||||
switch (op) {
|
||||
case RUN_NOTEBOOK:
|
||||
runAllParagraph(hubMsg.meta.get("noteId"), msg);
|
||||
break;
|
||||
default:
|
||||
LOG.debug("Received {} from ZeppelinHub, not handled", op);
|
||||
break;
|
||||
case RUN_NOTEBOOK:
|
||||
runAllParagraph(hubMsg.meta.get("noteId"), msg);
|
||||
break;
|
||||
default:
|
||||
LOG.debug("Received {} from ZeppelinHub, not handled", op);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue