Elgato_dark/zeppelin
1
0
Fork 0
mirror of https://github.com/apache/zeppelin synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix multi dynamicforms behaviour

Browse source
This commit is contained in:
RyuAhyoung 2017-03-19 00:07:27 +09:00
parent 00e6aed0c7
commit 266f0c81d6
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
zeppelin-web/src/app/notebook/paragraph/paragraph-control.html
View file

@ -90,8 +90,7 @@ limitations under the License.
</li>
<li role="separator" class="divider"></li>
<li style="padding-top:8px"
ng-if="paragraph.settings.forms[$root.keys(paragraph.settings.forms)].options &&
paragraph.settings.forms[$root.keys(paragraph.settings.forms)].type != 'checkbox'">
ng-if="paragraph.config.runOnSelectionChange == true || paragraph.config.runOnSelectionChange == false">
<span ng-if="paragraph.config.runOnSelectionChange == true" class="fa fa-toggle-on shortcut-icon" style="padding:3px 8px 8px 20px"></span>
<span ng-if="paragraph.config.runOnSelectionChange == false" class="fa fa-toggle-off shortcut-icon" style="padding:3px 8px 8px 20px"></span>Run on selection change
<form style="display:inline; float:right">

13
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
View file

@ -137,11 +137,13 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
if (config.enabled === undefined) {
config.enabled = true;
}
if (forms[Object.keys(forms)]) {
if (forms[Object.keys(forms)].options && forms[Object.keys(forms)].type !== 'checkbox') {
if (config.runOnSelectionChange === undefined) {
config.runOnSelectionChange = true;
for (var idx in forms) {
if (forms[idx]) {
if (forms[idx].options && forms[idx].type !== 'checkbox') {
if (config.runOnSelectionChange === undefined) {
config.runOnSelectionChange = true;
}
}
}
}
@ -362,7 +364,6 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
if (!paragraphText || $scope.isRunning($scope.paragraph)) {
return;
}
const magic = SpellResult.extractMagic(paragraphText);
if (heliumService.getSpellByMagic(magic)) {