Review by felixcheung (09/08)

This commit is contained in:
conker84 2017-08-09 16:06:30 +02:00
parent aaf618ec39
commit 1e3d6117fa
5 changed files with 6 additions and 9 deletions

View file

@ -24,7 +24,7 @@ limitations under the License.
<div id="toc"></div>
## Overview
[Neo4j](https://neo4j.com/product/) is a native graph database, designed to store and process graphs from bottom to top. On the other hand, non-native solutions only add a shallow graph processing layer to an RDBMS or other NoSQL data stores, resulting in sub-optimal performance.
[Neo4j](https://neo4j.com/product/) is a native graph database, designed to store and process graphs from bottom to top.
![Neo4j - Interpreter - Video]({{BASE_PATH}}/assets/themes/zeppelin/img/docs-img/neo4j-interpreter-video.gif)

View file

@ -82,8 +82,6 @@ public class Neo4jConnectionManager {
case BASIC:
String username = properties.getProperty(NEO4J_AUTH_USER);
String password = properties.getProperty(NEO4J_AUTH_PASSWORD);
LOGGER.debug("Creating a BASIC authentication to neo4j with user '{}' and password '{}'",
username, password);
this.authToken = AuthTokens.basic(username, password);
break;
case NONE:

View file

@ -117,8 +117,8 @@ public class Neo4jCypherInterpreter extends Interpreter {
@Override
public InterpreterResult interpret(String cypherQuery, InterpreterContext interpreterContext) {
logger.info("Opening session");
if (StringUtils.isEmpty(cypherQuery)) {
return new InterpreterResult(Code.ERROR, "Cypher query is Empty");
if (StringUtils.isBlank(cypherQuery)) {
return new InterpreterResult(Code.SUCCESS);
}
try {
StatementResult result = this.neo4jConnectionManager.execute(cypherQuery,
@ -173,7 +173,6 @@ public class Neo4jCypherInterpreter extends Interpreter {
addValueToLine(key, columns, line, value);
}
} else if (obj instanceof Map) {
@SuppressWarnings("unchecked")
Map<String, Object> map = (Map<String, Object>) obj;
for (Entry<String, Object> entry : map.entrySet()) {
setTabularResult(String.format(MAP_KEY_TEMPLATE, key, entry.getKey()), entry.getValue(),

View file

@ -19,13 +19,13 @@
"neo4j.auth.user": {
"envName": null,
"propertyName": "neo4j.auth.user",
"defaultValue": "neo4j",
"defaultValue": "",
"description": "The Neo4j user name."
},
"neo4j.auth.password": {
"envName": null,
"propertyName": "neo4j.auth.password",
"defaultValue": "neo4j",
"defaultValue": "",
"description": "The Neo4j user password."
},
"neo4j.max.concurrency": {

View file

@ -217,7 +217,7 @@ The following components are provided under Apache License.
(Apache 2.0) frontend-maven-plugin 1.3 (com.github.eirslett:frontend-maven-plugin:1.3 - https://github.com/eirslett/frontend-maven-plugin/blob/frontend-plugins-1.3/LICENSE
(Apache 2.0) frontend-plugin-core 1.3 (com.github.eirslett:frontend-plugin-core) - https://github.com/eirslett/frontend-maven-plugin/blob/frontend-plugins-1.3/LICENSE
(Apache 2.0) mongo-java-driver 3.4.1 (org.mongodb:mongo-java-driver:3.4.1) - https://github.com/mongodb/mongo-java-driver/blob/master/LICENSE.txt
(Apache 2.0) Neo4j Java Driver (https://github.com/neo4j/neo4j-java-driver) - https://github.com/neo4j/neo4j-java-driver/blob/1.1/LICENSE.txt
(Apache 2.0) Neo4j Java Driver (https://github.com/neo4j/neo4j-java-driver) - https://github.com/neo4j/neo4j-java-driver/blob/1.4.0/LICENSE.txt
========================================================================
MIT licenses