- Translations are no longer fetched from the cloud.
- Instead, they are extracted from the codebase and stored in i18n/zammad.pot.
- Translations will be managed via a public Weblate instance soon.
- The translated .po files are fed to the database as before.
- It is now possible to change "translation" strings for en-us locally via the admin GUI.
- It is no longer possible to submit local changes.
This commit fixes a regression[0]
introduced in becbdb1ba (the Pundit migration).
Specifically, `CalendarSubscriptionsController` appears to be
the only controller that supports HTTP Basic authentication
(for calendar clients like Thunderbird Lightning or Calendar.app),
and the migration changed the control flow
for HTTP Basic authentication + authorization:
# before
authentication_check({ basic_auth_promt: true, permission: 'user_preferences.calendar' })
# after
authentication_check(basic_auth_promt: true) && authorize!
After this change, `#authentication_check` is expected
to communicate success or failure through its return value,
but prior to this bugfix, its return value was always truthy.
This led to a double-render error,
where a response code and message were set twice,
upon the failures of both authentication and authorization.
This fix adds a `return false` in the authorization failure case,
short-circuiting the `#authorize!` call and eliminating the error.
[0]: https://github.com/zammad/zammad/issues/3064
