waveterm/pkg/util/fileutil/fileutil.go
Copilot 4956c92c55
Make Wave home config writes atomic and serialized to avoid watcher partial reads (#2945)
`WriteWaveHomeConfigFile()` previously used direct `os.WriteFile`, which
can expose truncation/partial-write states to the JSON file watcher.
This change switches config persistence to temp-file + rename semantics
and serializes writes through a single process-wide lock for config file
writes.

- **Atomic file write helper**
  - Added `AtomicWriteFile()` in `pkg/util/fileutil/fileutil.go`.
- Writes to `<filename>.tmp` in the same directory, then renames to the
target path.
  - Performs temp-file cleanup on error paths.
- Introduced a shared suffix constant (`TempFileSuffix`) used by
implementation/tests.

- **Config write path update**
- Updated `WriteWaveHomeConfigFile()` in `pkg/wconfig/settingsconfig.go`
to:
- Use a package-level mutex (`configWriteLock`) so only one config write
runs at a time (across all config files).
- Call `fileutil.AtomicWriteFile(...)` instead of direct
`os.WriteFile(...)`.

- **Focused coverage for atomic behavior**
  - Added `pkg/util/fileutil/fileutil_test.go` with tests for:
- Successful atomic write (target file contains expected payload and no
leftover `.tmp` file).
    - Rename-failure path cleanup (temp file is removed).

```go
func WriteWaveHomeConfigFile(fileName string, m waveobj.MetaMapType) error {
    configWriteLock.Lock()
    defer configWriteLock.Unlock()

    fullFileName := filepath.Join(wavebase.GetWaveConfigDir(), fileName)
    barr, err := jsonMarshalConfigInOrder(m)
    if err != nil {
        return err
    }
    return fileutil.AtomicWriteFile(fullFileName, barr, 0644)
}
```

<!-- START COPILOT CODING AGENT TIPS -->
---

🔒 GitHub Advanced Security automatically protects Copilot coding agent
pull requests. You can protect all pull requests by enabling Advanced
Security for your repositories. [Learn more about Advanced
Security.](https://gh.io/cca-advanced-security)

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
2026-02-27 15:43:37 -08:00

364 lines
9.1 KiB
Go

// Copyright 2025, Command Line Inc.
// SPDX-License-Identifier: Apache-2.0
package fileutil
import (
"bytes"
"fmt"
"io"
"io/fs"
"mime"
"net/http"
"os"
"path/filepath"
"regexp"
"strings"
"github.com/wavetermdev/waveterm/pkg/wavebase"
)
func FixPath(path string) (string, error) {
origPath := path
var err error
if strings.HasPrefix(path, "~") {
path = filepath.Join(wavebase.GetHomeDir(), path[1:])
} else if !filepath.IsAbs(path) {
path, err = filepath.Abs(path)
if err != nil {
return "", err
}
}
if strings.HasSuffix(origPath, "/") && !strings.HasSuffix(path, "/") {
path += "/"
}
return path, nil
}
const (
winFlagSoftlink = uint32(0x8000) // FILE_ATTRIBUTE_REPARSE_POINT
winFlagJunction = uint32(0x80) // FILE_ATTRIBUTE_JUNCTION
)
func WinSymlinkDir(path string, bits os.FileMode) bool {
// Windows compatibility layer doesn't expose symlink target type through fileInfo
// so we need to check file attributes and extension patterns
isFileSymlink := func(filepath string) bool {
if len(filepath) == 0 {
return false
}
return strings.LastIndex(filepath, ".") > strings.LastIndex(filepath, "/")
}
flags := uint32(bits >> 12)
if flags == winFlagSoftlink {
return !isFileSymlink(path)
} else if flags == winFlagJunction {
return true
} else {
return false
}
}
// on error just returns ""
// does not return "application/octet-stream" as this is considered a detection failure
// can pass an existing fileInfo to avoid re-statting the file
// falls back to text/plain for 0 byte files
func DetectMimeType(path string, fileInfo fs.FileInfo, extended bool) string {
if fileInfo == nil {
statRtn, err := os.Stat(path)
if err != nil {
return ""
}
fileInfo = statRtn
}
if fileInfo.IsDir() || WinSymlinkDir(path, fileInfo.Mode()) {
return "directory"
}
if fileInfo.Mode()&os.ModeNamedPipe == os.ModeNamedPipe {
return "pipe"
}
charDevice := os.ModeDevice | os.ModeCharDevice
if fileInfo.Mode()&charDevice == charDevice {
return "character-special"
}
if fileInfo.Mode()&os.ModeDevice == os.ModeDevice {
return "block-special"
}
ext := strings.ToLower(filepath.Ext(path))
if mimeType, ok := StaticMimeTypeMap[ext]; ok {
return mimeType
}
if mimeType := mime.TypeByExtension(ext); mimeType != "" {
return mimeType
}
if fileInfo.Size() == 0 {
return "text/plain"
}
if !extended {
return ""
}
fd, err := os.Open(path)
if err != nil {
return ""
}
defer fd.Close()
buf := make([]byte, 512)
// ignore the error (EOF / UnexpectedEOF is fine, just process how much we got back)
n, _ := io.ReadAtLeast(fd, buf, 512)
if n == 0 {
return ""
}
buf = buf[:n]
rtn := http.DetectContentType(buf)
if rtn == "application/octet-stream" {
return ""
}
return rtn
}
func DetectMimeTypeWithDirEnt(path string, dirEnt fs.DirEntry) string {
if dirEnt != nil {
if dirEnt.IsDir() {
return "directory"
}
mode := dirEnt.Type()
if mode&os.ModeNamedPipe == os.ModeNamedPipe {
return "pipe"
}
charDevice := os.ModeDevice | os.ModeCharDevice
if mode&charDevice == charDevice {
return "character-special"
}
if mode&os.ModeDevice == os.ModeDevice {
return "block-special"
}
}
ext := strings.ToLower(filepath.Ext(path))
if mimeType, ok := StaticMimeTypeMap[ext]; ok {
return mimeType
}
return ""
}
func AtomicWriteFile(fileName string, data []byte, perm os.FileMode) error {
tmpFileName := fileName + TempFileSuffix
if err := os.WriteFile(tmpFileName, data, perm); err != nil {
if removeErr := os.Remove(tmpFileName); removeErr != nil && !os.IsNotExist(removeErr) {
return fmt.Errorf("failed to write temp file %q: %w (also failed to remove temp file: %v)", tmpFileName, err, removeErr)
}
return err
}
if err := os.Rename(tmpFileName, fileName); err != nil {
if removeErr := os.Remove(tmpFileName); removeErr != nil && !os.IsNotExist(removeErr) {
return fmt.Errorf("failed to rename temp file %q to %q: %w (also failed to remove temp file: %v)", tmpFileName, fileName, err, removeErr)
}
return err
}
return nil
}
var (
systemBinDirs = []string{
"/bin/",
"/usr/bin/",
"/usr/local/bin/",
"/opt/bin/",
"/sbin/",
"/usr/sbin/",
}
suspiciousPattern = regexp.MustCompile(`[:;#!&$\t%="|>{}]`)
flagPattern = regexp.MustCompile(` --?[a-zA-Z0-9]`)
)
// IsInitScriptPath tries to determine if the input string is a path to a script
// rather than an inline script content.
func IsInitScriptPath(input string) bool {
if len(input) == 0 || strings.Contains(input, "\n") {
return false
}
if suspiciousPattern.MatchString(input) {
return false
}
if flagPattern.MatchString(input) {
return false
}
// Check for home directory path
if strings.HasPrefix(input, "~/") {
return true
}
// Path must be absolute (if not home directory)
if !filepath.IsAbs(input) {
return false
}
// Check if path starts with system binary directories
normalizedPath := filepath.ToSlash(input)
for _, binDir := range systemBinDirs {
if strings.HasPrefix(normalizedPath, binDir) {
return false
}
}
return true
}
const (
TempFileSuffix = ".tmp"
MaxEditFileSize = 5 * 1024 * 1024 // 5MB
)
type EditSpec struct {
OldStr string `json:"old_str"`
NewStr string `json:"new_str"`
Desc string `json:"desc,omitempty"`
}
type EditResult struct {
Applied bool `json:"applied"`
Desc string `json:"desc"`
Error string `json:"error,omitempty"`
}
// applyEdit applies a single edit to the content and returns the modified content and result.
func applyEdit(content []byte, edit EditSpec, index int) ([]byte, EditResult) {
result := EditResult{
Desc: edit.Desc,
}
if result.Desc == "" {
result.Desc = fmt.Sprintf("Edit %d", index+1)
}
if edit.OldStr == "" {
result.Applied = false
result.Error = "old_str cannot be empty"
return content, result
}
oldBytes := []byte(edit.OldStr)
count := bytes.Count(content, oldBytes)
if count == 0 {
result.Applied = false
result.Error = "old_str not found in file"
return content, result
}
if count > 1 {
result.Applied = false
result.Error = fmt.Sprintf("old_str appears %d times, must appear exactly once", count)
return content, result
}
modifiedContent := bytes.Replace(content, oldBytes, []byte(edit.NewStr), 1)
result.Applied = true
return modifiedContent, result
}
// ApplyEdits applies a series of edits to the given content and returns the modified content.
// This is atomic - all edits succeed or all fail.
func ApplyEdits(originalContent []byte, edits []EditSpec) ([]byte, error) {
modifiedContents := originalContent
for i, edit := range edits {
var result EditResult
modifiedContents, result = applyEdit(modifiedContents, edit, i)
if !result.Applied {
return nil, fmt.Errorf("edit %d (%s): %s", i, result.Desc, result.Error)
}
}
return modifiedContents, nil
}
// ApplyEditsPartial applies edits incrementally, continuing until the first failure.
// Returns the modified content (potentially partially applied) and results for each edit.
func ApplyEditsPartial(originalContent []byte, edits []EditSpec) ([]byte, []EditResult) {
modifiedContents := originalContent
results := make([]EditResult, len(edits))
failed := false
for i, edit := range edits {
if failed {
results[i].Desc = edit.Desc
if results[i].Desc == "" {
results[i].Desc = fmt.Sprintf("Edit %d", i+1)
}
results[i].Applied = false
results[i].Error = "previous edit failed"
continue
}
modifiedContents, results[i] = applyEdit(modifiedContents, edit, i)
if !results[i].Applied {
failed = true
}
}
return modifiedContents, results
}
func ReplaceInFile(filePath string, edits []EditSpec) error {
fileInfo, err := os.Stat(filePath)
if err != nil {
return fmt.Errorf("failed to stat file: %w", err)
}
if !fileInfo.Mode().IsRegular() {
return fmt.Errorf("not a regular file: %s", filePath)
}
if fileInfo.Size() > MaxEditFileSize {
return fmt.Errorf("file too large for editing: %d bytes (max: %d)", fileInfo.Size(), MaxEditFileSize)
}
contents, err := os.ReadFile(filePath)
if err != nil {
return fmt.Errorf("failed to read file: %w", err)
}
modifiedContents, err := ApplyEdits(contents, edits)
if err != nil {
return err
}
if err := os.WriteFile(filePath, modifiedContents, fileInfo.Mode()); err != nil {
return fmt.Errorf("failed to write file: %w", err)
}
return nil
}
// ReplaceInFilePartial applies edits incrementally up to the first failure.
// Returns the results for each edit and writes the partially modified content.
func ReplaceInFilePartial(filePath string, edits []EditSpec) ([]EditResult, error) {
fileInfo, err := os.Stat(filePath)
if err != nil {
return nil, fmt.Errorf("failed to stat file: %w", err)
}
if !fileInfo.Mode().IsRegular() {
return nil, fmt.Errorf("not a regular file: %s", filePath)
}
if fileInfo.Size() > MaxEditFileSize {
return nil, fmt.Errorf("file too large for editing: %d bytes (max: %d)", fileInfo.Size(), MaxEditFileSize)
}
contents, err := os.ReadFile(filePath)
if err != nil {
return nil, fmt.Errorf("failed to read file: %w", err)
}
modifiedContents, results := ApplyEditsPartial(contents, edits)
if err := os.WriteFile(filePath, modifiedContents, fileInfo.Mode()); err != nil {
return nil, fmt.Errorf("failed to write file: %w", err)
}
return results, nil
}