add try/catch around workspace menu (#1492)

This commit is contained in:
Mike Sawka 2024-12-11 10:48:50 -08:00 committed by GitHub
parent 448262c17f
commit ab5e7b5bd9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -272,9 +272,12 @@ async function getAppMenu(callbacks: AppMenuCallbacks, workspaceId?: string): Pr
role: "togglefullscreen",
},
];
const workspaceMenu = await getWorkspaceMenu();
let workspaceMenu: Electron.MenuItemConstructorOptions[] = null;
try {
workspaceMenu = await getWorkspaceMenu();
} catch (e) {
console.error("getWorkspaceMenu error:", e);
}
const windowMenu: Electron.MenuItemConstructorOptions[] = [
{ role: "minimize", accelerator: "" },
{ role: "zoom" },
@ -300,16 +303,18 @@ async function getAppMenu(callbacks: AppMenuCallbacks, workspaceId?: string): Pr
role: "viewMenu",
submenu: viewMenu,
},
{
];
if (workspaceMenu != null) {
menuTemplate.push({
label: "Workspace",
id: "workspace-menu",
submenu: workspaceMenu,
},
{
role: "windowMenu",
submenu: windowMenu,
},
];
});
}
menuTemplate.push({
role: "windowMenu",
submenu: windowMenu,
});
return electron.Menu.buildFromTemplate(menuTemplate);
}