From a146b8ba0dfee94769a51e8cd0e4fd95d453707d Mon Sep 17 00:00:00 2001 From: Dylan-86 <58813956+Dylan-86@users.noreply.github.com> Date: Thu, 17 Apr 2025 12:58:07 +0200 Subject: [PATCH 1/3] Update HOW_TO_CONTRIBUTE.md I added some notes about Ubuntu installing as I ran through a simple npm blocking error when a folder in the Void path contains a space " " like "New Folder". I simply moved to "NewFolder" and the error disappeared. --- HOW_TO_CONTRIBUTE.md | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/HOW_TO_CONTRIBUTE.md b/HOW_TO_CONTRIBUTE.md index d2a1e649..ba2cbd4f 100644 --- a/HOW_TO_CONTRIBUTE.md +++ b/HOW_TO_CONTRIBUTE.md @@ -52,25 +52,27 @@ First, run `npm install -g node-gyp`. Then: ### d. Building Void -To build Void, open `void/` inside VSCode. Then open your terminal and run: +1. Clone the Void repository inside a fresh folder with `git clone https://github.com/voideditor/void`. Make sure that your folder path does not include spaces: this may generate errors during `npm install`. +2. You can build Void from VSCOde: open `void/` inside VSCode. Then open the terminal inside VSCode and run: -1. `npm install` to install all dependencies. -2. `npm run watchreact` to build Void's browser dependencies like React. (If this doesn't work, try `npm run buildreact`). -3. Build Void. - - Press Cmd+Shift+B (Mac). - - Press Ctrl+Shift+B (Windows/Linux). - - This step can take ~5 min. The build is done when you see two check marks (one of the items will continue spinning indefinitely - it compiles our React code). -4. Run Void. - - Run `./scripts/code.sh` (Mac/Linux). - - Run `./scripts/code.bat` (Windows). -6. Nice-to-knows. - - You can always press Ctrl+R (Cmd+R) inside the new window to reload and see your new changes. It's faster than Ctrl+Shift+P and `Reload Window`. - - You might want to add the flags `--user-data-dir ./.tmp/user-data --extensions-dir ./.tmp/extensions` to the above run command, which lets you delete the `.tmp` folder to reset any IDE changes you made when testing. - - You can kill any of the build scripts by pressing `Ctrl+D` in VSCode terminal. If you press `Ctrl+C` the script will close but will keep running in the background (to open all background scripts, just re-build). + 1. `npm install` to install all dependencies. + 2. `npm run watchreact` to build Void's browser dependencies like React. (If this doesn't work, try `npm run buildreact`). + 3. Build Void. + - Press Cmd+Shift+B (Mac). + - Press Ctrl+Shift+B (Windows/Linux). + - This step can take ~5 min. The build is done when you see two check marks (one of the items will continue spinning indefinitely - it compiles our React code). + 4. Run Void. + - Run `./scripts/code.sh` (Mac/Linux). + - Run `./scripts/code.bat` (Windows). + 6. Nice-to-knows. + - You can always press Ctrl+R (Cmd+R) inside the new window to reload and see your new changes. It's faster than Ctrl+Shift+P and `Reload Window`. + - You might want to add the flags `--user-data-dir ./.tmp/user-data --extensions-dir ./.tmp/extensions` to the above run command, which lets you delete the `.tmp` folder to reset any IDE changes you made when testing. + - You can kill any of the build scripts by pressing `Ctrl+D` in VSCode terminal. If you press `Ctrl+C` the script will close but will keep running in the background (to open all background scripts, just re-build). #### Building Void from Terminal -Alternatively, if you want to build Void from the terminal, instead of pressing Cmd+Shift+B you can run `npm run watch`. The build is done when you see something like this: +Alternatively, you can build Void from the terminal, instead of pressing Cmd+Shift+B you can simply run `npm run watch`. +The build is done when you see something like this: ``` [watch-extensions] [00:37:39] Finished compilation extensions with 0 errors after 19303 ms @@ -84,6 +86,7 @@ Alternatively, if you want to build Void from the terminal, instead of pressing #### Common Fixes - Make sure you followed the prerequisite steps. +- Make sure that the folder path does not include any "space". For example, `/home/user/New Folder/void` may generate errors during `npm install`. Simply remove the space: For example `/home/user/NewFolder/void` - Make sure you have Node version `20.18.2` (the version in `.nvmrc`)! - If you get `"TypeError: Failed to fetch dynamically imported module"`, make sure all imports end with `.js`. - If you see missing styles, wait a few seconds and then reload. From 9871d4f413471ac030a8891fabba8bfebc509e8e Mon Sep 17 00:00:00 2001 From: Andrew Pareles Date: Tue, 29 Apr 2025 00:50:04 -0700 Subject: [PATCH 2/3] update --- HOW_TO_CONTRIBUTE.md | 38 ++++++++++++++++++-------------------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/HOW_TO_CONTRIBUTE.md b/HOW_TO_CONTRIBUTE.md index ba2cbd4f..06b660fa 100644 --- a/HOW_TO_CONTRIBUTE.md +++ b/HOW_TO_CONTRIBUTE.md @@ -52,27 +52,25 @@ First, run `npm install -g node-gyp`. Then: ### d. Building Void -1. Clone the Void repository inside a fresh folder with `git clone https://github.com/voideditor/void`. Make sure that your folder path does not include spaces: this may generate errors during `npm install`. -2. You can build Void from VSCOde: open `void/` inside VSCode. Then open the terminal inside VSCode and run: +1. `git clone https://github.com/voideditor/void` to clone the repo. - 1. `npm install` to install all dependencies. - 2. `npm run watchreact` to build Void's browser dependencies like React. (If this doesn't work, try `npm run buildreact`). - 3. Build Void. - - Press Cmd+Shift+B (Mac). - - Press Ctrl+Shift+B (Windows/Linux). - - This step can take ~5 min. The build is done when you see two check marks (one of the items will continue spinning indefinitely - it compiles our React code). - 4. Run Void. - - Run `./scripts/code.sh` (Mac/Linux). - - Run `./scripts/code.bat` (Windows). - 6. Nice-to-knows. - - You can always press Ctrl+R (Cmd+R) inside the new window to reload and see your new changes. It's faster than Ctrl+Shift+P and `Reload Window`. - - You might want to add the flags `--user-data-dir ./.tmp/user-data --extensions-dir ./.tmp/extensions` to the above run command, which lets you delete the `.tmp` folder to reset any IDE changes you made when testing. - - You can kill any of the build scripts by pressing `Ctrl+D` in VSCode terminal. If you press `Ctrl+C` the script will close but will keep running in the background (to open all background scripts, just re-build). +2. `npm install` to install all dependencies. +3. `npm run watchreact` to build Void's browser dependencies like React. (If this doesn't work, try `npm run buildreact`). +4. Build Void. + - Press Cmd+Shift+B (Mac). + - Press Ctrl+Shift+B (Windows/Linux). + - This step can take ~5 min. The build is done when you see two check marks (one of the items will continue spinning indefinitely - it compiles our React code). +5. Run Void. + - Run `./scripts/code.sh` (Mac/Linux). + - Run `./scripts/code.bat` (Windows). +6. Nice-to-knows. + - You can always press Ctrl+R (Cmd+R) inside the new window to reload and see your new changes. It's faster than Ctrl+Shift+P and `Reload Window`. + - You might want to add the flags `--user-data-dir ./.tmp/user-data --extensions-dir ./.tmp/extensions` to the above run command, which lets you delete the `.tmp` folder to reset any IDE changes you made when testing. + - You can kill any of the build scripts by pressing `Ctrl+D` in VSCode terminal. If you press `Ctrl+C` the script will close but will keep running in the background (to open all background scripts, just re-build). #### Building Void from Terminal -Alternatively, you can build Void from the terminal, instead of pressing Cmd+Shift+B you can simply run `npm run watch`. -The build is done when you see something like this: +Alternatively, if you want to build Void from the terminal, instead of pressing Cmd+Shift+B you can run `npm run watch`. The build is done when you see something like this: ``` [watch-extensions] [00:37:39] Finished compilation extensions with 0 errors after 19303 ms @@ -86,12 +84,12 @@ The build is done when you see something like this: #### Common Fixes - Make sure you followed the prerequisite steps. -- Make sure that the folder path does not include any "space". For example, `/home/user/New Folder/void` may generate errors during `npm install`. Simply remove the space: For example `/home/user/NewFolder/void` - Make sure you have Node version `20.18.2` (the version in `.nvmrc`)! - If you get `"TypeError: Failed to fetch dynamically imported module"`, make sure all imports end with `.js`. - If you see missing styles, wait a few seconds and then reload. -- If you have any questions, feel free to [submit an issue](https://github.com/voideditor/void/issues/new). You can also refer to VSCode's complete [How to Contribute](https://github.com/microsoft/vscode/wiki/How-to-Contribute) page. -- If you get errors like `npm error libtool: error: unrecognised option: '-static'`, make sure you have GNU libtool instead of BSD libtool (BSD is the default in macos) +- If you get errors like `npm error libtool: error: unrecognised option: '-static'`, make sure you have GNU libtool instead of BSD libtool (BSD is the default in macos). +- Make sure that the path to your Void folder does not have any spaces in it. +- If you have any other questions, feel free to [submit an issue](https://github.com/voideditor/void/issues/new). You can also refer to VSCode's complete [How to Contribute](https://github.com/microsoft/vscode/wiki/How-to-Contribute) page. ## Packaging From e493e65cffd2aa317d22add126168bb67d316987 Mon Sep 17 00:00:00 2001 From: Andrew Pareles Date: Tue, 29 Apr 2025 00:58:22 -0700 Subject: [PATCH 3/3] update --- HOW_TO_CONTRIBUTE.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/HOW_TO_CONTRIBUTE.md b/HOW_TO_CONTRIBUTE.md index 2d51131d..67fd819f 100644 --- a/HOW_TO_CONTRIBUTE.md +++ b/HOW_TO_CONTRIBUTE.md @@ -54,13 +54,15 @@ First, run `npm install -g node-gyp`. Then: 1. `git clone https://github.com/voideditor/void` to clone the repo. 2. `npm install` to install all dependencies. -3. Build Void. - - Press Cmd+Shift+B (Mac). - - Press Ctrl+Shift+B (Windows/Linux). +3. To build Void, open VSCode. Then: + - Windows: Press Ctrl+Shift+B. + - Mac: Press Cmd+Shift+B. + - Linux: Press Ctrl+Shift+B. - This step can take ~5 min. The build is done when you see two check marks (one of the items will continue spinning indefinitely - it compiles our React code). -4. Run Void. - - Run `./scripts/code.sh` (Mac/Linux). - - Run `./scripts/code.bat` (Windows). +4. To run Void: + - Windows: `./scripts/code.bat`. + - Mac: `./scripts/code.sh`. + - Linux: `./scripts/code.sh`. 5. Nice-to-knows. - You can always press Ctrl+R (Cmd+R) inside the new window to reload and see your new changes. It's faster than Ctrl+Shift+P and `Reload Window`. - You might want to add the flags `--user-data-dir ./.tmp/user-data --extensions-dir ./.tmp/extensions` to the above run command, which lets you delete the `.tmp` folder to reset any IDE changes you made when testing.