From c239682ad8381ce9294ef5dfa0c9ffa43e5c30a7 Mon Sep 17 00:00:00 2001 From: Mathew Pareles Date: Tue, 21 Jan 2025 14:18:35 -0800 Subject: [PATCH] better ux --- .../browser/helperServices/consistentItemService.ts | 4 ---- .../browser/react/src/sidebar-tsx/SidebarChat.tsx | 11 +++++------ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/vs/workbench/contrib/void/browser/helperServices/consistentItemService.ts b/src/vs/workbench/contrib/void/browser/helperServices/consistentItemService.ts index 6de0b53b..3bc20a49 100644 --- a/src/vs/workbench/contrib/void/browser/helperServices/consistentItemService.ts +++ b/src/vs/workbench/contrib/void/browser/helperServices/consistentItemService.ts @@ -127,8 +127,6 @@ export class ConsistentItemService extends Disposable { const editorId = editor.getId() this.itemIdsOfEditorId[editorId]?.delete(itemId) - if (this.itemIdsOfEditorId[editorId]?.size === 0) - delete this.itemIdsOfEditorId[editorId] this.disposeFnOfItemId[itemId]?.() delete this.disposeFnOfItemId[itemId] @@ -175,8 +173,6 @@ export class ConsistentItemService extends Disposable { // clear this.consistentItemIdsOfURI[uri.fsPath]?.delete(consistentItemId) - if (this.consistentItemIdsOfURI[uri.fsPath]?.size === 0) - delete this.consistentItemIdsOfURI[uri.fsPath] delete this.infoOfConsistentItemId[consistentItemId] diff --git a/src/vs/workbench/contrib/void/browser/react/src/sidebar-tsx/SidebarChat.tsx b/src/vs/workbench/contrib/void/browser/react/src/sidebar-tsx/SidebarChat.tsx index 75e4579e..7491a294 100644 --- a/src/vs/workbench/contrib/void/browser/react/src/sidebar-tsx/SidebarChat.tsx +++ b/src/vs/workbench/contrib/void/browser/react/src/sidebar-tsx/SidebarChat.tsx @@ -380,7 +380,7 @@ export const SelectedFiles = ( {/* clear all selections button */} - {type !== 'staging' || selections.length === 0 || i !== selections.length - 1 + {/* {type !== 'staging' || selections.length === 0 || i !== selections.length - 1 ? null :
- } + } */} {/* selection text */} {isThisSelectionOpened && @@ -423,9 +423,8 @@ export const SelectedFiles = ( ) return - {selections.length > 0 && i === selections.length && -
// divider between `selections` and `prospectiveSelections` - } + {/* divider between `selections` and `prospectiveSelections` */} + {/* {selections.length > 0 && i === selections.length &&
} */} {selectionHTML}
@@ -675,7 +674,7 @@ export const SidebarChat = () => { {/* top row */} <> {/* selections */} - + {/* middle row */}