Elgato_dark/void
1
0
Fork 0
mirror of https://github.com/voideditor/void synced 2026-05-23 09:28:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enhance provider name display logic in ModelDropdown and settings service

Browse source 
- Updated ModelDropdown to utilize displayInfoOfProviderName for provider name details.
- Adjusted settings service to ensure consistent provider title formatting.
- Corrected display title for 'appleFoundationModels' to lowercase for uniformity.
This commit is contained in:
Jérôme Commaret 2026-05-20 16:12:15 +02:00
parent d5dcfe2f07
commit bf80a00b30
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/vs/workbench/contrib/void/browser/react/src/void-settings-tsx/ModelDropdown.tsx
View file

@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------*/
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { FeatureName, featureNames, isFeatureNameDisabled, ModelSelection, modelSelectionsEqual, ProviderName, providerNames, SettingsOfProvider } from '../../../../../../../workbench/contrib/void/common/voidSettingsTypes.js'
import { FeatureName, featureNames, isFeatureNameDisabled, ModelSelection, modelSelectionsEqual, ProviderName, providerNames, SettingsOfProvider, displayInfoOfProviderName } from '../../../../../../../workbench/contrib/void/common/voidSettingsTypes.js'
import { useSettingsState, useRefreshModelState, useAccessor } from '../util/services.js'
import { _VoidSelectBox, VoidCustomDropdownBox } from '../util/inputs.js'
import { SelectBox } from '../../../../../../../base/browser/ui/selectBox/selectBox.js'
@ -39,7 +39,7 @@ const ModelSelectBox = ({ options, featureName, className }: { options: ModelOpt
onChangeOption={onChangeOption}
getOptionDisplayName={(option) => option.name}
getOptionDropdownName={(option) => option.name}
getOptionDropdownDetail={(option) => option.selection.providerName}
getOptionDropdownDetail={(option) => displayInfoOfProviderName(option.selection.providerName).title}
getOptionsEqual={(a, b) => optionsEqual([a], [b])}
className={className}
matchInputWidth={false}

4
src/vs/workbench/contrib/void/common/voidSettingsService.ts
View file

@ -15,7 +15,7 @@ import { defaultProviderSettings, getModelCapabilities, ModelOverrides } from '.
import { VOID_SETTINGS_STORAGE_KEY } from './storageKeys.js';
import { isMacintosh } from '../../../../base/common/platform.js';
import { consolidateSingleAutodetectedProviderModels, dedupeProviderModels, normalizeAutodetectedModelNamesForProvider } from './localSingleModelProviders.js';
import { defaultSettingsOfProvider, FeatureName, ProviderName, ModelSelectionOfFeature, SettingsOfProvider, SettingName, providerNames, ModelSelection, modelSelectionsEqual, featureNames, VoidStatefulModelInfo, GlobalSettings, GlobalSettingName, defaultGlobalSettings, ModelSelectionOptions, OptionsOfModelSelection, ChatMode, OverridesOfModel, defaultOverridesOfModel, MCPUserStateOfName as MCPUserStateOfName, MCPUserState } from './voidSettingsTypes.js';
import { defaultSettingsOfProvider, displayInfoOfProviderName, FeatureName, ProviderName, ModelSelectionOfFeature, SettingsOfProvider, SettingName, providerNames, ModelSelection, modelSelectionsEqual, featureNames, VoidStatefulModelInfo, GlobalSettings, GlobalSettingName, defaultGlobalSettings, ModelSelectionOptions, OptionsOfModelSelection, ChatMode, OverridesOfModel, defaultOverridesOfModel, MCPUserStateOfName as MCPUserStateOfName, MCPUserState } from './voidSettingsTypes.js';
// name is the name in the dropdown
@ -192,7 +192,7 @@ const _validatedModelState = (state: Omit<VoidSettingsState, '_modelOptions'>):
let newModelOptions: ModelOption[] = []
for (const providerName of providerNames) {
const providerTitle = providerName // displayInfoOfProviderName(providerName).title.toLowerCase() // looks better lowercase, best practice to not use raw providerName
const providerTitle = displayInfoOfProviderName(providerName).title
if (!newSettingsOfProvider[providerName]._didFillInProviderSettings) continue // if disabled, don't display model options
for (const { modelName, isHidden } of newSettingsOfProvider[providerName].models) {
if (isHidden) continue

2
src/vs/workbench/contrib/void/common/voidSettingsTypes.ts
View file

@ -86,7 +86,7 @@ export const displayInfoOfProviderName = (providerName: ProviderName): DisplayIn
return { title: 'MLX', }
}
else if (providerName === 'appleFoundationModels') {
return { title: 'Apple', }
return { title: 'apple', }
}
else if (providerName === 'openAICompatible') {
return { title: 'OpenAI-Compatible', }