From 68722ee5c3d0b6c1f7ff3d358e5fff951eefb348 Mon Sep 17 00:00:00 2001 From: Praveen Naik Date: Fri, 3 Jan 2025 21:04:54 +0530 Subject: [PATCH 1/2] Update CONTRIBUTING.md Added details about Bundling output. Most of us open only the repo without workspace to save memory. It's easy to miss out on where the bundle is located. Added clarity --- CONTRIBUTING.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9c770973..1931c1e8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -83,7 +83,16 @@ Alternatively, if you want to build Void from the terminal, instead of pressing ## Bundling -We don't usually recommend bundling. Instead, you should probably just build. If you're sure you want to bundle Void into an executable app, make sure you've built first, then run one of the following commands. This will create a folder named `VSCode-darwin-arm64` (or similar) in the repo's parent's directory. Be patient - compiling can take ~25 minutes. +We don't usually recommend bundling. Instead, you should probably just build. If you're sure you want to bundle Void into an executable app, make sure you've built first, then run one of the following commands. This will create a folder named `VSCode-darwin-arm64` (or similar) in the repo's parent's directory(Refer the Folder structure below). Be patient - compiling can take ~25 minutes. + +```bash +workspace/ +├── void/ # Your Void Fork +├── VSCode-linux-x64/ # Build folder generated outside of void for Linux +└── VSCode-darwin-arm64/ # Build folder generated outside of void for MacOs + +``` + ### Mac - `npm run gulp vscode-darwin-arm64` - most common (Apple Silicon) From fae03c30607d825d1fa179544a358a3e07cb8b02 Mon Sep 17 00:00:00 2001 From: Andrew Pareles <43356051+andrewpareles@users.noreply.github.com> Date: Fri, 3 Jan 2025 12:44:12 -0800 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1931c1e8..488ed5c4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -83,13 +83,13 @@ Alternatively, if you want to build Void from the terminal, instead of pressing ## Bundling -We don't usually recommend bundling. Instead, you should probably just build. If you're sure you want to bundle Void into an executable app, make sure you've built first, then run one of the following commands. This will create a folder named `VSCode-darwin-arm64` (or similar) in the repo's parent's directory(Refer the Folder structure below). Be patient - compiling can take ~25 minutes. +We don't usually recommend bundling. Instead, you should probably just build. If you're sure you want to bundle Void into an executable app, make sure you've built first, then run one of the following commands. This will create a folder named `VSCode-darwin-arm64` or similar outside of the void/ repo (see below). Be patient - compiling can take ~25 minutes. ```bash workspace/ ├── void/ # Your Void Fork ├── VSCode-linux-x64/ # Build folder generated outside of void for Linux -└── VSCode-darwin-arm64/ # Build folder generated outside of void for MacOs +└── VSCode-darwin-arm64/ # Build folder generated outside of void for Mac ```