diff --git a/build/darwin/sign.js b/build/darwin/sign.js index 8cb34a08..2dbc5702 100644 --- a/build/darwin/sign.js +++ b/build/darwin/sign.js @@ -54,9 +54,11 @@ async function main(buildDir) { ...defaultOpts, // TODO(deepak1556): Incorrectly declared type in electron-osx-sign ignore: (filePath) => { + const ext = path_1.default.extname(filePath); return filePath.includes(gpuHelperAppName) || filePath.includes(rendererHelperAppName) || - filePath.includes(pluginHelperAppName); + filePath.includes(pluginHelperAppName) || + ext === '.asar' || ext === '.dat' || ext === '.gif' || ext === '.icns' || ext === '.ico' || ext === '.json' || ext === '.mp3' || ext === '.nib' || ext === '.pak' || ext === '.png' || ext === '.scpt' || ext === '.ttf' || ext === '.wasm' || ext === '.woff' || ext === '.woff2'; } }; const gpuHelperOpts = { diff --git a/build/darwin/sign.ts b/build/darwin/sign.ts index c509dd01..cff07c75 100644 --- a/build/darwin/sign.ts +++ b/build/darwin/sign.ts @@ -58,9 +58,11 @@ async function main(buildDir?: string): Promise { ...defaultOpts, // TODO(deepak1556): Incorrectly declared type in electron-osx-sign ignore: (filePath: string) => { + const ext = path.extname(filePath); return filePath.includes(gpuHelperAppName) || filePath.includes(rendererHelperAppName) || - filePath.includes(pluginHelperAppName); + filePath.includes(pluginHelperAppName) || + ext === '.asar' || ext === '.dat' || ext === '.gif' || ext === '.icns' || ext === '.ico' || ext === '.json' || ext === '.mp3' || ext === '.nib' || ext === '.pak' || ext === '.png' || ext === '.scpt' || ext === '.ttf' || ext === '.wasm' || ext === '.woff' || ext === '.woff2'; } }; diff --git a/build/gulpfile.reh.js b/build/gulpfile.reh.js index 04354d8d..b4b7f49e 100644 --- a/build/gulpfile.reh.js +++ b/build/gulpfile.reh.js @@ -154,9 +154,20 @@ function getNodeChecksum(expectedName) { } function extractAlpinefromDocker(nodeVersion, platform, arch) { - const imageName = arch === 'arm64' ? 'arm64v8/node' : 'node'; + let imageName = 'node'; + let dockerPlatform = ''; + + if (arch === 'arm64') { + imageName = 'arm64v8/node'; + + const architecture = cp.execSync(`docker info --format '{{json .Architecture}}'`, { encoding: 'utf8' }).trim(); + if (architecture !== '"aarch64"') { + dockerPlatform = '--platform=linux/arm64'; + } + } + log(`Downloading node.js ${nodeVersion} ${platform} ${arch} from docker image ${imageName}`); - const contents = cp.execSync(`docker run --rm ${imageName}:${nodeVersion}-alpine /bin/sh -c 'cat \`which node\`'`, { maxBuffer: 100 * 1024 * 1024, encoding: 'buffer' }); + const contents = cp.execSync(`docker run --rm ${dockerPlatform} ${imageName}:${nodeVersion}-alpine /bin/sh -c 'cat \`which node\`'`, { maxBuffer: 100 * 1024 * 1024, encoding: 'buffer' }); return es.readArray([new File({ path: 'node', contents, stat: { mode: parseInt('755', 8) } })]); } diff --git a/build/lib/builtInExtensions.js b/build/lib/builtInExtensions.js index 249777c4..ba9c134a 100644 --- a/build/lib/builtInExtensions.js +++ b/build/lib/builtInExtensions.js @@ -85,10 +85,7 @@ function getExtensionDownloadStream(extension) { if (extension.vsix) { input = ext.fromVsix(path_1.default.join(root, extension.vsix), extension); } - else if (productjson.extensionsGallery?.serviceUrl) { - input = ext.fromMarketplace(productjson.extensionsGallery.serviceUrl, extension); - } - else { + else { // Void - ext-from-gh.patch input = ext.fromGithub(extension); } return input.pipe((0, gulp_rename_1.default)(p => p.dirname = `${extension.name}/${p.dirname}`)); diff --git a/src/vs/workbench/electron-sandbox/window.ts b/src/vs/workbench/electron-sandbox/window.ts index 4babd90f..ce02472e 100644 --- a/src/vs/workbench/electron-sandbox/window.ts +++ b/src/vs/workbench/electron-sandbox/window.ts @@ -255,8 +255,8 @@ export class NativeWindow extends BaseWindow { label: localize('downloadArmBuild', "Download"), run: () => { const quality = this.productService.quality; - const stableURL = 'https://code.visualstudio.com/docs/?dv=osx'; - const insidersURL = 'https://code.visualstudio.com/docs/?dv=osx&build=insiders'; + const stableURL = 'https://github.com/!!GH_REPO_PATH!!/releases/latest'; + const insidersURL = 'https://github.com/!!GH_REPO_PATH!!-insiders/releases/latest'; this.openerService.open(quality === 'stable' ? stableURL : insidersURL); } }],