Elgato_dark/void
1
0
Fork 0
mirror of https://github.com/voideditor/void synced 2026-05-24 09:58:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #10 from danialsamiei/devin/1771279979-fix-settings-event

Browse source 
Fix settings state: fire event before async storage to ensure React updates
This commit is contained in:
Danial Samiei 2026-02-17 01:52:12 +03:30 committed by GitHub
commit 5351e092bd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/vs/workbench/contrib/void/common/voidSettingsService.ts
View file

@ -260,10 +260,10 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
dangerousSetState = async (newState: VoidSettingsState) => { dangerousSetState = async (newState: VoidSettingsState) => {
this.state = _validatedModelState(newState) this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire() this._onDidChangeState.fire()
this._onUpdate_syncApplyToChat() this._onUpdate_syncApplyToChat()
this._onUpdate_syncSCMToChat() this._onUpdate_syncSCMToChat()
await this._storeState()
} }
async resetState() { async resetState() {
await this.dangerousSetState(defaultState()) await this.dangerousSetState(defaultState())
@ -360,9 +360,13 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
private async _storeState() { private async _storeState() {
const state = this.state try {
const encryptedState = await this._encryptionService.encrypt(JSON.stringify(state)) const state = this.state
this._storageService.store(VOID_SETTINGS_STORAGE_KEY, encryptedState, StorageScope.APPLICATION, StorageTarget.USER); const encryptedState = await this._encryptionService.encrypt(JSON.stringify(state))
this._storageService.store(VOID_SETTINGS_STORAGE_KEY, encryptedState, StorageScope.APPLICATION, StorageTarget.USER);
} catch (e) {
console.error('[VoidSettingsService] Failed to store state:', e);
}
} }
setSettingOfProvider: SetSettingOfProviderFn = async (providerName, settingName, newVal) => { setSettingOfProvider: SetSettingOfProviderFn = async (providerName, settingName, newVal) => {
@ -393,14 +397,13 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
} }
this.state = _validatedModelState(newState) this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire() this._onDidChangeState.fire()
await this._storeState()
} }
private _onUpdate_syncApplyToChat() { private _onUpdate_syncApplyToChat(){
// if sync is turned on, sync (call this whenever Chat model or !!sync changes) // if sync is turned on, sync (call this whenever Chat model or !!sync changes)
this.setModelSelectionOfFeature('Apply', deepClone(this.state.modelSelectionOfFeature['Chat'])) this.setModelSelectionOfFeature('Apply', deepClone(this.state.modelSelectionOfFeature['Chat']))
} }
@ -418,10 +421,10 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
} }
} }
this.state = _validatedModelState(newState) this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire() this._onDidChangeState.fire()
// hooks // hooks
await this._storeState()
if (this.state.globalSettings.syncApplyToChat) this._onUpdate_syncApplyToChat() if (this.state.globalSettings.syncApplyToChat) this._onUpdate_syncApplyToChat()
if (this.state.globalSettings.syncSCMToChat) this._onUpdate_syncSCMToChat() if (this.state.globalSettings.syncSCMToChat) this._onUpdate_syncSCMToChat()
@ -438,10 +441,9 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
} }
this.state = _validatedModelState(newState) this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire() this._onDidChangeState.fire()
await this._storeState()
// hooks // hooks
if (featureName === 'Chat') { if (featureName === 'Chat') {
// When Chat model changes, update synced features // When Chat model changes, update synced features
@ -469,9 +471,8 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
} }
} }
this.state = _validatedModelState(newState) this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire() this._onDidChangeState.fire()
await this._storeState()
} }
setOverridesOfModel = async (providerName: ProviderName, modelName: string, overrides: Partial<ModelOverrides> | undefined) => { setOverridesOfModel = async (providerName: ProviderName, modelName: string, overrides: Partial<ModelOverrides> | undefined) => {
@ -490,8 +491,8 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
}; };
this.state = _validatedModelState(newState); this.state = _validatedModelState(newState);
await this._storeState();
this._onDidChangeState.fire(); this._onDidChangeState.fire();
await this._storeState();
this._metricsService.capture('Update Model Overrides', { providerName, modelName, overrides }); this._metricsService.capture('Update Model Overrides', { providerName, modelName, overrides });
} }
@ -570,8 +571,8 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
} }
}; };
this.state = _validatedModelState(newState); this.state = _validatedModelState(newState);
await this._storeState();
this._onDidChangeState.fire(); this._onDidChangeState.fire();
await this._storeState();
this._metricsService.capture('Set MCP Server States', { newStates }); this._metricsService.capture('Set MCP Server States', { newStates });
} }