Elgato_dark/void
1
0
Fork 0
mirror of https://github.com/voideditor/void synced 2026-05-24 09:58:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix URI staleness bug in local storage

Browse source
This commit is contained in:
Mathew Pareles 2025-02-24 00:46:03 -08:00
parent c650091418
commit 4ebfa91a83
1 changed files with 23 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/vs/workbench/contrib/void/browser/chatThreadService.ts
View file

@ -227,12 +227,32 @@ class ChatThreadService extends Disposable implements IChatThreadService {
}
// !!! this is important for properly restoring URIs from storage
private _convertThreadDataFromStorage(threadsStr: string): ChatThreads {
return JSON.parse(threadsStr, (key, value) => {
if (value && typeof value === 'object' && value.$mid === 1) { //$mid is the MarshalledId. $mid === 1 means it is a URI
return URI.from(value);
}
return value;
});
}
private _readAllThreads(): ChatThreads {
const threadsStr = this._storageService.get(THREAD_STORAGE_KEY, StorageScope.APPLICATION)
const threads: ChatThreads = threadsStr ? JSON.parse(threadsStr) : {}
const threadsStr = this._storageService.get(THREAD_STORAGE_KEY, StorageScope.APPLICATION);
if (!threadsStr) {
return {};
}
return this._convertThreadDataFromStorage(threadsStr);
}
return threads
private _storeAllThreads(threads: ChatThreads) {
const serializedThreads = JSON.stringify(threads);
this._storageService.store(
THREAD_STORAGE_KEY,
serializedThreads,
StorageScope.APPLICATION,
StorageTarget.USER
);
}
@ -277,9 +297,6 @@ class ChatThreadService extends Disposable implements IChatThreadService {
}
private _storeAllThreads(threads: ChatThreads) {
this._storageService.store(THREAD_STORAGE_KEY, JSON.stringify(threads), StorageScope.APPLICATION, StorageTarget.USER)
}
// this should be the only place this.state = ... appears besides constructor
private _setState(state: Partial<ThreadsState>, affectsCurrent: boolean) {
@ -652,4 +669,3 @@ class ChatThreadService extends Disposable implements IChatThreadService {
}
registerSingleton(IChatThreadService, ChatThreadService, InstantiationType.Eager);