Elgato_dark/void
1
0
Fork 0
mirror of https://github.com/voideditor/void synced 2026-05-24 09:58:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

add comment

Browse source
This commit is contained in:
Andrew 2024-09-12 07:59:32 -07:00
parent 58c57e5768
commit 3f132ca9e5
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
extensions/void/src/ApprovalCodeLensProvider.ts
View file

@ -51,9 +51,7 @@ export class ApprovalCodeLensProvider implements vscode.CodeLensProvider {
constructor() {
// this acts as a useEffect. Every time text changes, clear the diffs in this editor
// TODO ideally we wouldn't clear the diffs, we would just re-draw them and update their ranges
vscode.workspace.onDidChangeTextDocument((e) => {
// TODO we need to move all the codelenses and ranges below this one up/down depending on the number of newlines added - this is a known bug
const editor = vscode.window.activeTextEditor
if (!editor)
return
@ -83,6 +81,10 @@ export class ApprovalCodeLensProvider implements vscode.CodeLensProvider {
const diffs: DiffType[] = []
for (let suggestedEdit of suggestedEdits) {
// TODO we need to account for the case when startLine > endLine (pure inserts)
if (suggestedEdit.startLine > suggestedEdit.endLine)
continue
const selectedRange = new vscode.Range(suggestedEdit.startLine, 0, suggestedEdit.endLine, Number.MAX_SAFE_INTEGER)
// if any other codelens intersects with the selection, ignore this edit
@ -126,9 +128,6 @@ export class ApprovalCodeLensProvider implements vscode.CodeLensProvider {
// 3. apply green highlighting for each (+) diff
editor.setDecorations(greenDecoration, this._diffsOfDocument[docUriStr].map(diff => diff.range))
// 4. TODO create a red placeholder for each (-) diff
// TODO...
// recompute _computedLensesOfDocument (can optimize this later)
this._computedLensesOfDocument[docUriStr] = this._diffsOfDocument[docUriStr].flatMap(diff => diff.lenses)