mirror of
https://github.com/twentyhq/twenty
synced 2026-04-21 13:37:22 +00:00
## Summary Moves the custom ESLint rules from `tools/eslint-rules` to `packages/twenty-eslint-rules` for better organization within the monorepo packages structure. ## Changes - Move `eslint-rules` from `tools/` to `packages/twenty-eslint-rules` - Use `loadWorkspaceRules` from `@nx/eslint-plugin` to load custom rules - Update all ESLint configs to use the `twenty/` rule prefix instead of `@nx/workspace-` - Update `project.json`, `jest.config.mjs` with new paths - Update `package.json` workspaces and `nx.json` cache inputs - Update Dockerfile reference ## Technical Details The custom ESLint rules are now loaded using Nx's `loadWorkspaceRules` utility which: - Handles TypeScript transpilation automatically - Allows loading workspace rules from any directory - Provides a cleaner approach than the previous `@nx/workspace-` convention ## Testing - Verified all 17 custom ESLint rules load correctly from the new location - Verified linting works on dependent packages (twenty-front, twenty-server, etc.)
46 lines
1.3 KiB
TypeScript
46 lines
1.3 KiB
TypeScript
import { ESLintUtils } from '@typescript-eslint/utils';
|
|
|
|
// NOTE: The rule will be available in ESLint configs as "@nx/workspace-useRecoilCallback-has-dependency-array"
|
|
export const RULE_NAME = 'useRecoilCallback-has-dependency-array';
|
|
|
|
export const rule = ESLintUtils.RuleCreator(() => __filename)({
|
|
name: RULE_NAME,
|
|
meta: {
|
|
type: 'problem',
|
|
docs: {
|
|
description: 'Ensure `useRecoilCallback` is used with a dependency array',
|
|
recommended: 'recommended',
|
|
},
|
|
schema: [],
|
|
messages: {
|
|
isNecessaryDependencyArray:
|
|
'Is necessary dependency array with useRecoilCallback',
|
|
},
|
|
fixable: 'code',
|
|
},
|
|
defaultOptions: [],
|
|
create: (context) => {
|
|
return {
|
|
CallExpression: (node) => {
|
|
const { callee } = node;
|
|
if (
|
|
callee.type === 'Identifier' &&
|
|
callee.name === 'useRecoilCallback'
|
|
) {
|
|
const depsArg = node.arguments;
|
|
if (depsArg.length === 1) {
|
|
context.report({
|
|
node: callee,
|
|
messageId: 'isNecessaryDependencyArray',
|
|
data: {
|
|
callee,
|
|
deps: depsArg[0],
|
|
},
|
|
fix: (fixer) => fixer.insertTextAfter(depsArg[0], ', []'),
|
|
});
|
|
}
|
|
}
|
|
},
|
|
};
|
|
},
|
|
});
|