mirror of
https://github.com/twentyhq/twenty
synced 2026-04-21 13:37:22 +00:00
c737028dd6
## Summary Moves the custom ESLint rules from `tools/eslint-rules` to `packages/twenty-eslint-rules` for better organization within the monorepo packages structure. ## Changes - Move `eslint-rules` from `tools/` to `packages/twenty-eslint-rules` - Use `loadWorkspaceRules` from `@nx/eslint-plugin` to load custom rules - Update all ESLint configs to use the `twenty/` rule prefix instead of `@nx/workspace-` - Update `project.json`, `jest.config.mjs` with new paths - Update `package.json` workspaces and `nx.json` cache inputs - Update Dockerfile reference ## Technical Details The custom ESLint rules are now loaded using Nx's `loadWorkspaceRules` utility which: - Handles TypeScript transpilation automatically - Allows loading workspace rules from any directory - Provides a cleaner approach than the previous `@nx/workspace-` convention ## Testing - Verified all 17 custom ESLint rules load correctly from the new location - Verified linting works on dependent packages (twenty-front, twenty-server, etc.)
52 lines
1.3 KiB
TypeScript
52 lines
1.3 KiB
TypeScript
import { TSESLint } from '@typescript-eslint/utils';
|
|
|
|
import { rule, RULE_NAME } from './use-getLoadable-and-getValue-to-get-atoms';
|
|
|
|
const ruleTester = new TSESLint.RuleTester({
|
|
parser: require.resolve('@typescript-eslint/parser'),
|
|
parserOptions: {
|
|
ecmaFeatures: {
|
|
jsx: true,
|
|
},
|
|
},
|
|
});
|
|
|
|
ruleTester.run(RULE_NAME, rule, {
|
|
valid: [
|
|
{
|
|
code: 'const atoms = snapshot.getLoadable(someState).getValue();',
|
|
},
|
|
{
|
|
code: 'const atoms = snapshot.getLoadable(someState(viewId)).getValue();',
|
|
},
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'const atoms = await snapshot.getPromise(someState);',
|
|
errors: [
|
|
{
|
|
messageId: 'invalidAccessorOnSnapshot',
|
|
},
|
|
],
|
|
output: 'const atoms = await snapshot.getLoadable(someState);',
|
|
},
|
|
{
|
|
code: 'const atoms = await snapshot.getPromise(someState(viewId));',
|
|
errors: [
|
|
{
|
|
messageId: 'invalidAccessorOnSnapshot',
|
|
},
|
|
],
|
|
output: 'const atoms = await snapshot.getLoadable(someState(viewId));',
|
|
},
|
|
{
|
|
code: 'const atoms = snapshot.getLoadable(someState).anotherMethod();',
|
|
errors: [
|
|
{
|
|
messageId: 'invalidWayToGetAtoms',
|
|
},
|
|
],
|
|
output: 'const atoms = snapshot.getLoadable(someState).getValue();',
|
|
},
|
|
],
|
|
});
|