mirror of
https://github.com/twentyhq/twenty
synced 2026-04-21 21:47:38 +00:00
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
205 lines
6 KiB
TypeScript
205 lines
6 KiB
TypeScript
import { defineRule } from '@oxlint/plugins';
|
|
|
|
export const RULE_NAME = 'matching-state-variable';
|
|
|
|
const VALUE_HOOKS = [
|
|
'useAtomStateValue',
|
|
'useAtomComponentStateValue',
|
|
'useAtomFamilyStateValue',
|
|
'useAtomComponentFamilyStateValue',
|
|
];
|
|
|
|
const STATE_HOOKS = [
|
|
'useAtomState',
|
|
'useAtomComponentState',
|
|
'useAtomComponentFamilyState',
|
|
];
|
|
|
|
const SETTER_HOOKS = [
|
|
'useSetAtomState',
|
|
'useSetAtomComponentState',
|
|
'useSetAtomFamilyState',
|
|
'useSetAtomComponentFamilyState',
|
|
];
|
|
|
|
const ALL_HOOKS = [...VALUE_HOOKS, ...STATE_HOOKS, ...SETTER_HOOKS];
|
|
|
|
const SUFFIX_PATTERN =
|
|
/(ComponentFamilyState|ComponentState|ScopedFamilyState|FamilyState|ScopedState|ScopedSelector|Selector|State)$/;
|
|
|
|
const getExpectedBaseName = (stateArgName: string): string =>
|
|
stateArgName.replace(SUFFIX_PATTERN, '');
|
|
|
|
const getExpectedSetterName = (baseName: string): string =>
|
|
`set${baseName.charAt(0).toUpperCase()}${baseName.slice(1)}`;
|
|
|
|
export const rule = defineRule({
|
|
meta: {
|
|
type: 'problem',
|
|
docs: {
|
|
description:
|
|
'Ensure state value and setter are named after their atom name',
|
|
},
|
|
fixable: 'code',
|
|
schema: [],
|
|
messages: {
|
|
invalidVariableName:
|
|
"Invalid usage of {{ hookName }}: the variable should be named '{{ expectedName }}' but found '{{ actualName }}'.",
|
|
invalidSetterName:
|
|
"Invalid usage of {{ hookName }}: Expected setter '{{ expectedName }}' but found '{{ actualName }}'.",
|
|
},
|
|
},
|
|
create: (context) => {
|
|
return {
|
|
VariableDeclarator: (node: any) => {
|
|
if (
|
|
node?.init?.type !== 'CallExpression' ||
|
|
node.init.callee?.type !== 'Identifier' ||
|
|
!ALL_HOOKS.includes(node.init.callee.name)
|
|
) {
|
|
return;
|
|
}
|
|
|
|
const hookName = node.init.callee.name;
|
|
|
|
const stateNameBase =
|
|
node.init.arguments[0]?.type === 'Identifier'
|
|
? node.init.arguments[0].name
|
|
: undefined;
|
|
|
|
if (!stateNameBase) {
|
|
return;
|
|
}
|
|
|
|
const expectedVariableNameBase = getExpectedBaseName(stateNameBase);
|
|
|
|
if (SETTER_HOOKS.includes(hookName)) {
|
|
if (node.id?.type === 'Identifier') {
|
|
const actualName = node.id.name;
|
|
const expectedSetterName =
|
|
getExpectedSetterName(expectedVariableNameBase);
|
|
|
|
if (actualName !== expectedSetterName) {
|
|
context.report({
|
|
node,
|
|
messageId: 'invalidSetterName',
|
|
data: {
|
|
hookName: stateNameBase,
|
|
actualName,
|
|
expectedName: expectedSetterName,
|
|
},
|
|
fix: (fixer) =>
|
|
fixer.replaceText(node.id, expectedSetterName),
|
|
});
|
|
}
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
if (VALUE_HOOKS.includes(hookName)) {
|
|
if (node.id?.type === 'Identifier') {
|
|
const actualName = node.id.name;
|
|
|
|
if (actualName !== expectedVariableNameBase) {
|
|
context.report({
|
|
node,
|
|
messageId: 'invalidVariableName',
|
|
data: {
|
|
actualName,
|
|
expectedName: expectedVariableNameBase,
|
|
hookName: stateNameBase,
|
|
callee: hookName,
|
|
},
|
|
fix: (fixer) =>
|
|
fixer.replaceText(node.id, expectedVariableNameBase),
|
|
});
|
|
}
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
if (node.id?.type === 'Identifier') {
|
|
const actualVariableName = node.id.name;
|
|
|
|
if (actualVariableName !== expectedVariableNameBase) {
|
|
context.report({
|
|
node,
|
|
messageId: 'invalidVariableName',
|
|
data: {
|
|
actualName: actualVariableName,
|
|
expectedName: expectedVariableNameBase,
|
|
hookName: stateNameBase,
|
|
callee: hookName,
|
|
},
|
|
fix: (fixer) =>
|
|
fixer.replaceText(node.id, expectedVariableNameBase),
|
|
});
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
if (node.id.type === 'ArrayPattern') {
|
|
const actualVariableName =
|
|
node.id.elements?.[0]?.type === 'Identifier'
|
|
? node.id.elements[0].name
|
|
: undefined;
|
|
|
|
if (
|
|
actualVariableName &&
|
|
actualVariableName !== expectedVariableNameBase
|
|
) {
|
|
context.report({
|
|
node,
|
|
messageId: 'invalidVariableName',
|
|
data: {
|
|
actualName: actualVariableName,
|
|
expectedName: expectedVariableNameBase,
|
|
hookName: stateNameBase,
|
|
callee: hookName,
|
|
},
|
|
fix: (fixer) => {
|
|
if (node.id.type === 'ArrayPattern') {
|
|
return fixer.replaceText(
|
|
node.id.elements[0] as any,
|
|
expectedVariableNameBase,
|
|
);
|
|
}
|
|
return null;
|
|
},
|
|
});
|
|
}
|
|
|
|
if (node.id.elements[1]?.type === 'Identifier') {
|
|
const actualSetterName = node.id.elements[1].name;
|
|
const expectedSetterName =
|
|
getExpectedSetterName(expectedVariableNameBase);
|
|
|
|
if (actualSetterName !== expectedSetterName) {
|
|
context.report({
|
|
node,
|
|
messageId: 'invalidSetterName',
|
|
data: {
|
|
hookName: stateNameBase,
|
|
actualName: actualSetterName,
|
|
expectedName: expectedSetterName,
|
|
},
|
|
fix: (fixer) => {
|
|
if (node.id.type === 'ArrayPattern') {
|
|
return fixer.replaceText(
|
|
node.id.elements[1]!,
|
|
expectedSetterName,
|
|
);
|
|
}
|
|
return null;
|
|
},
|
|
});
|
|
}
|
|
}
|
|
}
|
|
},
|
|
};
|
|
},
|
|
});
|