mirror of
https://github.com/twentyhq/twenty
synced 2026-04-21 21:47:38 +00:00
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
170 lines
3.9 KiB
TypeScript
170 lines
3.9 KiB
TypeScript
import { defineRule } from '@oxlint/plugins';
|
|
|
|
export const RULE_NAME = 'enforce-module-boundaries';
|
|
|
|
const PACKAGE_TAG_MAP: Record<string, string[]> = {
|
|
'twenty-front': ['scope:frontend'],
|
|
'twenty-server': ['scope:backend'],
|
|
'twenty-ui': ['scope:shared'],
|
|
'twenty-shared': ['scope:shared'],
|
|
'twenty-emails': ['scope:backend'],
|
|
'twenty-sdk': ['scope:sdk', 'scope:shared'],
|
|
'twenty-zapier': ['scope:zapier'],
|
|
'twenty-oxlint-rules': ['scope:shared'],
|
|
'twenty-docs': ['scope:docs'],
|
|
'twenty-website': ['scope:docs'],
|
|
'twenty-e2e-testing': ['scope:testing'],
|
|
'create-twenty-app': ['scope:create-app'],
|
|
};
|
|
|
|
const WORKSPACE_PACKAGES = Object.keys(PACKAGE_TAG_MAP);
|
|
|
|
type DepConstraint = {
|
|
sourceTag: string;
|
|
onlyDependOnLibsWithTags: string[];
|
|
};
|
|
|
|
const extractPackageFromPath = (filePath: string): string | null => {
|
|
const match = filePath.match(/packages\/([^/]+)\//);
|
|
|
|
return match ? match[1] : null;
|
|
};
|
|
|
|
const resolveImportPackage = (importSource: string): string | null => {
|
|
for (const packageName of WORKSPACE_PACKAGES) {
|
|
if (
|
|
importSource === packageName ||
|
|
importSource.startsWith(`${packageName}/`)
|
|
) {
|
|
return packageName;
|
|
}
|
|
}
|
|
|
|
if (importSource.startsWith('@/')) {
|
|
return null;
|
|
}
|
|
|
|
return null;
|
|
};
|
|
|
|
const isImportAllowed = (
|
|
sourcePackage: string,
|
|
targetPackage: string,
|
|
depConstraints: DepConstraint[],
|
|
): boolean => {
|
|
if (sourcePackage === targetPackage) {
|
|
return true;
|
|
}
|
|
|
|
const sourceTags = PACKAGE_TAG_MAP[sourcePackage] ?? [];
|
|
const targetTags = PACKAGE_TAG_MAP[targetPackage] ?? [];
|
|
|
|
for (const constraint of depConstraints) {
|
|
if (!sourceTags.includes(constraint.sourceTag)) {
|
|
continue;
|
|
}
|
|
|
|
const allowed = targetTags.some((targetTag) =>
|
|
constraint.onlyDependOnLibsWithTags.includes(targetTag),
|
|
);
|
|
|
|
if (!allowed) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
};
|
|
|
|
const checkImport = (
|
|
node: any,
|
|
context: any,
|
|
depConstraints: DepConstraint[],
|
|
) => {
|
|
const importSource = node.source?.value;
|
|
|
|
if (!importSource || typeof importSource !== 'string') {
|
|
return;
|
|
}
|
|
|
|
const targetPackage = resolveImportPackage(importSource);
|
|
|
|
if (!targetPackage) {
|
|
return;
|
|
}
|
|
|
|
const sourcePackage = extractPackageFromPath(context.filename);
|
|
|
|
if (!sourcePackage) {
|
|
return;
|
|
}
|
|
|
|
if (!isImportAllowed(sourcePackage, targetPackage, depConstraints)) {
|
|
context.report({
|
|
node,
|
|
messageId: 'moduleBoundaryViolation',
|
|
data: {
|
|
sourcePackage,
|
|
targetPackage,
|
|
importSource,
|
|
},
|
|
});
|
|
}
|
|
};
|
|
|
|
export const rule = defineRule({
|
|
meta: {
|
|
type: 'problem',
|
|
docs: {
|
|
description:
|
|
'Enforce module boundaries between packages based on scope tags',
|
|
},
|
|
schema: [
|
|
{
|
|
type: 'object',
|
|
properties: {
|
|
depConstraints: {
|
|
type: 'array',
|
|
items: {
|
|
type: 'object',
|
|
properties: {
|
|
sourceTag: { type: 'string' },
|
|
onlyDependOnLibsWithTags: {
|
|
type: 'array',
|
|
items: { type: 'string' },
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
],
|
|
messages: {
|
|
moduleBoundaryViolation:
|
|
"Package '{{ sourcePackage }}' cannot import from '{{ targetPackage }}' (import '{{ importSource }}'). Check depConstraints configuration.",
|
|
},
|
|
},
|
|
create: (context) => {
|
|
const options = (context.options as [{ depConstraints: DepConstraint[] }])?.[0];
|
|
const depConstraints = options?.depConstraints ?? [];
|
|
|
|
if (depConstraints.length === 0) {
|
|
return {};
|
|
}
|
|
|
|
return {
|
|
ImportDeclaration: (node: any) => {
|
|
checkImport(node, context, depConstraints);
|
|
},
|
|
ImportExpression: (node: any) => {
|
|
if (node.source?.type === 'Literal') {
|
|
checkImport(
|
|
{ source: node.source },
|
|
context,
|
|
depConstraints,
|
|
);
|
|
}
|
|
},
|
|
};
|
|
},
|
|
});
|