mirror of
https://github.com/facebook/rocksdb
synced 2026-05-24 09:29:21 +00:00
4f5a687254
Summary: This pull request solves the jlong overflow problem on 32-Bit machines as described in https://github.com/facebook/rocksdb/issues/278: 1. There is a new org.rocksdb.test.PlatformRandomHelper to assist in getting random values. For 32 Bit the getLong method is overriden by xpromaches code above. For 64 Bit it behaves as is. 2. The detection should be cross-platform (Windows is supported though it is not ported completely yet). 3. Every JNI method which sets jlong values must check if the value fits into size_t. If it overflows size_t a InvalidArgument Status object will be returned. If its ok a OK Status will be returned. 4. Setters which have this check will throw a RocksDBException if its no OK Status. Additionally some other parts of code were corrected using the wrong type casts. Test Plan: make rocksdbjava make jtest Differential Revision: https://reviews.facebook.net/D24531
28 lines
1.1 KiB
Java
28 lines
1.1 KiB
Java
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
package org.rocksdb;
|
|
|
|
/**
|
|
* MemTableConfig is used to config the internal mem-table of a RocksDB.
|
|
* It is required for each memtable to have one such sub-class to allow
|
|
* Java developers to use it.
|
|
*
|
|
* To make a RocksDB to use a specific MemTable format, its associated
|
|
* MemTableConfig should be properly set and passed into Options
|
|
* via Options.setMemTableFactory() and open the db using that Options.
|
|
*
|
|
* @see Options
|
|
*/
|
|
public abstract class MemTableConfig {
|
|
/**
|
|
* This function should only be called by Options.setMemTableConfig(),
|
|
* which will create a c++ shared-pointer to the c++ MemTableRepFactory
|
|
* that associated with the Java MemTableConfig.
|
|
*
|
|
* @see Options#setMemTableConfig(MemTableConfig)
|
|
*/
|
|
abstract protected long newMemTableFactoryHandle()
|
|
throws RocksDBException;
|
|
}
|