Commit graph

8 commits

Author SHA1 Message Date
Fred Amaral
9cb5a72737
fix(codereview): align reviewer references and harden lib-commons/multi-tenant agents
Propagates the 10-reviewer peer list across agent frontmatter, Position/Critical prose, shared-patterns, skill dispatchers, gate validators, and docs — resolving drift left behind when multi-tenant-reviewer and lib-commons-reviewer were added to the pool. Also fixes broken shared-pattern paths in lib-commons-reviewer and adds substantive blocker criteria to multi-tenant-reviewer plus codebase-context severity heuristic (Lerian third-rail vs external recommendation) to lib-commons-reviewer.

X-Lerian-Ref: 0x1
2026-04-18 20:18:16 -03:00
Fred Amaral
14d84dbaa0
feat(review): add multi-tenant and lib-commons agents to review cycle
docs: align all documentation with the new 10-reviewer workflow
docs(lib-commons): update skill to reflect major v5.0.2 release
chore(hooks): tune context reminder hook to reduce token consumption
2026-04-18 19:32:16 -03:00
Fred Amaral
33c9e97d03
fix(codereview): complete cache-first standards injection end-to-end
The cache-first feature injected <standards> blocks into 5 reviewer dispatch prompts, but only performance-reviewer parsed them — code, business-logic, security, and test reviewers ignored the injection and re-fetched standards on every run. The orchestrator-side half shipped without the consumer-side half.

Each of the 4 default reviewer agents now has a Standards Loading (Cache-First) section implementing the canonical three-tier resolution: cache hit from state.cached_standards, cache miss via WebFetch with warning, standalone fallback to hardcoded URLs. The per-reviewer fallback URL lists are unique and derived from each reviewer's standards_slice.

The 5-way verbatim duplication of the dispatch block in codereview/SKILL.md is collapsed to per-reviewer URL-slice markers that reference shared-patterns/standards-cache-protocol.md as the single source of truth. The shared pattern now carries the canonical <standards> template, orchestrator pseudocode, three-tier protocol, rolling-standards policy, and an anti-rationalization table defending cache-first behavior. Net 117-line reduction in codereview/SKILL.md.

X-Lerian-Ref: 0x1
2026-04-18 10:44:17 -03:00
Fred Amaral
a074c2c614
feat(codereview): cache-first standards injection for 5 reviewers
Orchestrator resolves standards content from state.cached_standards at dispatch time and injects <standards> block with per-reviewer URL slices into code-reviewer, business-logic-reviewer, security-reviewer, test-reviewer, performance-reviewer. Each <standard> carries its URL + <content>; reviewer reads content if present, WebFetches URL if content empty. Preserves rolling-standards architecture — URLs still point to main branch, WebFetch remains the source of truth for standalone dispatch and cache misses.

Expands standards coverage to business-logic-reviewer (domain + domain-modeling + api-patterns) and test-reviewer (quality + testing-*.md) which previously received none — explicit rules beat implicit. performance-reviewer agent neutralizes its hardcoded <fetch_required> block in favor of three-tier resolution (injected block → per-standard WebFetch → standalone fallback URL list). dev-cycle Step 1.5 pre-cache extended with golang/architecture.md and golang/domain-modeling.md so all reviewer slice URLs are cacheable.

X-Lerian-Ref: 0x1
2026-04-17 22:26:06 -03:00
Fred Amaral
f862c50a56
feat(dev-cycle): reclassify gate cadence for ~40-50% speedup
Reclassify gates 1,2,4,5,6w,7w,8 (backend) and 1,2,4,5,6,7 (frontend) from subtask to task cadence. Gates 0, 3, 9 remain subtask-level. All 8 reviewers still run, all quality thresholds preserved.

Additional changes: standards pre-cache at Step 1.5 (cached_standards in state); Gate 0.5 merged into Gate 0 exit criteria via ring:dev-implementation Step 7; dev-report aggregates cycle-wide via accumulated_metrics (single cycle-end dispatch); dev-refactor clusters findings by (file, pattern_category) with findings:[] traceability array; read-after-write state verification removed; per-subtask visual reports opt-in only. State schema v1.1.0 (additive - backward compatible).

New shared patterns: standards-cache-protocol.md, gate-cadence-classification.md.

X-Lerian-Ref: 0x1
2026-04-17 21:25:17 -03:00
Fred Amaral
5a7d9e517f
fix(codereview): restore complete 8-reviewer verdict table in escalation output
Step 9 (Escalate - Max Iterations Reached) was listing only 3 of 8 reviewers in the Reviewer Verdicts table, while the Step 8 success path and the final execution report template already listed all 8. Users hitting max-iteration escalation now see the complete verdict report including test, nil-safety, consequences, dead-code, and performance-reviewer.

X-Lerian-Ref: 0x1
Generated-by: Claude
AI-Model: claude-opus-4-7
2026-04-16 15:09:28 -03:00
Fred Amaral
2712c23e2d
docs: sync plugin counts and add performance-reviewer as 8th codereview reviewer
Sweep all documentation to match filesystem ground truth:
- ring-default: 22→23 skills (added pr-review-multi-source)
- ring-dev-team: 31→33 skills (added dev-licensing, dev-verify-code), 12→13 agents (added performance-reviewer)
- ring-pm-team: 15→16 skills (added deep-doc-review)
- Total: 90→94 skills, 38→39 agents

Add ring:performance-reviewer as 8th parallel codereview reviewer across
codereview SKILL.md (dispatch block, state, metrics, verdicts, anti-rationalization)
and all documentation (CLAUDE.md, README.md, MANUAL.md, ARCHITECTURE.md).

Fix ARCHITECTURE.md finops/tw-team skill count swap in ASCII diagram.
Fix codereview metrics bug (X/6→X/8).
Remove phantom skill references (verification-before-completion, root-cause-tracing) from MANUAL.md.

X-Lerian-Ref: 0x1
2026-04-14 13:31:29 -03:00
Fred Amaral
c142c3d720
refactor(skills): remove commands layer and rename skills to match command names
Skills are now the sole invocation mechanism — commands have been eliminated
as an architectural layer. All 33 commands removed, 22 skills renamed to
match the command names teams already knew, and 1 new skill (portfolio-review)
created to replace the last orchestrator command.

Renames: brainstorming→brainstorm, requesting-code-review→codereview,
git-commit→commit, session-handoff→create-handoff, drawing-diagrams→diagram,
executing-plans→execute-plan, exploring-codebase→explore-codebase,
interviewing-user→interview-me, linting-codebase→lint,
release-guide-info→release-guide, visual-explainer→visualize,
using-git-worktrees→worktree, writing-plans→write-plan,
dev-feedback-loop→dev-report, delivery-status-tracking→delivery-status,
delivery-reporting→delivery-report, executive-reporting→executive-summary,
dependency-mapping→dependency-analysis, documentation-review→review-docs,
writing-functional-docs→write-guide, writing-api-docs→write-api

Generated-by: Claude
AI-Model: claude-opus-4-6
2026-04-12 10:14:20 -03:00
Renamed from default/skills/requesting-code-review/SKILL.md (Browse further)