Commit graph

10 commits

Author SHA1 Message Date
Fred Amaral
9cb5a72737
fix(codereview): align reviewer references and harden lib-commons/multi-tenant agents
Propagates the 10-reviewer peer list across agent frontmatter, Position/Critical prose, shared-patterns, skill dispatchers, gate validators, and docs — resolving drift left behind when multi-tenant-reviewer and lib-commons-reviewer were added to the pool. Also fixes broken shared-pattern paths in lib-commons-reviewer and adds substantive blocker criteria to multi-tenant-reviewer plus codebase-context severity heuristic (Lerian third-rail vs external recommendation) to lib-commons-reviewer.

X-Lerian-Ref: 0x1
2026-04-18 20:18:16 -03:00
Jefferson Rodrigues
3ce37e53e0
fix(install-symlinks): replace process substitution with pipe for bash 3.2 compat
macOS ships bash 3.2 which cannot parse <(...) process substitution nested inside $(...) command substitution. Use pipe with stdin (-) instead.

X-Lerian-Ref: 0x1
2026-04-16 06:12:14 -03:00
Gandalf
9c979097ad
fix(install-symlinks): graceful error on malformed hooks.json
Wrap initial settings.json creation in jq error check to match
the error handling pattern used in the merge path. Prevents set -e
crash on malformed hooks.json.

Requested-by: @jeff-music-city
2026-04-16 00:28:50 -03:00
Gandalf
2119b0acd4
feat(install-symlinks): add hook support (scripts + settings.json merge)
The symlinks installer now handles hooks alongside agents, commands,
and skills — making it a complete alternative to the marketplace
plugin installer.

What it does:
- Symlinks .sh hook scripts to ~/.claude/hooks/ (or ~/.factory/hooks/)
- Reads each plugin's hooks.json, rewrites ${CLAUDE_PLUGIN_ROOT}
  paths to ~/.claude/hooks/ (absolute, no plugin dependency), and
  deep-merges into ~/.claude/settings.json with deduplication
- --remove cleans both symlinks and hook entries from settings.json

This means the gate progression validator (and all other hooks) work
without installing Ring as a Claude Code plugin.

Tested:
- Fresh install: hooks dir created, settings.json merged (6 plugins)
- Idempotency: re-run produces identical settings.json (md5 match)
- Gate validator: deny on invalid progression, allow on valid
- Recovery instructions: task title + resume point + per-gate steps
- Remove: symlinks deleted + settings.json cleaned
- Non-cycle files: pass through unblocked

Requested-by: @jeff-music-city
2026-04-16 00:21:33 -03:00
Fred Amaral
600a505c9a
docs: propagate performance-reviewer as 8th codereview agent across all downstream references
Update all skills, agents, shared patterns, docs, and platform configs that still referenced 7 code review agents to reflect the 8th reviewer (ring:performance-reviewer). Includes agent self-descriptions, dispatch instructions, anti-rationalization tables, slicing math, gate tables, and opencode schema definitions.

X-Lerian-Ref: 0x1
2026-04-14 15:53:45 -03:00
Fred Amaral
c1d4fe6d45
feat(review): add dead-code-reviewer agent for orphan detection
Introduces a new parallel reviewer, `ring:dead-code-reviewer`, to
systematically identify orphaned code resulting from changes. This
enhances codebase hygiene by detecting unused helpers, types, and
tests, thereby reducing technical debt and improving maintainability.

The parallel code review system is expanded from 6 to 7 concurrent
reviewers. All related workflows, skills, commands, and documentation
have been updated to integrate this new capability.

- Add the `ring:dead-code-reviewer` agent, which analyzes code across
 three concentric rings (target, direct dependents, ripple effect) to
 find unreachable code.
- Update the `/ring:codereview` command and `ring:requesting-code-review`
 skill to dispatch all 7 reviewers in a single parallel step.
- Adjust project documentation, including architecture diagrams, manuals,
 and agent guides, to reflect the 7-reviewer workflow.
2026-03-09 21:17:22 -03:00
Fred Amaral
030878067c
refactor: replace codereview binaries and overhaul diff visualization
The codereview pre-analysis pipeline is refactored to use 'mithril',
an external tool installed via 'go install'. The previous system of
pre-built, in-repo binaries with its custom build workflow and
checksum verification is removed. This change simplifies maintenance
and improves security by leveraging the Go ecosystem's checksum DB.

The visual-explainer skill is refactored to use the '@pierre/diffs'
library for rendering code diffs, replacing the hand-rolled CSS
panels. This provides a more professional and feature-rich
visualization with word-level diffs and Shiki syntax highlighting.

Finally, obsolete audit and handoff documents are removed, and a help
message in the install script is updated to be accurate.
2026-03-02 14:26:49 -03:00
Jefferson Rodrigues
239c79d5f1
fix: apply code review findings - reduce duplication and fix metadata
- architecture.md: fix section range §23-28 → §23-29
- dev-refactor/SKILL.md: fix invalid agent identifier
- install-symlinks.sh: functions now respect INSTALL_CLAUDE/INSTALL_FACTORY flags
- backend-engineer-golang.md: replace detailed tables with concise reference
- qa-analyst.md: replace long section with concise reference
- dev-goroutine-leak-testing/SKILL.md: add frontmatter metadata, change 'No write access' to WARN
- dev-unit-testing/SKILL.md: simplify Step 3.5 with shared pattern references

X-Lerian-Ref: 0x1
2026-02-28 00:38:45 -03:00
Jefferson Rodrigues
c47d76f253
feat(install): add Factory AI support to install-symlinks.sh
Adds --factory and --all flags to install symlinks for Factory AI in addition to Claude Code.

X-Lerian-Ref: 0x1
2026-02-28 00:19:14 -03:00
Jefferson Rodrigues
c3def54601
feat: add Claude Code symlinks installer script
Adds install-symlinks.sh that creates symlinks from ~/.claude/{agents,commands,skills} to the Ring repo, enabling all Ring components in Claude Code. Supports auto-detection of repo path, explicit path argument, and --remove flag to clean up symlinks. Skips shared-patterns directories and only removes symlinks pointing to Ring.

X-Lerian-Ref: 0x1
2026-02-20 16:18:13 -03:00