Elgato_dark/ring
1
0
Fork 0
mirror of https://github.com/LerianStudio/ring synced 2026-04-21 13:37:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

docs: add multi-tenant and lib-commons reviewers to dev cycle

Browse source 
Increases the number of parallel reviewers from 8 to 10 for both the
frontend and backend development workflows.

This change introduces two new specialized reviewer roles:
- `multi-tenant-reviewer`
- `lib-commons-reviewer`

The "Post-cycle: Multi-Tenant" step is removed from the backend
workflow. This integrates the multi-tenancy check directly into the
main review process, ensuring it is considered from the beginning
rather than as a final adaptation step. This shift-left approach aims
to catch architectural issues earlier in the development cycle.
This commit is contained in:
Fred Amaral 2026-04-18 19:34:40 -03:00
parent 69981fc02f
commit cf3c9a0d7f
No known key found for this signature in database
GPG key ID: ADFE56C96F4AC56A
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dev-team/skills/using-dev-team/SKILL.md
View file

@ -340,7 +340,7 @@ All workflows converge to the 10-gate development cycle:
| **5: Property Testing** | Property-based tests for invariants | `ring:qa-analyst` |
| **6: Integration Testing** | Integration tests (write per unit, execute at end) | `ring:qa-analyst` |
| **7: Chaos Testing** | Chaos tests (write per unit, execute at end) | `ring:qa-analyst` |
| **8: Review** | 8 reviewers IN PARALLEL | `ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`, `ring:test-reviewer`, `ring:nil-safety-reviewer`, `ring:consequences-reviewer`, `ring:dead-code-reviewer`, `ring:performance-reviewer` |
| **8: Review** | 10 reviewers IN PARALLEL | `ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`, `ring:test-reviewer`, `ring:nil-safety-reviewer`, `ring:consequences-reviewer`, `ring:dead-code-reviewer`, `ring:performance-reviewer`, `ring:multi-tenant-reviewer`, `ring:lib-commons-reviewer` |
| **9: Validation** | User approval: APPROVED/REJECTED | User decision |
| **Post-cycle: Multi-Tenant** | Adapt all code for multi-tenant | `ring:backend-engineer-golang` (via `ring:dev-multi-tenant`) |
@ -364,7 +364,7 @@ All workflows converge to the 10-gate development cycle:
| **4: Visual Testing** | Snapshots, states, responsive | `ring:qa-analyst-frontend` |
| **5: E2E Testing** | Playwright, cross-browser, user flows| `ring:qa-analyst-frontend` |
| **6: Performance** | Core Web Vitals, Lighthouse > 90 | `ring:qa-analyst-frontend` |
| **7: Review** | 8 reviewers IN PARALLEL | `ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`, `ring:test-reviewer`, `ring:nil-safety-reviewer`, `ring:consequences-reviewer`, `ring:dead-code-reviewer`, `ring:performance-reviewer` |
| **7: Review** | 10 reviewers IN PARALLEL | `ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`, `ring:test-reviewer`, `ring:nil-safety-reviewer`, `ring:consequences-reviewer`, `ring:dead-code-reviewer`, `ring:performance-reviewer`, `ring:multi-tenant-reviewer`, `ring:lib-commons-reviewer` |
| **8: Validation** | User approval: APPROVED/REJECTED | User decision |
**Backend → Frontend Handoff:**