mirror of
https://github.com/theupdateframework/python-tuf
synced 2026-05-24 10:08:28 +00:00
7dbb30ae10
Since #885 the tests in TestUpdater and TestKeyRevocation fail on Appveyor Python 2.7 builds. After some live debugging, it turns out that the tests fail due to the extra amount of http requests to the simple http server (see tests/simple_server.py) that were added in #885. The simple server runs in a subprocess and is re-used for the entire TestCase. After a certain amount of requests it becomes unresponsive. Note that neither the subprocess exits (ps -W), nor does the port get closed (netstat -a). It just doesn't serve the request, making it time out and fail the test. The following script can be used to reproduce the issue (run in tests directory): ```python import subprocess import requests import random counter = 0 port = random.randint(30000, 45000) command = ['python', 'simple_server.py', str(port)] server_process = subprocess.Popen(command, stderr=subprocess.PIPE) url = 'http://localhost:'+str(port) + '/' sess = requests.Session() try: while True: sess.get(url, timeout=3) counter +=1 finally: print(counter) server_process.kill() ``` It fails repeatedly on the 69th request, but only if `stderr=subprocess.PIPE` is passed to Popen. Given that for each request the simple server writes about ~60 characters to stderr, e.g. ... ``` 127.0.0.1 - - [24/Feb/2020 12:01:23] "GET / HTTP/1.1" 200 - ``` ... it looks a lot like a full pipe buffer of size 4096. Note that the `bufsize` argument to Popen does not change anything. As a simple work around we silence the test server on Windows/Python2 to not fill the buffer. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
78 lines
2 KiB
Python
Executable file
78 lines
2 KiB
Python
Executable file
#!/usr/bin/env python
|
|
|
|
# Copyright 2012 - 2017, New York University and the TUF contributors
|
|
# SPDX-License-Identifier: MIT OR Apache-2.0
|
|
|
|
"""
|
|
<Program>
|
|
simple_server.py
|
|
|
|
<Author>
|
|
Konstantin Andrianov.
|
|
|
|
<Started>
|
|
February 15, 2012.
|
|
|
|
<Copyright>
|
|
See LICENSE-MIT or LICENSE for licensing information.
|
|
|
|
<Purpose>
|
|
This is a basic server that was designed to be used in conjunction with
|
|
test_download.py to test download.py module.
|
|
|
|
<Reference>
|
|
SimpleHTTPServer:
|
|
http://docs.python.org/library/simplehttpserver.html#module-SimpleHTTPServer
|
|
"""
|
|
|
|
# Help with Python 3 compatibility, where the print statement is a function, an
|
|
# implicit relative import is invalid, and the '/' operator performs true
|
|
# division. Example: print 'hello world' raises a 'SyntaxError' exception.
|
|
from __future__ import print_function
|
|
from __future__ import absolute_import
|
|
from __future__ import division
|
|
from __future__ import unicode_literals
|
|
|
|
import sys
|
|
import random
|
|
import platform
|
|
|
|
import six
|
|
from six.moves.SimpleHTTPServer import SimpleHTTPRequestHandler
|
|
|
|
PORT = 0
|
|
|
|
def _port_gen():
|
|
return random.randint(30000, 45000)
|
|
|
|
if len(sys.argv) > 1:
|
|
try:
|
|
PORT = int(sys.argv[1])
|
|
if PORT < 30000 or PORT > 45000:
|
|
raise ValueError
|
|
|
|
except ValueError:
|
|
PORT = _port_gen()
|
|
|
|
else:
|
|
PORT = _port_gen()
|
|
|
|
|
|
class QuietHTTPRequestHandler(SimpleHTTPRequestHandler):
|
|
"""A SimpleHTTPRequestHandler that does not write incoming requests to
|
|
stderr. """
|
|
def log_request(self, code='-', size='-'):
|
|
pass
|
|
|
|
# NOTE: On Windows/Python2 tests that use this simple_server.py in a
|
|
# subprocesses hang after a certain amount of requests (~68), if a PIPE is
|
|
# passed as Popen's stderr argument. As a simple workaround we silence the
|
|
# server on those Windows/Py2 to not fill the buffer.
|
|
if six.PY2 and platform.system() == 'Windows':
|
|
handler = QuietHTTPRequestHandler
|
|
else:
|
|
handler = SimpleHTTPRequestHandler
|
|
|
|
httpd = six.moves.socketserver.TCPServer(('', PORT), handler)
|
|
|
|
httpd.serve_forever()
|