Commit graph

304 commits

Author SHA1 Message Date
Vladimir Diaz
7fb6b17fec
Add comment for loop that verifies required local dirs
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-12 14:25:33 -05:00
Vladimir Diaz
08b2a9e3ac
Remove 'self.map_file = {}'
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-12 14:17:27 -05:00
Vladimir Diaz
4fdf9840ca
Resolve Pylint warning for bare-except
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-11 15:08:24 -05:00
Vladimir Diaz
d01b45131f
Resolve merge conflicts
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-11 14:22:13 -05:00
Vladimir Diaz
65a9a7c267
Resolve conflicts
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-11 13:24:19 -05:00
Vladimir Diaz
ec95a0d30f
Resolve conflicts
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:53:57 -05:00
Vladimir Diaz
ede35184f0
Remove obsolete comment about not refreshing metadata 2017-12-08 16:32:53 -05:00
Vladimir Diaz
ff0d221796
Fix stale metadata bug, and improve comments + log messages
Retrieving updater objects after consulting the map file did not guarantee fresh metadata.  This fix makes it so that an updater.refresh() is issued after each updater object is retrieved.
2017-12-08 16:32:53 -05:00
Vladimir Diaz
ba0644abc9
Fix the mapping schema and a few comments
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:32:45 -05:00
Vladimir Diaz
f5174f2b9b
Add docstring to get_updater() and minor edits to for loops
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:32:41 -05:00
Vladimir Diaz
49b5377d17
Fix more bugs in MultiRepoUpdater
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:32:26 -05:00
Vladimir Diaz
15d29db299
Fix bug where terminating attribute of intermediate mappings was not checked
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:32:18 -05:00
Vladimir Diaz
c9d9c721c0
Raise an exception if no target is found via the map file
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:32:10 -05:00
Vladimir Diaz
26b92473b4
Remove print statements from updater.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:32:01 -05:00
Vladimir Diaz
2e0f84c486
Add test conditions and edit updater.py comments
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>

* Test for missing local repository directories and Root file.
* Simplify comments
* Remove testing code"
2017-12-08 16:31:57 -05:00
Vladimir Diaz
8e0b2e02c0
Catch IOError when trying to load invalid JSON
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:31:33 -05:00
Vladimir Diaz
d7e8754331
Fix parameter name and mapping schema
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:31:21 -05:00
Vladimir Diaz
b75fcba618
Verify that the mapping attribute contains the required fields
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:31:02 -05:00
Vladimir Diaz
3207337578
Ensure a threshold of matching targetinfo
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:30:55 -05:00
Vladimir Diaz
937f737071
Add 'threshold' attribute to comments and fix line lengths
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:30:49 -05:00
Vladimir Diaz
56aa0e8aca
Fix remaining test cases for MultiRepoUpdater
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:30:34 -05:00
Vladimir Diaz
38dada8a29
Add more of implementation for MultiRepoUpdater
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:27:26 -05:00
Vladimir Diaz
b38858b0c9
Minor edits to MultiRepoUpdater and map.json
Incorrect variable names, expand comments, etc.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:26:54 -05:00
Vladimir Diaz
7be12321c6
Implement MultiRepoUpdater
TODO: Unit testing still remains

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:26:12 -05:00
Vladimir Diaz
c02edd8e70
Hit remaining lines in updater.py 2017-12-08 16:23:19 -05:00
Vladimir Diaz
479c4381e1
Refactor _visit_child_role, remove obsolete test conditions, and improve coverage 2017-12-08 16:23:19 -05:00
Vladimir Diaz
8eaef81689
Fix exception name 2017-12-08 16:23:19 -05:00
Vladimir Diaz
9564732f5e
Test condition for unequal path hash prefixes
Test condition verifies that unequal path hash prefixes are ignored by _visit_child_role()
2017-12-08 16:23:18 -05:00
Vladimir Diaz
2d19450f72
Add test condition for cycles in preorder_depth_first_walk()
This was a particularly time-consuming test to implement/debug.  Glad that's over
2017-12-08 16:23:18 -05:00
Vladimir Diaz
3fae83a789
Provide better error message for invalid spec_version 2017-12-08 16:23:18 -05:00
Vladimir Diaz
997b267184
Remove print statements in updater.py 2017-12-08 16:23:17 -05:00
Vladimir Diaz
95ff6f6d17
Test _visit_child_roles 2017-12-08 16:23:16 -05:00
Vladimir Diaz
31214e41ed
Minor edits to updater.py following addition of test conditions
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-12-08 16:22:38 -05:00
Vladimir Diaz
5179ef3a27
Log debug message in _targets_of_role() 2017-12-08 16:18:48 -05:00
Vladimir Diaz
ccbaf14a2d
Edit parameter used in _verify_root_chain_link() 2017-12-08 16:18:48 -05:00
Vladimir Diaz
3894bc4e31
Add copyright and license info to module files
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-30 13:23:38 -05:00
Vladimir Diaz
d098b73f19
Resolve remaining Pylint warnings for updater.py
* Refactor _verify_root_chain_link and avoid use of 'next' name.
* Avoid overriding variable name defined in outer loop.
* Avoid use of format() in error message.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-27 13:41:22 -05:00
Vladimir Diaz
4a44344113
Resolve unused constant in updater.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:24 -05:00
Vladimir Diaz
34212af9a3
Fix Python 3 failures
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 13:38:47 -05:00
Vladimir Diaz
0380a3ea8b
Fix issues identified by Bandit
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 17:37:40 -05:00
Vladimir Diaz
bb8729487d
Resolve Pylint's identified [E]rrors in the codebase
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:34:34 -05:00
Vladimir Diaz
4126fc8945
Merge branch 'tap4' of github.com:theupdateframework/tuf into tap4 2017-10-13 12:29:16 -04:00
Vladimir Diaz
baa4da9ca6
Hit remaining lines in updater.py 2017-09-06 17:30:29 -04:00
Vladimir Diaz
bcabe0072b
Refactor _visit_child_role, remove obsolete test conditions, and improve coverage 2017-09-06 16:54:13 -04:00
Vladimir Diaz
63b4d73cbd
Fix exception name 2017-08-31 17:14:52 -04:00
Vladimir Diaz
3ea1c48904
Test condition for unequal path hash prefixes
Test condition verifies that unequal path hash prefixes are ignored by _visit_child_role()
2017-08-31 13:43:47 -04:00
Vladimir Diaz
e1ba30ae6f
Add test condition for cycles in preorder_depth_first_walk()
This was a particularly time-consuming test to implement/debug.  Glad that's over
2017-08-30 17:16:54 -04:00
Vladimir Diaz
144ab88455
Provide better error message for invalid spec_version 2017-08-29 15:40:22 -04:00
Vladimir Diaz
72fdbc53ea
Resolve merge conflicts 2017-08-29 12:14:00 -04:00
Vladimir Diaz
313169da1a
Fix typo in code that checks for expected major version number 2017-08-28 16:57:52 -04:00