Vladimir Diaz
d098b73f19
Resolve remaining Pylint warnings for updater.py
...
* Refactor _verify_root_chain_link and avoid use of 'next' name.
* Avoid overriding variable name defined in outer loop.
* Avoid use of format() in error message.
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-27 13:41:22 -05:00
Vladimir Diaz
b23d3000c2
Merge branch 'develop' into pylint
2017-11-27 11:39:25 -05:00
Vladimir Diaz
8da3857551
Edit unit test for developer_tool after changes
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-27 11:38:49 -05:00
Vladimir Diaz
6f7ba76b9b
Resolve many Pylint warnings for developer_tool
...
* Remove unused import statements
* Add wrapper for interface functions
* Remove unused variables
* Fix incorrect number of arguments to modified function
* Convert non-public attributes
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-27 11:37:46 -05:00
Vladimir Diaz
7b5424b538
Add _remove_invalid_and_duplicate_signatures
...
to pylintrc's exclude-protected setting.
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-27 11:32:08 -05:00
Vladimir Diaz
1606b593e9
Merge pull request #539 from vladimir-v-diaz/pylint
...
Pylint
2017-11-20 14:23:04 -05:00
Vladimir Diaz
c33eb99679
Move invocation of Pylint to after_success
...
We temporarily run Pylint after the successful build to prevent the expected Pylint failure. Invocation of Pylint currently returns '4' because not all warnings are resolved (approximately 36 warnings out of 8653 lines of code).
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:31 -05:00
Vladimir Diaz
cb56d7efd8
Fix wrapper functions repository_tool.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:30 -05:00
Vladimir Diaz
e814345179
Minor cosmetic edit of test_repository_tool.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:29 -05:00
Vladimir Diaz
5a71ba7d68
Resolve unused and junk variables in developer_tool.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:28 -05:00
Vladimir Diaz
48ad359306
Resolve remaining warnings in exceptions
...
* Make sure to call base class's __init__()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:27 -05:00
Vladimir Diaz
756e86801d
Disable broad-except warnings
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:26 -05:00
Vladimir Diaz
974b259c2d
Remove/rename unused variables in repository_lib.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:25 -05:00
Vladimir Diaz
4a44344113
Resolve unused constant in updater.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:24 -05:00
Vladimir Diaz
082b8bda74
Remove unused CertificateError import
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:24 -05:00
Vladimir Diaz
49bbf577b0
Resolve remaining Pylint warnings in formats.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:23 -05:00
Vladimir Diaz
de4cfa3e88
Resolve remaining Pylint warnings for roledb.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:22 -05:00
Vladimir Diaz
de0f2b92ed
Fix remaining linter warnings for mirrors.py
...
* Use 'junk' for unused return value
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:21 -05:00
Vladimir Diaz
93f189bdd5
Resolve remaining linter warnings for repository_tool.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:20 -05:00
Vladimir Diaz
2cb2e9d0d7
Edit the 'notes,' ignore_imports,' and 'exclude-protected'
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:19 -05:00
Vladimir Diaz
5ebc278529
Resolve pylint warnings in repository_lib.py
...
* Use junk for expectedly unused variables
* Fix indentation inconsistencies
* Remove unused argument
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:18 -05:00
Vladimir Diaz
ceb50dd691
Convert variable name instances of '_' to 'junk'
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:17 -05:00
Vladimir Diaz
96f5a161f9
Allow 'junk' (like '_') to expectedly go unused in code
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:17 -05:00
Vladimir Diaz
66a03afc9c
Resolve pylint's warning for keydb.py
...
* Use idiomatic '_' for unused variable.
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:09:55 -05:00
Vladimir Diaz
d6ab5b3abb
Resolve pylint warning for sig.py
...
* Remove unused variable
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 16:02:52 -05:00
Vladimir Diaz
ae78c64226
Fix Pylint's warning's for unittest_toolbox.py
...
* Use idiomatic _ for unused variables
* Do not import the unused sys module
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 15:58:34 -05:00
Vladimir Diaz
2d56589769
Re-enable a few message ids
...
* old-python3-import
* backtick
* old-raise-syntax
* deprecated-string-function
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 15:29:20 -05:00
Vladimir Diaz
55cf5d717b
Remove 'I' message type from pylintrc's 'disable' entry
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 15:11:39 -05:00
Vladimir Diaz
d513555cfd
Re-enable [F]atal messages and ensure success
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 13:56:39 -05:00
Vladimir Diaz
26231810ba
Merge pull request #538 from vladimir-v-diaz/bandit
...
Add security linter to Travis CI configuration
2017-11-17 13:50:09 -05:00
Vladimir Diaz
34212af9a3
Fix Python 3 failures
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 13:38:47 -05:00
Vladimir Diaz
9a6b4b95cc
Fix typos: 'tuf.exception' and 'PROTOCOL_SSLv23'
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 13:15:07 -05:00
Vladimir Diaz
f0c1fcd684
Add Bandit to .travis.yml
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-17 13:14:28 -05:00
Vladimir Diaz
0380a3ea8b
Fix issues identified by Bandit
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 17:37:40 -05:00
Vladimir Diaz
d86ce22cae
Merge pull request #537 from vladimir-v-diaz/remove_interposition
...
Remove interposition and obsolete check_crypto_libraries entry
2017-11-16 13:19:07 -05:00
Vladimir Diaz
94f10e6c12
Remove test_interpose_updater.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 13:08:45 -05:00
Vladimir Diaz
f0aa76aeaf
Remove interposition
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 12:37:28 -05:00
Vladimir Diaz
a0852f6965
Remove 'check_crypto_libraries' from list of excluded coverage
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 12:32:18 -05:00
Vladimir Diaz
9bda4ba75b
Merge pull request #536 from vladimir-v-diaz/remove_tufcli
...
Remove tufcli.py
2017-11-16 12:30:19 -05:00
Vladimir Diaz
c7036a9d08
Remove interposition from list of excluded coverage
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 12:28:21 -05:00
Vladimir Diaz
32b5b92444
Remove tufcli.py from the list of omitted coverage
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 12:07:16 -05:00
Vladimir Diaz
664e8227d9
Exclude the now remove tufcli.py from setup.py's scripts
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 12:05:35 -05:00
Vladimir Diaz
d781f03e85
Remove tufcli.py
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-16 12:04:10 -05:00
Vladimir Diaz
a1d96f5233
Merge pull request #535 from vladimir-v-diaz/pylint
...
Add static code anaysis to Travis CI
2017-11-15 17:44:11 -05:00
Vladimir Diaz
2c78dcb767
Install pylint in .travis.yml
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:53:42 -05:00
Vladimir Diaz
1aee7e7de9
Add 'pylint' branch to .travis.yml for testing purposes
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:39:03 -05:00
Vladimir Diaz
bb8729487d
Resolve Pylint's identified [E]rrors in the codebase
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:34:34 -05:00
Vladimir Diaz
3a972c7bbe
Add Pylint dependency to CI and dev requirement files
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:29:49 -05:00
Vladimir Diaz
779eade079
Run Pylint in Travis CI
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:28:02 -05:00
Vladimir Diaz
35e6c4fc8a
Add Pylint configuration file
...
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-15 16:24:20 -05:00