Commit graph

202 commits

Author SHA1 Message Date
Sebastien Awwad
85c9c3aeee
Have repository_tool.get_filepaths_in_directory use absolute paths
as its docstring says that it does. I'm not sure if this changed through
some accident along the way, but in any case, before this commit, the
docstring said that it yielded a list of absolute paths, but it did not.

Now it does.

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
2018-08-20 13:29:09 -04:00
Vladimir Diaz
9f0c495f19
Copy with list() to avoid unintentially modifying roleinfo['keyids']
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-26 12:01:04 -04:00
Vladimir Diaz
3047cdb487
Convert backward slashes in target paths given to add_target() and add_targets()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-23 11:09:10 -04:00
Vladimir Diaz
f96177bc34
Ensure consistent behavior between add_target() and add_targets()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-13 16:58:04 -04:00
Vladimir Diaz
903ff0a280
Add comment to affected modules...
explaining why locally generated keyids use the hashing algorithms specified in metadata's 'keyid_hash_algorithms' field.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-12 11:43:03 -04:00
Vladimir Diaz
9a1774bc61
Make sure the locally generated keyids match metadata's: repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-12 11:30:30 -04:00
Vladimir Diaz
dfbaba65d5
Fix Pylint warning/fix commented code
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-06 14:07:02 -04:00
Vladimir Diaz
d23f729814
Fix 'os.isFile' typo in repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-06 13:49:03 -04:00
Vladimir Diaz
fe5d335555
Modify modules to remove/expect no leading path separators
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-04-06 13:16:41 -04:00
Vladimir Diaz
994b721a7b
Ensure that the latest consistent metadata is loaded from disk
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-03-29 11:22:43 -04:00
Vladimir Diaz
ae9301b011
Write new Root file if the consistent snapshot setting as changed
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-03-16 14:30:22 -04:00
Trishank K Kuppusamy
0e65ba0766
try removing condition per @vladimir-v-diaz
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
2018-03-15 15:56:08 -04:00
Vladimir Diaz
1d46c93624
Allow 2+ role to delegate to the same role
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-03-05 16:39:44 -05:00
Vladimir Diaz
5fcec06bb0
Resolve linter warning: Correctly list exceptions
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-02-13 15:05:36 -05:00
Vladimir Diaz
8a9ed5240c
Do not throw exception if a role being removed is missing
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-02-13 14:29:43 -05:00
Vladimir Diaz
b3cc7dfeb6
Correctly delegate paths via add_paths() in repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-02-12 17:31:17 -05:00
Vladimir Diaz
442d4b592e
Do not modify the delegated paths given by user
These paths may not necessarily exist on the local environment or within the repo's targets directory

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-02-12 16:41:13 -05:00
Vladimir Diaz
8f65fa4154
Rename license files in modules
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-02-05 11:31:19 -05:00
Vladimir Diaz
6d4067184b
Fix bug in repository_tool.py
Function to import public ECDSA incorrectly called the private one.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-26 16:18:59 -05:00
Vladimir Diaz
807f654406
Set filepath=None, to support KEYID filenames
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-22 15:24:57 -05:00
Vladimir Diaz
5b64ecb6a6
Edit link for recommended RSA key lengths
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-22 12:05:37 -05:00
Vladimir Diaz
2e3bcb6058
Resolve protected-access linter violation
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-22 11:00:22 -05:00
Vladimir Diaz
06f6bd0b08
Add default values to some arguments in repository_tool.py
... so that the wrapper functions matche the ones in securesystemslib and repository_lib.py.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-19 17:15:55 -05:00
Vladimir Diaz
48c6b345df
Merge branch 'develop' into keys_ram_fix_issue#571 2018-01-19 16:44:25 -05:00
Vladimir Diaz
0e12cfa9a4
Revise a couple comments in repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-19 15:51:21 -05:00
Vladimir Diaz
019498607a
Remove 'if X is not None' instances and refactor add_paths()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-19 15:28:38 -05:00
Vladimir Diaz
81db8ebb8e
List FormatError in add_path()'s docstring
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-19 14:39:03 -05:00
Vladimir Diaz
c845c42a40
Edit indentation and whitespace throughout repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-19 11:47:18 -05:00
Vladimir Diaz
c1c0bc770d
Revise comments related to 'paths'
Clarify that 'paths' may be file paths or glob patterns.

Replace 'falls under the targets directory' with 'located in the targets directory'.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-19 11:19:33 -05:00
Vladimir Diaz
51b69898ba
Remove instance of '.json.gz' from comment
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-17 16:53:58 -05:00
Vladimir Diaz
01ba474226
Resolve linter errors and warnings
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-11 11:45:16 -05:00
Vladimir Diaz
e1c7a2134a
Add wrapper functions to import keys from PEM
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-11 11:07:52 -05:00
Vladimir Diaz
dc9d0c71e3
Add wrapper functions for SSL functions that genenerate keys
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-11 10:14:23 -05:00
Vladimir Diaz
db90cb956a
Add wrappers for the ECDSA functions from SSL
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-10 11:42:44 -05:00
Vladimir Diaz
ec158cd1d2
Create role/key db for non-default repository names
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-09 14:22:48 -05:00
Vladimir Diaz
93d1610945
Rename add_restricted_paths() -> add_paths()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-05 15:09:55 -05:00
Vladimir Diaz
4d967bb0e6
Check for non-None list of targets to delegate()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-03 17:31:35 -05:00
Vladimir Diaz
76fe0b577b
Rename restricted_paths and reorder arguments to delegate()
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-03 17:03:24 -05:00
Vladimir Diaz
7de7026efe
Do not raise excpetion for non-existent delegated paths
The paths that are delegated to another role do not have to exist on disk or fall under the repository's targets directory.  Instead of raising an exception, log a debug statement.  Revise affected comments.

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2018-01-03 15:38:38 -05:00
Vladimir Diaz
3894bc4e31
Add copyright and license info to module files
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-30 13:23:38 -05:00
Vladimir Diaz
cb56d7efd8
Fix wrapper functions repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:30 -05:00
Vladimir Diaz
93f189bdd5
Resolve remaining linter warnings for repository_tool.py
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-20 14:10:20 -05:00
Vladimir Diaz
df056cbb14
Remove obsolete call to SSL function
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
2017-11-09 10:53:40 -05:00
Vladimir Diaz
cf9db6134e
Remove obsolete compression argument in repository_tool.py 2017-08-29 15:02:51 -04:00
Vladimir Diaz
72fdbc53ea
Resolve merge conflicts 2017-08-29 12:14:00 -04:00
Vladimir Diaz
134bf073a1
Remove compression from repository tool and its unit test 2017-08-25 16:13:05 -04:00
Vladimir Diaz
853641538a
Ignore branch coverage for a particular loop in repository_tool.py
This loop doesn't need to loop through completely for coverage.
2017-08-24 13:51:38 -04:00
Vladimir Diaz
d1132b377f
Merge branch 'develop' into coverage 2017-08-23 16:05:26 -04:00
Vladimir Diaz
8db447c3a6
Incorporate changes made to crypto library 2017-08-22 15:54:48 -04:00
Vladimir Diaz
671cd1470b
Specify compression_algorithms when calling _generate_and_write_metadata() 2017-07-31 15:48:50 -04:00