From acf5bfddac64e7803ef0cc9e8d74dd0023373740 Mon Sep 17 00:00:00 2001 From: Vladimir Diaz Date: Thu, 10 Nov 2016 16:21:57 -0500 Subject: [PATCH] Add coverage for _delete_obsolete_metadata() This function was recently updated to ignore root.json (and continue). Add coverage for it now --- tests/test_repository_lib.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/test_repository_lib.py b/tests/test_repository_lib.py index c68f0c63..7fa41d50 100755 --- a/tests/test_repository_lib.py +++ b/tests/test_repository_lib.py @@ -990,8 +990,17 @@ def test__delete_obsolete_metadata(self): snapshot_signable['signed'], True) - # Verify what happens for a non-existent metadata directory (a debug message - # is logged). + # _delete_obsolete_metadata should never delete root.json. + root_filepath = os.path.join('repository_data', 'repository', + 'metadata', 'root.json') + shutil.copyfile(root_filepath, os.path.join(metadata_directory, 'root.json')) + repo_lib._delete_obsolete_metadata(metadata_directory, + snapshot_signable['signed'], + True) + self.assertTrue(os.path.exists(os.path.join(metadata_directory, 'root.json'))) + + # Verify what happens for a non-existent metadata directory (a debug + # message is logged). repo_lib._delete_obsolete_metadata('non-existent', snapshot_signable['signed'], True)