From 981788bca2df4043bc50b8fc8eedd4742d887ea0 Mon Sep 17 00:00:00 2001
From: Jussi Kukkonen <jkukkonen@google.com>
Date: Wed, 3 Apr 2024 13:44:36 +0300
Subject: [PATCH] lint: Enable flake8-pie

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
---
 pyproject.toml                | 1 +
 tests/repository_simulator.py | 2 +-
 tests/test_api.py             | 2 +-
 tuf/api/_payload.py           | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/pyproject.toml b/pyproject.toml
index 23e5c66e..0f813f1f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -94,6 +94,7 @@ select = [
     "ISC", # flake8-implicit-str-concat
     "N",   # pep8-naming
     "PL",  # pylint
+    "PIE", # flake8-pie
     "RET", # flake8-return
     "RUF", # ruff-specific rules
     "S",   # flake8-bandit
diff --git a/tests/repository_simulator.py b/tests/repository_simulator.py
index e4853f6b..5bcde187 100644
--- a/tests/repository_simulator.py
+++ b/tests/repository_simulator.py
@@ -160,7 +160,7 @@ def rotate_keys(self, role: str) -> None:
         """remove all keys for role, then add threshold of new keys"""
         self.root.roles[role].keyids.clear()
         self.signers[role].clear()
-        for _ in range(0, self.root.roles[role].threshold):
+        for _ in range(self.root.roles[role].threshold):
             signer = CryptoSigner.generate_ed25519()
             self.root.add_key(signer.public_key, role)
             self.add_signer(role, signer)
diff --git a/tests/test_api.py b/tests/test_api.py
index 1a5930e7..d2f11cf4 100755
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -1118,7 +1118,7 @@ def test_delegations_get_delegated_role(self) -> None:
         for name in ["prefix-", "prefix--1", f"prefix-{2**bit_len:0x}"]:
             with self.assertRaises(ValueError, msg=f"role name '{name}'"):
                 targets.get_delegated_role(name)
-        for i in range(0, 2**bit_len):
+        for i in range(2**bit_len):
             self.assertEqual(
                 targets.get_delegated_role(f"prefix-{i:0x}"), role2
             )
diff --git a/tuf/api/_payload.py b/tuf/api/_payload.py
index 28bae80f..dbf1a515 100644
--- a/tuf/api/_payload.py
+++ b/tuf/api/_payload.py
@@ -1286,7 +1286,7 @@ def get_role_for_target(self, target_filepath: str) -> str:
 
     def get_roles(self) -> Iterator[str]:
         """Yield the names of all different delegated roles one by one."""
-        for i in range(0, self.number_of_bins):
+        for i in range(self.number_of_bins):
             suffix = f"{i:0{self.suffix_len}x}"
             yield f"{self.name_prefix}-{suffix}"