Elgato_dark/python-tuf
1
0
Fork 0
mirror of https://github.com/theupdateframework/python-tuf synced 2026-05-24 10:08:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

verify_release: add constant 5s HTTP timeout

Browse source 
Add 5 seconds HTTP timeout constant and use it for requests to
GitHub. Setting timeout is recommended by requests docs and flagged
by latest pylint:
```
W3101: Missing timeout argument for method 'requests.get' can cause
your program to hang indefinitely (missing-timeout)
```
https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
This commit is contained in:
Lukas Puehringer 2022-08-30 09:01:16 +02:00
parent 4cb5b35a26
commit 7b9cf4ac8e
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
verify_release
View file

@ -32,6 +32,8 @@ GITHUB_ORG = "theupdateframework"
GITHUB_PROJECT = "python-tuf"
PYPI_PROJECT = "tuf"
HTTP_TIMEOUT = 5
def build(build_dir: str) -> str:
"""Build release locally. Return version as string"""
@ -66,7 +68,9 @@ def get_git_version() -> str:
def get_github_version() -> str:
"""Return version string of latest GitHub release"""
release_json = f"https://api.github.com/repos/{GITHUB_ORG}/{GITHUB_PROJECT}/releases/latest"
releases = json.loads(requests.get(release_json).content)
releases = json.loads(
requests.get(release_json, timeout=HTTP_TIMEOUT).content
)
return releases["tag_name"][1:]
@ -95,7 +99,7 @@ def verify_github_release(version: str, compare_dir: str) -> bool:
with TemporaryDirectory() as github_dir:
for filename in [tar, wheel]:
url = f"{base_url}/v{version}/{filename}"
response = requests.get(url, stream=True)
response = requests.get(url, stream=True, timeout=HTTP_TIMEOUT)
with open(os.path.join(github_dir, filename), "wb") as f:
for data in response.iter_content():
f.write(data)