From 4e889e7212f12a065e47c314940c215744d2fc93 Mon Sep 17 00:00:00 2001
From: Jussi Kukkonen <jkukkonen@google.com>
Date: Wed, 11 Dec 2024 10:01:13 +0200
Subject: [PATCH] dev env: Stop installing tuf as "editable"

This was likely only necessary because the test suite required it:
Now tuf does not get installed at all by tox (or by dev install)

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
---
 .github/workflows/specification-version-check.yml | 1 -
 requirements/dev.txt                              | 5 -----
 tox.ini                                           | 4 ----
 3 files changed, 10 deletions(-)

diff --git a/.github/workflows/specification-version-check.yml b/.github/workflows/specification-version-check.yml
index 09bb87b0..58da7968 100644
--- a/.github/workflows/specification-version-check.yml
+++ b/.github/workflows/specification-version-check.yml
@@ -20,7 +20,6 @@ jobs:
           python-version: "3.x"
       - id: get-version
         run: |
-          python3 -m pip install -e .
           script="from tuf.api.metadata import SPECIFICATION_VERSION; \
                   print(f\"v{'.'.join(SPECIFICATION_VERSION)}\")"
           ver=$(python3 -c "$script")
diff --git a/requirements/dev.txt b/requirements/dev.txt
index dae95c14..6b81f9bc 100644
--- a/requirements/dev.txt
+++ b/requirements/dev.txt
@@ -1,8 +1,3 @@
-# Install tuf in editable mode and requirements for local testing with tox,
-# and also for running test suite or individual tests manually.
-# The build and tox versions specified here are also used as constraints
-# during CI and CD Github workflows
 -r build.txt
 -r test.txt
 -r lint.txt
--e .
diff --git a/tox.ini b/tox.ini
index aa20ae1d..e10627a8 100644
--- a/tox.ini
+++ b/tox.ini
@@ -16,9 +16,6 @@ commands =
 
 deps =
     -r{toxinidir}/requirements/test.txt
-    # Install TUF in editable mode, instead of tox default virtual environment
-    # installation (see `skipsdist`), to get relative paths in coverage reports
-    --editable {toxinidir}
 
 install_command = python3 -m pip install {opts} {packages}
 
@@ -38,7 +35,6 @@ commands =
 [testenv:lint]
 deps =
     -r{toxinidir}/requirements/lint.txt
-    --editable {toxinidir}
 lint_dirs = tuf examples tests verify_release .github/scripts
 passenv = RUFF_OUTPUT_FORMAT
 commands =