Elgato_dark/python-tuf
1
0
Fork 0
mirror of https://github.com/theupdateframework/python-tuf synced 2026-05-24 10:08:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASN.1: improve _list_to_pyasn1 loop

Browse source 
setup once before the loop; no need to repeat in every iteration

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
This commit is contained in:
Sebastien Awwad 2018-10-26 12:47:02 -04:00
parent 6e16662640
commit 444d3329cb
No known key found for this signature in database
GPG key ID: BC0C6DEDD5E5CC03
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tuf/encoding/asn1_convert.py
View file

@ -571,16 +571,16 @@ def _list_to_pyasn1(data, datatype):
pyasn1_obj = datatype() # DEBUG
for i in range(0,len(data)):
datum = data[i]
if None is getattr(datatype, 'componentType', None):
# TODO: Use a better exception class, if you decide to keep this.
# It's useful in debugging because the error we get if we don't
# specifically detect this may be misleading.
raise tuf.exceptions.Error('Unable to determine type of component in a '
'list. datatype of list: ' + str(datatype) + '; componentType '
'appears to be None')
if None is getattr(datatype, 'componentType', None):
# TODO: Use a better exception class, if you decide to keep this.
# It's useful in debugging because the error we get if we don't
# specifically detect this may be misleading.
raise tuf.exceptions.Error('Unable to determine type of component in a '
'list. datatype of list: ' + str(datatype) + '; componentType '
'appears to be None')
for i in range(0, len(data)):
datum = data[i]
debug('In conversion of list to type ' + str(datatype) + ', recursing '
'to convert subcomponent of type ' + str(type(datatype.componentType)))