From 289950a17c2be2017eeafaa871085eca78f2806b Mon Sep 17 00:00:00 2001 From: Jussi Kukkonen Date: Fri, 8 Mar 2024 15:00:42 +0200 Subject: [PATCH] updater: Minor improvements to error handling In RequestsFetcher it makes sense to raise "from e" but in updater the error we raise is not related to the original error: use "from None". Signed-off-by: Jussi Kukkonen --- tuf/ngclient/_internal/requests_fetcher.py | 2 +- tuf/ngclient/updater.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tuf/ngclient/_internal/requests_fetcher.py b/tuf/ngclient/_internal/requests_fetcher.py index c39c1fb2..0923e5ce 100644 --- a/tuf/ngclient/_internal/requests_fetcher.py +++ b/tuf/ngclient/_internal/requests_fetcher.py @@ -94,7 +94,7 @@ def _fetch(self, url: str) -> Iterator[bytes]: except requests.HTTPError as e: response.close() status = e.response.status_code - raise exceptions.DownloadHTTPError(str(e), status) + raise exceptions.DownloadHTTPError(str(e), status) from e return self._chunks(response) diff --git a/tuf/ngclient/updater.py b/tuf/ngclient/updater.py index 2cfccc66..faee9d2c 100644 --- a/tuf/ngclient/updater.py +++ b/tuf/ngclient/updater.py @@ -397,7 +397,7 @@ def _load_targets(self, role: str, parent_role: str) -> Targets: if metainfo is None: raise exceptions.RepositoryError( f"Role {role} was delegated but is not part of snapshot" - ) + ) from None length = metainfo.length or self.config.targets_max_length version = None