Commit graph

13 commits

Author SHA1 Message Date
Evžen Gasta
be8f2ca568
feat: added icon examples to code guidelines (#15673)
* feat: added icon examples to code guideliens

Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>

* chore: applied suggestions

Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>

* chore: removed unused imports

Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>

---------

Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>
2026-01-27 07:21:51 +01:00
Florent Benoit
b18236595a chore: add section in coding guidelines about svelte attachments
Bring awareness of svelte attachments

fixes https://github.com/podman-desktop/podman-desktop/issues/14363
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
2026-01-06 16:21:07 +01:00
Florent BENOIT
a3cea8665d
chore: add guidelines for async usage in svelte 5 (#15458)
fixes https://github.com/podman-desktop/podman-desktop/issues/14362

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
2025-12-23 10:05:18 -05:00
Simon Rey
66e70bc090
chore(guidelines): suggest usage of vitest snapshots (#15375)
Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>
2025-12-17 16:03:01 +00:00
Philippe Martin
9a5c1423ce
docs(code-guideline): do not use code in Svelte templates (#15116)
Signed-off-by: Philippe Martin <phmartin@redhat.com>
2025-12-01 08:19:12 +01:00
Simon Rey
f503b7248e
chore(guidelines): add example difference between waitFor and waitUntil (#14992)
* chore(guidelines): add example difference between waitFor and waitUntil

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>

* chore(guidelines): specify waitFor error

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>

* chore(guidelines): apply suggestions

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>

---------

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>
2025-11-20 14:42:41 +01:00
Simon Rey
597f6c5a6d
docs(code-guidelines): add guideline for path aliases in imports (#14580)
* docs(code-guidelines): add guideline for path aliases in imports

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>

fix: to squash

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>

* chore: improve guideline

Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>

---------

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
2025-10-24 14:03:34 +00:00
Florent Benoit
b0a4306ad7 docs: add section around the usage of fake timers in rendered unit tests
fixes https://github.com/podman-desktop/podman-desktop/issues/14547
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
2025-10-23 19:14:56 +02:00
Philippe Martin
8aa321dbe0
docs: code guideline to mock a component, with bindable prop (#14249)
* docs: code guideline to mock a component, with bindable prop
Signed-off-by: Philippe Martin <phmartin@redhat.com>

* fix: typo

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Philippe Martin <feloy1@gmail.com>

---------

Signed-off-by: Philippe Martin <feloy1@gmail.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
2025-10-10 20:57:36 +02:00
axel7083
d261a52245
chore(code-guidelines): testing style attribute (#11567)
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
2025-03-07 11:24:06 +01:00
Philippe Martin
50e322bdb1
docs: queryBy vs getBy (#11446)
Signed-off-by: Philippe Martin <phmartin@redhat.com>
2025-03-03 08:57:26 +01:00
Philippe Martin
14227ba8ef
docs: code guideline to use mocks vs spies (#10541)
* docs: code guideline for mocks vs spies
Signed-off-by: Philippe Martin <phmartin@redhat.com>

* fix: restore spies individually with vi.mocked()
Signed-off-by: Philippe Martin <phmartin@redhat.com>

* docs: more realistic example
Signed-off-by: Philippe Martin <phmartin@redhat.com>

* fix: use restoreAllMocks instead
Signed-off-by: Philippe Martin <phmartin@redhat.com>
2025-01-29 10:27:24 +01:00
Philippe Martin
87cd8cada6
docs: in code guidelines, use vi.mocked (#10353)
* docs: use vi.mocked

Signed-off-by: Philippe Martin <phmartin@redhat.com>

* fix: remove unnecessary code

Signed-off-by: Philippe Martin <phmartin@redhat.com>

---------

Signed-off-by: Philippe Martin <phmartin@redhat.com>
2024-12-16 10:37:00 +01:00