From d2578291578d34a67a2c2cd8afc68aa7a14fe89a Mon Sep 17 00:00:00 2001 From: Charlie Drage Date: Wed, 19 Oct 2022 07:59:25 -0400 Subject: [PATCH] Improve wording for Kubernetes actions (#633) * Improve wording for Kubernetes actions ### What does this PR do? * Changes the wording of Kubernetes to indicate the action more * When in a title, YAML and just YAML should be used, but when referring to in a sentence it should be `.yaml` for adding a file, etc. * Changes the titles for navigation so it's not as "capitalized". (titles should not capitalize words such as "of" or "there", etc.) ### Screenshot/screencast of this PR ### What issues does this PR fix or reference? N/A ### How to test this PR? Run `yarn watch` and look at the UI :) Signed-off-by: Charlie Drage * Update based on review and change run to play Signed-off-by: Charlie Drage Signed-off-by: Charlie Drage --- packages/renderer/src/lib/ContainerList.svelte | 4 ++-- .../src/lib/container/ContainerPlayKubefile.svelte | 10 +++++----- packages/renderer/src/lib/ui/NavPage.svelte | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/renderer/src/lib/ContainerList.svelte b/packages/renderer/src/lib/ContainerList.svelte index b4e0e4149b2..d0903fe8c49 100644 --- a/packages/renderer/src/lib/ContainerList.svelte +++ b/packages/renderer/src/lib/ContainerList.svelte @@ -261,10 +261,10 @@ function toggleAllContainerGroups(value: boolean) { on:click="{() => runContainerYaml()}" class="pf-c-button pf-m-primary" type="button" - title="Run pod/containers from kubernetes .YAML file "> + title="Play pod/containers from kubernetes YAML file ">
- Play YAML + Play Kubernetes YAML
{/if} diff --git a/packages/renderer/src/lib/container/ContainerPlayKubefile.svelte b/packages/renderer/src/lib/container/ContainerPlayKubefile.svelte index 0f981f9dc37..5896dc434d2 100644 --- a/packages/renderer/src/lib/container/ContainerPlayKubefile.svelte +++ b/packages/renderer/src/lib/container/ContainerPlayKubefile.svelte @@ -72,7 +72,7 @@ onDestroy(() => { }); async function getKubernetesfileLocation() { - const result = await window.openFileDialog('Select .YAML file to play', { + const result = await window.openFileDialog('Select a .yaml file to play', { name: 'YAML files', extensions: ['yaml', 'yml'], }); @@ -88,20 +88,20 @@ async function getKubernetesfileLocation() { {/if} {#if providerConnections.length > 0} - +
Select file:
@@ -148,7 +148,7 @@ async function getKubernetesfileLocation() { {/if} - Run + Play
{/if} diff --git a/packages/renderer/src/lib/ui/NavPage.svelte b/packages/renderer/src/lib/ui/NavPage.svelte index 421a6a7982b..f1855e95992 100644 --- a/packages/renderer/src/lib/ui/NavPage.svelte +++ b/packages/renderer/src/lib/ui/NavPage.svelte @@ -9,7 +9,7 @@ export let searchEnabled: boolean = true;
-

{title}

+

{title}

{subtitle}