From 79a9644a39a1fea1f2ef65e42b4a3e17a10934ba Mon Sep 17 00:00:00 2001 From: Florent Benoit Date: Fri, 16 Jun 2023 09:06:53 +0200 Subject: [PATCH] chore: fix @typescript-eslint/no-unused-vars rule allow the usage of _ prefix to ignore the pattern Signed-off-by: Florent Benoit --- .eslintrc.json | 2 +- packages/renderer/.eslintrc.json | 1 - packages/renderer/src/App.svelte | 15 -------- .../renderer/src/PreferencesNavigation.svelte | 6 +-- .../renderer/src/lib/ContainerList.svelte | 4 -- .../src/lib/container/ContainerActions.svelte | 38 +++++++++---------- .../lib/container/ContainerDetailsLogs.svelte | 2 +- .../lib/dashboard/ProviderConfiguring.svelte | 12 +----- .../lib/dashboard/ProviderInstalled.svelte | 2 +- .../src/lib/dashboard/ProviderStarting.svelte | 2 +- .../src/lib/dashboard/ProviderWarnings.svelte | 1 - .../docker-extension/DockerExtension.svelte | 2 +- packages/renderer/src/lib/engine/Prune.svelte | 1 - .../featured/FeaturedExtensionDownload.svelte | 3 +- .../lib/featured/FeaturedExtensions.svelte | 2 +- .../src/lib/image/PushImageModal.svelte | 6 --- .../renderer/src/lib/images/StatusIcon.svelte | 1 - .../renderer/src/lib/kube/KubePlayYAML.svelte | 2 +- .../src/lib/pod/PodDetailsLogs.svelte | 2 +- packages/renderer/src/lib/pod/PodsList.svelte | 2 - ...ferencesConnectionCreationRendering.svelte | 2 +- ...erencesContainerConnectionRendering.svelte | 4 +- .../PreferencesExtensionRendering.svelte | 2 +- .../PreferencesInstallExtensionFromId.svelte | 2 +- ...rencesKubernetesConnectionRendering.svelte | 4 +- .../lib/preferences/PreferencesPage.svelte | 2 +- .../PreferencesProviderRendering.svelte | 7 +--- .../preferences/PreferencesRendering.svelte | 2 +- .../PreferencesRenderingItemFormat.svelte | 6 +-- .../PreferencesResourcesRendering.svelte | 2 +- .../src/lib/task-manager/TaskManager.svelte | 11 +----- .../lib/task-manager/TaskManagerItem.svelte | 3 +- .../renderer/src/lib/ui/EmptyScreen.svelte | 2 +- .../renderer/src/lib/ui/ErrorMessage.svelte | 2 +- .../renderer/src/lib/ui/WarningMessage.svelte | 7 +--- .../src/lib/volume/VolumeActions.svelte | 2 +- 36 files changed, 50 insertions(+), 116 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 82f05d290df..be4d5786247 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -59,7 +59,7 @@ "**/dist/**" ], "rules": { - "@typescript-eslint/no-unused-vars": "error", + "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }], "@typescript-eslint/no-var-requires": "off", "@typescript-eslint/consistent-type-imports": "error", "@typescript-eslint/no-explicit-any": "error", diff --git a/packages/renderer/.eslintrc.json b/packages/renderer/.eslintrc.json index 9c61823f6cd..c1cd04d7d0c 100644 --- a/packages/renderer/.eslintrc.json +++ b/packages/renderer/.eslintrc.json @@ -13,7 +13,6 @@ "@typescript-eslint/no-empty-function": "off", "no-undef": "off", "sonarjs/no-collapsible-if": "off", - "@typescript-eslint/no-unused-vars": "off", "@typescript-eslint/prefer-optional-chain": "off", "svelte/no-at-html-tags": "off", "no-useless-escape": "off", diff --git a/packages/renderer/src/App.svelte b/packages/renderer/src/App.svelte index 93013d3f459..3d49e6e1a8b 100644 --- a/packages/renderer/src/App.svelte +++ b/packages/renderer/src/App.svelte @@ -8,7 +8,6 @@ import { router } from 'tinro'; import Route from './Route.svelte'; import ContainerList from './lib/ContainerList.svelte'; -import { onMount } from 'svelte'; import ImagesList from './lib/ImagesList.svelte'; import ProviderList from './lib/ProviderList.svelte'; import PreferencesPage from './lib/preferences/PreferencesPage.svelte'; @@ -16,8 +15,6 @@ import BuildImageFromContainerfile from './lib/image/BuildImageFromContainerfile import PullImage from './lib/image/PullImage.svelte'; import DockerExtension from './lib/docker-extension/DockerExtension.svelte'; import ContainerDetails from './lib/container/ContainerDetails.svelte'; -import { providerInfos } from './stores/providers'; -import type { ProviderInfo } from '../../main/src/plugin/api/provider-info'; import WelcomePage from './lib/welcome/WelcomePage.svelte'; import DashboardPage from './lib/dashboard/DashboardPage.svelte'; import HelpPage from './lib/help/HelpPage.svelte'; @@ -50,18 +47,6 @@ router.subscribe(function (navigation) { } }); -let providers: ProviderInfo[] = []; -$: providerConnections = providers - .map(provider => provider.containerConnections) - .flat() - .filter(providerContainerConnection => providerContainerConnection.status === 'started'); - -onMount(() => { - providerInfos.subscribe(value => { - providers = value; - }); -}); - // eslint-disable-next-line @typescript-eslint/ban-ts-comment // @ts-ignore window.events?.receive('display-help', () => { diff --git a/packages/renderer/src/PreferencesNavigation.svelte b/packages/renderer/src/PreferencesNavigation.svelte index b022285e473..258efe3f5ed 100644 --- a/packages/renderer/src/PreferencesNavigation.svelte +++ b/packages/renderer/src/PreferencesNavigation.svelte @@ -6,9 +6,8 @@ import { CONFIGURATION_DEFAULT_SCOPE } from '../../main/src/plugin/configuration export let meta; -let extensions, configProperties: Map; +let configProperties: Map; -$: extensions = []; $: configProperties = new Map(); $: sectionExpanded = {}; @@ -17,9 +16,6 @@ function toggleSection(provider: string) { } onMount(async () => { - extensionInfos.subscribe(value => { - extensions = value; - }); configurationProperties.subscribe(value => { configProperties = value .filter(property => property.scope === CONFIGURATION_DEFAULT_SCOPE) diff --git a/packages/renderer/src/lib/ContainerList.svelte b/packages/renderer/src/lib/ContainerList.svelte index 16a4cecdc37..e8021c48ec2 100644 --- a/packages/renderer/src/lib/ContainerList.svelte +++ b/packages/renderer/src/lib/ContainerList.svelte @@ -279,10 +279,6 @@ function toggleCreateContainer(): void { openChoiceModal = !openChoiceModal; } -function runContainerYaml(): void { - router.goto('/containers/play'); -} - function fromDockerfile(): void { openChoiceModal = false; router.goto('/images/build'); diff --git a/packages/renderer/src/lib/container/ContainerActions.svelte b/packages/renderer/src/lib/container/ContainerActions.svelte index 3697cb54a36..9a2d9007d33 100644 --- a/packages/renderer/src/lib/container/ContainerActions.svelte +++ b/packages/renderer/src/lib/container/ContainerActions.svelte @@ -23,10 +23,10 @@ export let detailed = false; export let inProgressCallback: (inProgress: boolean, state?: string) => void = () => {}; export let errorCallback: (erroMessage: string) => void = () => {}; -async function startContainer(containerInfo: ContainerInfoUI) { +async function startContainer() { inProgressCallback(true, 'STARTING'); try { - await window.startContainer(containerInfo.engineId, containerInfo.id); + await window.startContainer(container.engineId, container.id); } catch (error) { errorCallback(error); } finally { @@ -34,10 +34,10 @@ async function startContainer(containerInfo: ContainerInfoUI) { } } -async function restartContainer(containerInfo: ContainerInfoUI) { +async function restartContainer() { inProgressCallback(true, 'RESTARTING'); try { - await window.restartContainer(containerInfo.engineId, containerInfo.id); + await window.restartContainer(container.engineId, container.id); } catch (error) { errorCallback(error); } finally { @@ -45,10 +45,10 @@ async function restartContainer(containerInfo: ContainerInfoUI) { } } -async function stopContainer(containerInfo: ContainerInfoUI) { +async function stopContainer() { inProgressCallback(true, 'STOPPING'); try { - await window.stopContainer(containerInfo.engineId, containerInfo.id); + await window.stopContainer(container.engineId, container.id); } catch (error) { errorCallback(error); } finally { @@ -56,18 +56,18 @@ async function stopContainer(containerInfo: ContainerInfoUI) { } } -function openBrowser(containerInfo: ContainerInfoUI): void { - window.openExternal(containerInfo.openingUrl); +function openBrowser(): void { + window.openExternal(container.openingUrl); } -function openLogs(containerInfo: ContainerInfoUI): void { +function openLogs(): void { router.goto(`/containers/${container.id}/logs`); } -async function deleteContainer(containerInfo: ContainerInfoUI): Promise { +async function deleteContainer(): Promise { inProgressCallback(true, 'DELETING'); try { - await window.deleteContainer(containerInfo.engineId, containerInfo.id); + await window.deleteContainer(container.engineId, container.id); router.goto('/containers/'); } catch (error) { errorCallback(error); @@ -76,7 +76,7 @@ async function deleteContainer(containerInfo: ContainerInfoUI): Promise { } } -function openTerminalContainer(containerInfo: ContainerInfoUI): void { +function openTerminalContainer(): void { router.goto(`/containers/${container.id}/terminal`); } @@ -100,7 +100,7 @@ if (dropdownMenu) {