From 5ff2d7790dcf5a25bcd5fa42c827fcac6ccf8317 Mon Sep 17 00:00:00 2001
From: Florent Benoit <fbenoit@redhat.com>
Date: Wed, 10 Aug 2022 22:10:41 +0200
Subject: [PATCH] website: fix missing links fixes
 https://github.com/containers/podman-desktop/issues/390

Change-Id: Id5b86afe9f30279793aee6c2056616e38d00501c
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
---
 website/src/pages/downloads/linux.tsx   | 8 +-------
 website/src/pages/downloads/macOS.tsx   | 8 +-------
 website/src/pages/downloads/windows.tsx | 7 +------
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/website/src/pages/downloads/linux.tsx b/website/src/pages/downloads/linux.tsx
index 72dc9e37580..e6411170129 100644
--- a/website/src/pages/downloads/linux.tsx
+++ b/website/src/pages/downloads/linux.tsx
@@ -8,14 +8,9 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { faDownload } from '@fortawesome/free-solid-svg-icons';
 import { faLinux } from '@fortawesome/free-brands-svg-icons';
 
-let grabbed = false;
-
 async function grabfilenameforMac(
   setDownloadData: React.Dispatch<SetStateAction<{ version: string; binary: string }>>,
 ): Promise<void> {
-  if (grabbed) {
-    return;
-  }
   const result = await fetch('https://api.github.com/repos/containers/podman-desktop/releases/latest');
   const jsonContent = await result.json();
   const assets = jsonContent.assets;
@@ -37,7 +32,6 @@ async function grabfilenameforMac(
   };
 
   setDownloadData(data);
-  grabbed = true;
 }
 
 export function LinuxDownloads(): JSX.Element {
@@ -49,7 +43,7 @@ export function LinuxDownloads(): JSX.Element {
 
   useEffect(() => {
     grabfilenameforMac(setDownloadData);
-  });
+  }, []);
 
   return (
     <section className=" dark:bg-zinc-800 bg-zinc-200 py-24 dark:text-gray-300 text-gray-700">
diff --git a/website/src/pages/downloads/macOS.tsx b/website/src/pages/downloads/macOS.tsx
index 20615555ddc..fa20b1ced4d 100644
--- a/website/src/pages/downloads/macOS.tsx
+++ b/website/src/pages/downloads/macOS.tsx
@@ -8,14 +8,9 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { faApple } from '@fortawesome/free-brands-svg-icons';
 import { faBeer, faDownload, faPaste, faTerminal } from '@fortawesome/free-solid-svg-icons';
 
-let grabbed = false;
-
 async function grabfilenameforMac(
   setDownloadData: React.Dispatch<SetStateAction<{ version: string; x64: string; arm64: string }>>,
 ): Promise<void> {
-  if (grabbed) {
-    return;
-  }
   const result = await fetch('https://api.github.com/repos/containers/podman-desktop/releases/latest');
   const jsonContent = await result.json();
   const assets = jsonContent.assets;
@@ -45,7 +40,6 @@ async function grabfilenameforMac(
     arm64: armLink.browser_download_url,
   };
   setDownloadData(data);
-  grabbed = true;
 }
 
 export function MacOSDownloads(): JSX.Element {
@@ -62,7 +56,7 @@ export function MacOSDownloads(): JSX.Element {
 
   useEffect(() => {
     grabfilenameforMac(setDownloadData);
-  });
+  }, []);
   return (
     <section className=" dark:bg-zinc-900 bg-zinc-100 py-24 dark:text-gray-300 text-gray-700">
       <div className="w-5/6 mx-auto">
diff --git a/website/src/pages/downloads/windows.tsx b/website/src/pages/downloads/windows.tsx
index 62983333511..704665472d7 100644
--- a/website/src/pages/downloads/windows.tsx
+++ b/website/src/pages/downloads/windows.tsx
@@ -7,14 +7,10 @@ import Link from '@docusaurus/Link';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { faWindows } from '@fortawesome/free-brands-svg-icons';
 import { faDownload } from '@fortawesome/free-solid-svg-icons';
-let grabbed = false;
 
 async function grabfilenameforMac(
   setDownloadData: React.Dispatch<SetStateAction<{ version: string; binary: string; setup: string }>>,
 ): Promise<void> {
-  if (grabbed) {
-    return;
-  }
   const result = await fetch('https://api.github.com/repos/containers/podman-desktop/releases/latest');
   const jsonContent = await result.json();
   const assets = jsonContent.assets;
@@ -34,7 +30,6 @@ async function grabfilenameforMac(
     setup: windowsSetupAsset.browser_download_url,
   };
   setDownloadData(data);
-  grabbed = true;
 }
 
 export function WindowsDownloads(): JSX.Element {
@@ -46,7 +41,7 @@ export function WindowsDownloads(): JSX.Element {
 
   useEffect(() => {
     grabfilenameforMac(setDownloadData);
-  });
+  }, []);
 
   return (
     <section className=" dark:bg-zinc-800 bg-zinc-200 py-24 dark:text-gray-300 text-gray-700">